Skip to contentSkip to conversation

ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

PATCH New Gregory CLEMENT 3 participants 4 messages Aug 23, 2013

Subsystems (2)
Device tree bindings I2C subsystem host drivers
lore
Share & tools
lore

Gregory CLEMENT

author
#0 lore raw

PATCH v7 1/1 ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

The mv64xxx-i2c embedded in the Armada XP have a new feature to offload i2c transaction. This new version of the IP come also with some errata. This lead to the introduction to a another compatible string.

This commit updates the Device Tree binding documentation accordingly.

Signed-off-by Gregory CLEMENT <[email protected]>

---
Changelog v6 -> v7:

- only keep "marvell,mv7230-i2c" for compatible name

- replace "For a controller which support the I2C Transaction Generator" by "For the Armada XP" in the examples

 Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++++++
 1 file changed, 10 insertions(+)
Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt +10 -0
index 6113f92..73cdc03 100644
@@ -5,6 +5,7 @@ Required properties :
 
  - reg             : Offset and length of the register set for the device
  - compatible      : Should be "marvell,mv64xxx-i2c" or "allwinner,sun4i-i2c"
+                     or "marvell,mv7230-i2c"
  - interrupts      : The interrupt number
 
 Optional properties :

@@ -20,3 +21,12 @@ Examples:
 		interrupts = <29>;
 		clock-frequency = <100000>;
 	};
+
+For the Armada XP:
+
+	i2c at 11000 {
+		compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
+		reg = <0x11000 0x100>;
+		interrupts = <29>;
+		clock-frequency = <100000>;
+	};
Signature · 1 line
1.8.1.2
Applied
#1 lore raw

PATCH v7 1/1 ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

Quoted 8 lines · Gregory CLEMENT

The mv64xxx-i2c embedded in the Armada XP have a new feature to offload i2c transaction. This new version of the IP come also with some errata. This lead to the introduction to a another compatible string.

This commit updates the Device Tree binding documentation accordingly.

Signed-off-by Gregory CLEMENT <[email protected]>

Applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130823/ed1612ea/attachment.sig>

#2 lore raw

PATCH v7 1/1 ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

In reply to Gregory CLEMENT
Quoted 24 lines · Gregory CLEMENT

The mv64xxx-i2c embedded in the Armada XP have a new feature to offload i2c transaction. This new version of the IP come also with some errata. This lead to the introduction to a another compatible string.

This commit updates the Device Tree binding documentation accordingly.

Signed-off-by Gregory CLEMENT <[email protected]>

---
Changelog v6 -> v7:

- only keep "marvell,mv7230-i2c" for compatible name

- replace "For a controller which support the I2C Transaction Generator" by "For the Armada XP" in the examples

 Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++++++
 1 file changed, 10 insertions(+)
Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt +0 -0
index 6113f92..73cdc03 100644

Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt Required properties : · line 8

Quoted 4 lines
Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt +1 -0
@@ -5,6 +5,7 @@ Required properties :
 
  - reg             : Offset and length of the register set for the device
  - compatible      : Should be "marvell,mv64xxx-i2c" or "allwinner,sun4i-i2c"
+                     or "marvell,mv7230-i2c"

Ok, the new string looks sane, so I'm not opposed to that.

Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt Examples: · line 28

Quoted 12 lines
Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt +5 -0
  - interrupts      : The interrupt number
 
 Optional properties :

@@ -20,3 +21,12 @@ Examples:
 		interrupts = <29>;
 		clock-frequency = <100000>;
 	};
+
+For the Armada XP:
+
+	i2c at 11000 {
+		compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";

^ That '8' shouldn't be there.

Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt Examples: · line 32

Quoted 4 lines
Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt +4 -0
+		reg = <0x11000 0x100>;
+		interrupts = <29>;
+		clock-frequency = <100000>;
+	};

Thanks,
Mark.

#3 lore raw

PATCH v7 1/1 ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

Quoted 4 lines

Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt Examples: · line 28

Quoted 3 lines
Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt +2 -0
+	i2c at 11000 {
+		compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";

^ That '8' shouldn't be there.

Oops, well, precisely the '8' is missing above. Fixed it, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130823/1dc1eaa9/attachment-0001.sig>