Skip to contentSkip to conversation

iio: adc: twl6030-gpadc: returning success instead of error

PATCH In review Dan Carpenter 2 participants 2 messages Aug 27, 2013 – Aug 28, 2013 1 message not in the archive IIO

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 iio: adc: twl6030-gpadc: returning success instead of error

I've moved the goto down a line after we set the error code.

Signed-off-by Dan Carpenter <[email protected]>
drivers/iio/adc/twl6030-gpadc.c +1 -1
index a558516..0ea96c0 100644
@@ -537,8 +537,8 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
 		ret = -ETIMEDOUT;
 		goto err;
 	} else if (timeout < 0) {
-		goto err;
 		ret = -EINTR;
+		goto err;
 	}
 
 	switch (mask) {

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 3 lines · Dan Carpenter

I've moved the goto down a line after we set the error code.

Signed-off-by Dan Carpenter <[email protected]>

Sorry, I was being slow, but Wei Youngjun has already posted a fix for this one. Just applied to the togreg branch of iio.git

Thanks

Jonathan

Quoted 20 lines
drivers/iio/adc/twl6030-gpadc.c +1 -2
index a558516..0ea96c0 100644
@@ -537,8 +537,8 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
 		ret = -ETIMEDOUT;
 		goto err;
 	} else if (timeout < 0) {
-		goto err;
 		ret = -EINTR;
+		goto err;
 	}
 
 	switch (mask) {
--

To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html