Skip to contentSkip to conversation

lspci: Decode PCIe Link registers only for devices with links

PATCH Applied Bjorn Helgaas 2 participants 2 messages Aug 28, 2013 – Nov 10, 2013 PCI

lore
Share & tools
lore

Bjorn Helgaas

author maintainer
#0 lore raw

PATCH 1/1 lspci: Decode PCIe Link registers only for devices with links

Root Complex Integrated Endpoints and Root Complex Event Collectors do not have links and are not permitted to implement Link or Link 2 registers, per PCIe spec r3.0, sec 1.3.2.3. Decoding them is useless and misleading.

---
 ls-caps.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
ls-caps.c +7 -2
index 752a771..be19d38 100644
@@ -1074,6 +1074,7 @@ cap_express(struct device *d, int where, int cap)
   int type = (cap & PCI_EXP_FLAGS_TYPE) >> 4;
   int size;
   int slot = 0;
+  int link = 1;
 
   printf("Express ");
   if (verbose >= 2)
@@ -1104,9 +1105,11 @@ cap_express(struct device *d, int where, int cap)
       printf("PCI/PCI-X to PCI-Express Bridge");
       break;
     case PCI_EXP_TYPE_ROOT_INT_EP:
+      link = 0;
       printf("Root Complex Integrated Endpoint");
       break;
     case PCI_EXP_TYPE_ROOT_EC:
+      link = 0;
       printf("Root Complex Event Collector");
       break;
     default:
@@ -1125,7 +1128,8 @@ cap_express(struct device *d, int where, int cap)
     return;
 
   cap_express_dev(d, where, type);
-  cap_express_link(d, where, type);
+  if (link)
+    cap_express_link(d, where, type);
   if (slot)
     cap_express_slot(d, where);
   if (type == PCI_EXP_TYPE_ROOT_PORT)
@@ -1141,7 +1145,8 @@ cap_express(struct device *d, int where, int cap)
     return;
 
   cap_express_dev2(d, where, type);
-  cap_express_link2(d, where, type);
+  if (link)
+    cap_express_link2(d, where, type);
   if (slot)
     cap_express_slot2(d, where);
 }
Applied
#1 lore raw

Hi!

Quoted 3 lines

Root Complex Integrated Endpoints and Root Complex Event Collectors do not have links and are not permitted to implement Link or Link 2 registers, per PCIe spec r3.0, sec 1.3.2.3. Decoding them is useless and misleading.

Applied, thanks. And sorry for the delay.

Have a nice fortnight

Signature · 3 lines
Martin `MJ' Mares                          <[email protected]>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
Q: What color is a chameleon on a mirror?   A: The same.