Skip to contentSkip to conversation

ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data

PATCH New Simon Horman 3 participants 5 messages Aug 22, 2013 – Sep 10, 2013

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Simon Horman

author
#0 lore raw

PATCH 1/1 ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data

As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct sh_eth_plat_data'") is is no longer necessary or correct to use the 'register_type' field from 'struct sh_eth_plat_data' and doing so results in a build error.

Signed-off-by Simon Horman <[email protected]>

---

Olof,

as discussed, please apply this to for-next and merge it upstream after the patch mentioned above lands upstream via net-next.

---
 arch/arm/mach-shmobile/board-lager.c | 1 -
 1 file changed, 1 deletion(-)
arch/arm/mach-shmobile/board-lager.c +0 -1
index a7e54e5..8f50ed2 100644
@@ -96,7 +96,6 @@ static struct resource mmcif1_resources[] = {
 static struct sh_eth_plat_data ether_pdata __initdata = {
 	.phy			= 0x1,
 	.edmac_endian		= EDMAC_LITTLE_ENDIAN,
-	.register_type		= SH_ETH_REG_FAST_RCAR,
 	.phy_interface		= PHY_INTERFACE_MODE_RMII,
 	.ether_link_active_low	= 1,
 };
Signature · 1 line
1.8.3.2
Applied
#1 lore raw

PATCH 1/1 ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data

Quoted 7 lines · Simon Horman

As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct sh_eth_plat_data'") is is no longer necessary or correct to use the 'register_type' field from 'struct sh_eth_plat_data' and doing so results in a build error.

Signed-off-by Simon Horman <[email protected]>
Quoted 7 lines

---

Olof,

as discussed, please apply this to for-next and merge it upstream after the patch mentioned above lands upstream via net-next.
---

Thanks, applied. Please help me remember to send this upstream if I forget. :)

-Olof

#2 lore raw

PATCH 1/1 ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data

Quoted 10 lines · Olof Johansson
Quoted 9 lines · Simon Horman

As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct sh_eth_plat_data'") is is no longer necessary or correct to use the 'register_type' field from 'struct sh_eth_plat_data' and doing so results in a build error.

Signed-off-by Simon Horman <[email protected]>

---

Quoted 7 lines
Quoted 5 lines

Olof,

as discussed, please apply this to for-next and merge it upstream after the patch mentioned above lands upstream via net-next.
---

Thanks, applied. Please help me remember to send this upstream if I forget. :)

Of course, I'll keep track of this.

Applied
#3 lore raw

PATCH 1/1 ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data

In reply to Simon Horman
Quoted 6 lines · Simon Horman

As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct sh_eth_plat_data'") is is no longer necessary or correct to use the 'register_type' field from 'struct sh_eth_plat_data' and doing so results in a build error.

Signed-off-by Simon Horman <[email protected]>

Applied to fixes.

-Olof

#4 lore raw

PATCH 1/1 ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data

Quoted 9 lines · Olof Johansson
Quoted 6 lines · Simon Horman

As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct sh_eth_plat_data'") is is no longer necessary or correct to use the 'register_type' field from 'struct sh_eth_plat_data' and doing so results in a build error.

Signed-off-by Simon Horman <[email protected]>

Applied to fixes.

Thanks, it will be nice to get this out of our collective hair.