Skip to contentSkip to conversation

makedumpfile: reverse -c and -p if using snappy compression

PATCH In review Cliff Wickman 6 participants 10 messages Aug 28, 2013 – Sep 10, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 makedumpfile: reverse -c and -p if using snappy compression

From: Cliff Wickman <[email protected]>

Reverse the meanings of -c (compression) and -p (snappy compression) if USESNAPPY is defined.

The distro kdump scripts seem to only support -c for compression. So make -c mean snappy compression if it is supported.

Diffed against makedumpfile-1.5.4

---
 makedumpfile.c |   10 ++++++++++
 print_info.c   |   13 +++++++++----
 2 files changed, 19 insertions(+), 4 deletions(-)
makedumpfile.c +10 -0
Index: makedumpfile-1.5.4/makedumpfile.c
===================================================================
@@ -8607,7 +8607,12 @@ main(int argc, char *argv[])
 			info->name_filterconfig = optarg;
 			break;
 		case 'c':
+#ifdef USESNAPPY
+			/* if snappy is available make it the default */
+			info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#else
 			info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#endif
 			break;
 		case 'D':
 			flag_debug = TRUE;
@@ -8656,7 +8661,12 @@ main(int argc, char *argv[])
 			info->flag_dmesg = 1;
 			break;
 		case 'p':
+#ifdef USESNAPPY
+			/* is snappy is available only use zlib with -p */
+			info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#else
 			info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#endif
 			break;
 		case 'P':
 			info->xen_phys_start = strtoul(optarg, NULL, 0);
print_info.c +9 -4
Index: makedumpfile-1.5.4/print_info.c
===================================================================
@@ -41,9 +41,9 @@ print_usage(void)
 #endif
 	MSG("snappy support:\n");
 #ifdef USESNAPPY
-	MSG("  enabled\n");
+	MSG("  enabled using -c\n");
 #else
-	MSG("  disabled ('-p' option will be ignored.)\n");
+	MSG("  disabled\n");
 #endif
 	MSG("\n");
 	MSG("Usage:\n");
@@ -90,8 +90,13 @@ print_usage(void)
 	MSG("\n");
 	MSG("Available options:\n");
 	MSG("  [-c|-l|-p]:\n");
-	MSG("      Compress dump data by each page using zlib for -c option, lzo for -l option\n");
-	MSG("      or snappy for -p option. A user cannot specify either of these options with\n");
+#ifdef USESNAPPY
+	MSG("      Compress dump data by each page using zlib for -p option, lzo for -l option\n");
+	MSG("      or snappy for -c option. A user cannot specify any of these options with\n");
+#else
+	MSG("      Compress dump data by each page using zlib for -c option or lzo for -l option\n");
+	MSG("      A user cannot specify either of these options with\n");
+#endif
 	MSG("      -E option, because the ELF format does not support compressed data.\n");
 	MSG("      THIS IS ONLY FOR THE CRASH UTILITY.\n");
 	MSG("\n");

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw

Hi, Cliff

Quoted 7 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

Reverse the meanings of -c (compression) and -p (snappy compression) if USESNAPPY is defined.

The distro kdump scripts seem to only support -c for compression. So make -c mean snappy compression if it is supported.

It looks like more a distro issue to me. I'm wondering if that script only support -c, why do that distro compile makedumpfile with USESNAPPY?

I don't think other distros would like to see this change. IMHO, the right thing to do is fix that kdump script on that particular distro, not reverse -c and -p.

Thanks
WANG Chao

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#2 lore raw
Quoted 14 lines · WANG Chao

Hi, Cliff

Quoted 7 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

Reverse the meanings of -c (compression) and -p (snappy compression) if USESNAPPY is defined.

The distro kdump scripts seem to only support -c for compression. So make -c mean snappy compression if it is supported.

It looks like more a distro issue to me. I'm wondering if that script only support -c, why do that distro compile makedumpfile with USESNAPPY?

Quoted 6 lines

I don't think other distros would like to see this change. IMHO, the right thing to do is fix that kdump script on that particular distro, not reverse -c and -p.

Thanks
WANG Chao

I agree that some distros could easily change their default compression choice, for example -c to -p in RHEL's /etc/kdump.conf.

But on the other hand SLES11 just uses KDUMP_DUMPFORMAT="compressed" in /etc/sysconfig/kdump. Translation to -c occurs somewhere under the covers.
Makedumpfile could change the default meaning of "compressed" to snappy compression on the grounds that we know snappy to be much faster than zlib compression. And so we default to it if available.
You would in that way make the intelligent choice without administrative intervention.
(You would also have to assume that crash is also be built snappy-capable for a system that supports snappy compression.)

I could see it either way.
I find this patch a convenient way to make the choice.

-Cliff

Signature · 9 lines
Cliff Wickman
SGI
[email protected]
(651) 683-3824

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
#3 lore raw
Quoted 22 lines · Cliff Wickman
Quoted 14 lines · WANG Chao

Hi, Cliff

Quoted 7 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

Reverse the meanings of -c (compression) and -p (snappy compression) if USESNAPPY is defined.

The distro kdump scripts seem to only support -c for compression. So make -c mean snappy compression if it is supported.

It looks like more a distro issue to me. I'm wondering if that script only support -c, why do that distro compile makedumpfile with USESNAPPY?

Quoted 6 lines

I don't think other distros would like to see this change. IMHO, the right thing to do is fix that kdump script on that particular distro, not reverse -c and -p.

Thanks
WANG Chao

Quoted 6 lines

I agree that some distros could easily change their default compression choice, for example -c to -p in RHEL's /etc/kdump.conf.

But on the other hand SLES11 just uses KDUMP_DUMPFORMAT="compressed" in /etc/sysconfig/kdump. Translation to -c occurs somewhere under the covers.

Instead, it's reasonable to patch SLES11 kdump utility, not upstream.

-c means using zlib and -p means using snappy. That's already established and has been widely used.

Quoted 3 lines

Makedumpfile could change the default meaning of "compressed" to snappy compression on the grounds that we know snappy to be much faster than zlib compression. And so we default to it if available.

IMO, makedumpfile doesn't have default compression format. c/p/l means zlib/snappy/lzo by each. If you don't specify one of them, makedumpfile wouldn't do compression work.

You could assume -c means default compression format, but I see it means compress with zlib.

Quoted 2 lines

You would in that way make the intelligent choice without administrative intervention.

The intelligent choice can be made within distro specific kdump script rather than makedumpfile.

Quoted 5 lines

(You would also have to assume that crash is also be built snappy-capable for a system that supports snappy compression.)

I could see it either way.
I find this patch a convenient way to make the choice.

This patch could cause regression and break current existing kdump scripts. I wouldn't worry much about the -c (zlib) user though.

As for the people using -p to snappy compression, after upgrading their makedumpfile, they would get zlib format dump if their kdump conf remain untouched.

Thanks
WANG Chao

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#4 lore raw
Quoted 23 lines · WANG Chao
Quoted 22 lines · Cliff Wickman
Quoted 20 lines · WANG Chao

Hi, Cliff

Quoted 7 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

Reverse the meanings of -c (compression) and -p (snappy compression) if USESNAPPY is defined.

The distro kdump scripts seem to only support -c for compression. So make -c mean snappy compression if it is supported.

It looks like more a distro issue to me. I'm wondering if that script only support -c, why do that distro compile makedumpfile with USESNAPPY?

I don't think other distros would like to see this change. IMHO, the right thing to do is fix that kdump script on that particular distro, not reverse -c and -p.

Thanks
WANG Chao

Quoted 8 lines
Quoted 6 lines

I agree that some distros could easily change their default compression choice, for example -c to -p in RHEL's /etc/kdump.conf.

But on the other hand SLES11 just uses KDUMP_DUMPFORMAT="compressed" in /etc/sysconfig/kdump. Translation to -c occurs somewhere under the covers.

Instead, it's reasonable to patch SLES11 kdump utility, not upstream.

Yes, it should be resolved in distro side.

Quoted 7 lines

-c means using zlib and -p means using snappy. That's already established and has been widely used.

Quoted 3 lines

Makedumpfile could change the default meaning of "compressed" to snappy compression on the grounds that we know snappy to be much faster than zlib compression. And so we default to it if available.

Quoted 6 lines

IMO, makedumpfile doesn't have default compression format. c/p/l means zlib/snappy/lzo by each. If you don't specify one of them, makedumpfile wouldn't do compression work.

You could assume -c means default compression format, but I see it means compress with zlib.

I agree to WANG. -c just means to compress with zlib. There is no mention of default format also in the man page.

-c,-l,-p
Compress dump data by each page using zlib for -c option, lzo
for -l option or snappy for -p option. (-l option needs
USELZO=on and -p option needs USESNAPPY=on when building)

Thanks
Atsushi Kumagai

Quoted 15 lines
Quoted 2 lines

You would in that way make the intelligent choice without administrative intervention.

The intelligent choice can be made within distro specific kdump script rather than makedumpfile.

Quoted 5 lines

(You would also have to assume that crash is also be built snappy-capable for a system that supports snappy compression.)

I could see it either way.
I find this patch a convenient way to make the choice.

This patch could cause regression and break current existing kdump scripts. I wouldn't worry much about the -c (zlib) user though.

Quoted 8 lines

As for the people using -p to snappy compression, after upgrading their makedumpfile, they would get zlib format dump if their kdump conf remain untouched.

Thanks
WANG Chao

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#5 lore raw
In reply to Cliff Wickman

USESNAPPY is a switch which the snappy support has been built into. With this flag, it means snappy compression algorithm is available. Which compression algorithm is taken need be decided by -c/-l/-p.

If I make a build with USELZO and USESNAPPY, then I want to test zlib/lzo/snappy separately, then this patch will confuse me very much. Current action and configuration are enough for me. So it's better to leave the current action alone.

Baoquan
Thanks

Quoted 78 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

Reverse the meanings of -c (compression) and -p (snappy compression) if USESNAPPY is defined.

The distro kdump scripts seem to only support -c for compression. So make -c mean snappy compression if it is supported.

Diffed against makedumpfile-1.5.4

---
 makedumpfile.c |   10 ++++++++++
 print_info.c   |   13 +++++++++----
 2 files changed, 19 insertions(+), 4 deletions(-)

Index: makedumpfile-1.5.4/makedumpfile.c
===================================================================

makedumpfile.c +10 -0
@@ -8607,7 +8607,12 @@ main(int argc, char *argv[])
 			info->name_filterconfig = optarg;
 			break;
 		case 'c':
+#ifdef USESNAPPY
+			/* if snappy is available make it the default */
+			info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#else
 			info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#endif
 			break;
 		case 'D':
 			flag_debug = TRUE;
@@ -8656,7 +8661,12 @@ main(int argc, char *argv[])
 			info->flag_dmesg = 1;
 			break;
 		case 'p':
+#ifdef USESNAPPY
+			/* is snappy is available only use zlib with -p */
+			info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#else
 			info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#endif
 			break;
 		case 'P':
 			info->xen_phys_start = strtoul(optarg, NULL, 0);

Index: makedumpfile-1.5.4/print_info.c
===================================================================

print_info.c +9 -4
@@ -41,9 +41,9 @@ print_usage(void)
 #endif
 	MSG("snappy support:\n");
 #ifdef USESNAPPY
-	MSG("  enabled\n");
+	MSG("  enabled using -c\n");
 #else
-	MSG("  disabled ('-p' option will be ignored.)\n");
+	MSG("  disabled\n");
 #endif
 	MSG("\n");
 	MSG("Usage:\n");
@@ -90,8 +90,13 @@ print_usage(void)
 	MSG("\n");
 	MSG("Available options:\n");
 	MSG("  [-c|-l|-p]:\n");
-	MSG("      Compress dump data by each page using zlib for -c option, lzo for -l option\n");
-	MSG("      or snappy for -p option. A user cannot specify either of these options with\n");
+#ifdef USESNAPPY
+	MSG("      Compress dump data by each page using zlib for -p option, lzo for -l option\n");
+	MSG("      or snappy for -c option. A user cannot specify any of these options with\n");
+#else
+	MSG("      Compress dump data by each page using zlib for -c option or lzo for -l option\n");
+	MSG("      A user cannot specify either of these options with\n");
+#endif
 	MSG("      -E option, because the ELF format does not support compressed data.\n");
 	MSG("      THIS IS ONLY FOR THE CRASH UTILITY.\n");
 	MSG("\n");
Quoted 4 lines

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#6 lore raw

I think that better is to have:

-cz zlib
-cs snappy
-cl zlo
-ca - automatic selection of compression. Snappy if compiled in, then lzo. And if no snappy and lzo then zlib.

this will make options more readable.

Best regards.
Maxim.

2013/8/30 Baoquan He <[email protected]>:

Quoted 100 lines

USESNAPPY is a switch which the snappy support has been built into. With this flag, it means snappy compression algorithm is available. Which compression algorithm is taken need be decided by -c/-l/-p.

If I make a build with USELZO and USESNAPPY, then I want to test zlib/lzo/snappy separately, then this patch will confuse me very much. Current action and configuration are enough for me. So it's better to leave the current action alone.

Baoquan
Thanks

Quoted 78 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

Reverse the meanings of -c (compression) and -p (snappy compression) if USESNAPPY is defined.

The distro kdump scripts seem to only support -c for compression. So make -c mean snappy compression if it is supported.

Diffed against makedumpfile-1.5.4

---
 makedumpfile.c |   10 ++++++++++
 print_info.c   |   13 +++++++++----
 2 files changed, 19 insertions(+), 4 deletions(-)

Index: makedumpfile-1.5.4/makedumpfile.c
===================================================================

makedumpfile.c +10 -0
@@ -8607,7 +8607,12 @@ main(int argc, char *argv[])
                      info->name_filterconfig = optarg;
                      break;
              case 'c':
+#ifdef USESNAPPY
+                     /* if snappy is available make it the default */
+                     info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#else
                      info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#endif
                      break;
              case 'D':
                      flag_debug = TRUE;
@@ -8656,7 +8661,12 @@ main(int argc, char *argv[])
                      info->flag_dmesg = 1;
                      break;
              case 'p':
+#ifdef USESNAPPY
+                     /* is snappy is available only use zlib with -p */
+                     info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#else
                      info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#endif
                      break;
              case 'P':
                      info->xen_phys_start = strtoul(optarg, NULL, 0);

Index: makedumpfile-1.5.4/print_info.c
===================================================================

print_info.c +9 -4
@@ -41,9 +41,9 @@ print_usage(void)
 #endif
      MSG("snappy support:\n");
 #ifdef USESNAPPY
-     MSG("  enabled\n");
+     MSG("  enabled using -c\n");
 #else
-     MSG("  disabled ('-p' option will be ignored.)\n");
+     MSG("  disabled\n");
 #endif
      MSG("\n");
      MSG("Usage:\n");
@@ -90,8 +90,13 @@ print_usage(void)
      MSG("\n");
      MSG("Available options:\n");
      MSG("  [-c|-l|-p]:\n");
-     MSG("      Compress dump data by each page using zlib for -c option, lzo for -l option\n");
-     MSG("      or snappy for -p option. A user cannot specify either of these options with\n");
+#ifdef USESNAPPY
+     MSG("      Compress dump data by each page using zlib for -p option, lzo for -l option\n");
+     MSG("      or snappy for -c option. A user cannot specify any of these options with\n");
+#else
+     MSG("      Compress dump data by each page using zlib for -c option or lzo for -l option\n");
+     MSG("      A user cannot specify either of these options with\n");
+#endif
      MSG("      -E option, because the ELF format does not support compressed data.\n");
      MSG("      THIS IS ONLY FOR THE CRASH UTILITY.\n");
      MSG("\n");
Quoted 4 lines

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Signature · 7 lines
Best regards,
Maxim Uvarov

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
#7 lore raw

Hello Maxim,

Review

Quoted 5 lines · Maxim Uvarov

I think that better is to have:

(quoted diff) +0 -3
-cz zlib
-cs snappy
-cl zlo

They are main options for most users, so I don't want to change them without any important reason.

Quoted 2 lines

-ca - automatic selection of compression. Snappy if compiled in, then lzo. And if no snappy and lzo then zlib.

What is the selection standard ? Compression Speed ? If some users prefer compression ratio to compression speed, snappy isn't suitable for them.

Each compression format has both good points and bad points, so each user should select the format manually based on the purpose in any case.

Thanks
Atsushi Kumagai

Quoted 110 lines

this will make options more readable.

Best regards.
Maxim.

2013/8/30 Baoquan He <[email protected]>:

Quoted 100 lines

USESNAPPY is a switch which the snappy support has been built into. With this flag, it means snappy compression algorithm is available. Which compression algorithm is taken need be decided by -c/-l/-p.

If I make a build with USELZO and USESNAPPY, then I want to test zlib/lzo/snappy separately, then this patch will confuse me very much. Current action and configuration are enough for me. So it's better to leave the current action alone.

Baoquan
Thanks

Quoted 78 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

Reverse the meanings of -c (compression) and -p (snappy compression) if USESNAPPY is defined.

The distro kdump scripts seem to only support -c for compression. So make -c mean snappy compression if it is supported.

Diffed against makedumpfile-1.5.4

---
  makedumpfile.c |   10 ++++++++++
  print_info.c   |   13 +++++++++----
  2 files changed, 19 insertions(+), 4 deletions(-)

Index: makedumpfile-1.5.4/makedumpfile.c
===================================================================

makedumpfile.c +10 -0
@@ -8607,7 +8607,12 @@ main(int argc, char *argv[])
                       info->name_filterconfig = optarg;
                       break;
               case 'c':
+#ifdef USESNAPPY
+                     /* if snappy is available make it the default */
+                     info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#else
                       info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#endif
                       break;
               case 'D':
                       flag_debug = TRUE;
@@ -8656,7 +8661,12 @@ main(int argc, char *argv[])
                       info->flag_dmesg = 1;
                       break;
               case 'p':
+#ifdef USESNAPPY
+                     /* is snappy is available only use zlib with -p */
+                     info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#else
                       info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#endif
                       break;
               case 'P':
                       info->xen_phys_start = strtoul(optarg, NULL, 0);

Index: makedumpfile-1.5.4/print_info.c
===================================================================

print_info.c +9 -4
@@ -41,9 +41,9 @@ print_usage(void)
  #endif
       MSG("snappy support:\n");
  #ifdef USESNAPPY
-     MSG("  enabled\n");
+     MSG("  enabled using -c\n");
  #else
-     MSG("  disabled ('-p' option will be ignored.)\n");
+     MSG("  disabled\n");
  #endif
       MSG("\n");
       MSG("Usage:\n");
@@ -90,8 +90,13 @@ print_usage(void)
       MSG("\n");
       MSG("Available options:\n");
       MSG("  [-c|-l|-p]:\n");
-     MSG("      Compress dump data by each page using zlib for -c option, lzo for -l option\n");
-     MSG("      or snappy for -p option. A user cannot specify either of these options with\n");
+#ifdef USESNAPPY
+     MSG("      Compress dump data by each page using zlib for -p option, lzo for -l option\n");
+     MSG("      or snappy for -c option. A user cannot specify any of these options with\n");
+#else
+     MSG("      Compress dump data by each page using zlib for -c option or lzo for -l option\n");
+     MSG("      A user cannot specify either of these options with\n");
+#endif
       MSG("      -E option, because the ELF format does not support compressed data.\n");
       MSG("      THIS IS ONLY FOR THE CRASH UTILITY.\n");
       MSG("\n");
Quoted 4 lines

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#8 lore raw

2013/9/10 Atsushi Kumagai <[email protected]>:

Quoted 24 lines

Hello Maxim,

Review

Quoted 6 lines · Maxim Uvarov

I think that better is to have:

(quoted diff) +0 -3
-cz zlib
-cs snappy
-cl zlo

They are main options for most users, so I don't want to change them without any important reason.

Quoted 2 lines

-ca - automatic selection of compression. Snappy if compiled in, then lzo. And if no snappy and lzo then zlib.

What is the selection standard ? Compression Speed ? If some users prefer compression ratio to compression speed, snappy isn't suitable for them.

Quoted 6 lines

Each compression format has both good points and bad points, so

each user should select the format manually based on the purpose in any case.

That definitely does not work in real life. Nobody wants to set up something, read manual and understand all options. More than that - if you somehow updated configs and set up wrong option you will not receive any dump instead of receiving dump with different compression.

BR,
Maxim.

Quoted 126 lines

Thanks
Atsushi Kumagai

Quoted 120 lines

this will make options more readable.

Best regards.
Maxim.

2013/8/30 Baoquan He <[email protected]>:

Quoted 109 lines

USESNAPPY is a switch which the snappy support has been built into. With this flag, it means snappy compression algorithm is available. Which compression algorithm is taken need be decided by -c/-l/-p.

If I make a build with USELZO and USESNAPPY, then I want to test zlib/lzo/snappy separately, then this patch will confuse me very much. Current action and configuration are enough for me. So it's better to leave the current action alone.

Baoquan
Thanks

Quoted 85 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

Reverse the meanings of -c (compression) and -p (snappy compression) if USESNAPPY is defined.

The distro kdump scripts seem to only support -c for compression. So make -c mean snappy compression if it is supported.

Diffed against makedumpfile-1.5.4

---
  makedumpfile.c |   10 ++++++++++
  print_info.c   |   13 +++++++++----
  2 files changed, 19 insertions(+), 4 deletions(-)

Index: makedumpfile-1.5.4/makedumpfile.c
===================================================================

makedumpfile.c +10 -0
@@ -8607,7 +8607,12 @@ main(int argc, char *argv[])
                       info->name_filterconfig = optarg;
                       break;
               case 'c':
+#ifdef USESNAPPY
+                     /* if snappy is available make it the default */
+                     info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#else
                       info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#endif
                       break;
               case 'D':
                       flag_debug = TRUE;
@@ -8656,7 +8661,12 @@ main(int argc, char *argv[])
                       info->flag_dmesg = 1;
                       break;
               case 'p':
+#ifdef USESNAPPY
+                     /* is snappy is available only use zlib with -p */
+                     info->flag_compress = DUMP_DH_COMPRESSED_ZLIB;
+#else
                       info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
+#endif
                       break;
               case 'P':
                       info->xen_phys_start = strtoul(optarg, NULL, 0);

Index: makedumpfile-1.5.4/print_info.c
===================================================================

print_info.c +5 -4
@@ -41,9 +41,9 @@ print_usage(void)
  #endif
       MSG("snappy support:\n");
  #ifdef USESNAPPY
-     MSG("  enabled\n");
+     MSG("  enabled using -c\n");
  #else
-     MSG("  disabled ('-p' option will be ignored.)\n");
+     MSG("  disabled\n");
  #endif
       MSG("\n");
       MSG("Usage:\n");
@@ -90,8 +90,13 @@ print_usage(void)
       MSG("\n");
       MSG("Available options:\n");
       MSG("  [-c|-l|-p]:\n");
-     MSG("      Compress dump data by each page using zlib for -c
 option, lzo for -l option\n");
-     MSG("      or snappy for -p option. A user cannot specify either
 of these options with\n");
+#ifdef USESNAPPY
+     MSG("      Compress dump data by each page using zlib for -p
 option, lzo for -l option\n");
+     MSG("      or snappy for -c option. A user cannot specify any of

these options with\n");

print_info.c +2 -0
+#else
+     MSG("      Compress dump data by each page using zlib for -c

option or lzo for -l option\n");

print_info.c +2 -0
+     MSG("      A user cannot specify either of these options with\n");
+#endif
       MSG("      -E option, because the ELF format does not support
compressed data.\n");
       MSG("      THIS IS ONLY FOR THE CRASH UTILITY.\n");
       MSG("\n");
Quoted 4 lines

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Signature · 7 lines
Best regards,
Maxim Uvarov

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
#9 lore raw
Quoted 32 lines · Maxim Uvarov

2013/9/10 Atsushi Kumagai <[email protected]>:

Quoted 24 lines

Hello Maxim,

Review

Quoted 6 lines · Maxim Uvarov

I think that better is to have:

(quoted diff) +0 -3
-cz zlib
-cs snappy
-cl zlo

They are main options for most users, so I don't want to change them without any important reason.

Quoted 2 lines

-ca - automatic selection of compression. Snappy if compiled in, then lzo. And if no snappy and lzo then zlib.

What is the selection standard ? Compression Speed ? If some users prefer compression ratio to compression speed, snappy isn't suitable for them.

Quoted 6 lines

Each compression format has both good points and bad points, so

each user should select the format manually based on the purpose in any case.

Quoted 7 lines

That definitely does not work in real life. Nobody wants to set up something, read manual and understand all options. More than that - if you somehow updated configs and set up wrong option you will not receive any dump instead of receiving dump with different compression.

BR,
Maxim.

It's extreme logic. System administrator should configurate own system with sufficient understanding, in particular on large mission critical system. If he failed to get any dump due to wrong configuration, it's his fault. For most systems with typical memory size, zlib still works enough.

Also, snappy is not always better than lzo. For example, although lzo 2.0.3 is slower than snappy, lzo 2.0.6 is almost as quick as snappy, since recent lzo is optimized enough for x86 use. Then, some distribution has lzo 2.0.3 while another lzo 2.0.6. Hence, in general, the quickest compression varies on each systems. It's difficult for makedumpfile to choose quickest one in general. Futhermore, makedumpfile might support more formats in the future, the difficulty would get bigger. I don't think automation is good idea.

Signature · 8 lines
Thanks.
HATAYAMA, Daisuke


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec