Skip to contentSkip to conversation

: about the paramters of func generic_file_buffered_write.

Question majianpeng 1 participant 1 message Aug 30, 2013 VFS

lore
Share & tools
lore

majianpeng

author
#0 lore raw

Hi all,
The definition of func generic_file_buffered_write is:
ssize_t generic_file_buffered_write(struct kiocb *, const struct iovec *,

                							unsigned long, loff_t, loff_t *, size_t, ssize_t);

The fourth and fifth paratmers indicate the current pos of file.
Every place which call this function, it set the fourth to iocb->ki_pos(maybe not but equal). The fifth parameter is set &iocb->ki_pos.

I think we can remove two parameters. Those parameter can replace by the files of struct kiocb in the fun of generic_file_buffered_write.

Or am i missing something?

Thansk!
Jianpeng Ma