knock: new package
PATCH 1/1 knock: new package
Hi,
sorry for the last post, where I combined two separate packages in one submission. I now moved them to different branches, cleaned up the 72 char line break as suggested in the other replies to submissions and this hopefully is more in line with what you expect. Altered title as well. The pyzmq package will follow shortly.
Cheers,
Michael.
A port knocking implementation with daemon and user application.
--- package/Config.in | 2 ++ package/knock/Config.in | 13 +++++++++++++ package/knock/knock.mk | 15 +++++++++++++++ 3 files changed, 30 insertions(+) create mode 100644 package/knock/Config.in create mode 100644 package/knock/knock.mk
package/Config.in +2 -0
@@ -363,6 +363,7 @@ source "package/python-protobuf/Config.in" source "package/python-pygame/Config.in" source "package/python-pyparsing/Config.in" source "package/python-pyro/Config.in" +source "package/python-pyzmq/Config.in" source "package/python-serial/Config.in" source "package/python-setuptools/Config.in" source "package/python-thrift/Config.in"
@@ -754,6 +755,7 @@ source "package/ipset/Config.in" source "package/iptables/Config.in" source "package/iw/Config.in" source "package/kismet/Config.in" +source "package/knock/Config.in" source "package/lighttpd/Config.in" source "package/linknx/Config.in" source "package/links/Config.in"
package/knock/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_KNOCK + bool "knock" + select BR2_PACKAGE_LIBPCAP + help + A port knocking implementation. + Provides a daemon and a user application. Port knocking can be + used to run an arbitrary application, once the daemon detects + a predefined sequence of incoming TCP/UDP packets on a network + interface. This can be used, e.g. to open up ports in a + firewall. + + See also: http://www.zeroflux.org/projects/knock +
package/knock/knock.mk new file +15 -0
@@ -0,0 +1,15 @@ +########################################## +# +# knock +# +########################################## + +KNOCK_VERSION=7666f2e86e18d482eaad5fe1fea46d87d80b0555 +KNOCK_SITE=https://github.com/jvinet/knock/tarball/master +KNOCK_LICENSE = GPLv2 +KNOCK_LICENSE_FILES = COPYING +KNOCK_AUTORECONF = YES +KNOCK_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install-sbinPROGRAMS + +$(eval $(autotools-package)) +
Signature · 1 line
1.7.9.5
PATCH 1/1 knock: new package
Hi Michael,
Op 30-aug.-2013 23:47 schreef "Michael Rommel" <[email protected]> het volgende:
Quoted 9 lines
Hi,
sorry for the last post, where I combined two separate packages in one submission. I now moved them to different branches, cleaned up the 72 char line break as suggested in the other replies to submissions and this hopefully is more in line with what you expect. Altered title as well. The pyzmq package will follow shortly.
Quoted 3 lines
Cheers,
Michael.
Thanks for splitting up the patch, that is indeed how it should be.
Note that anything from the start of your patch mail until the three dashes ---, will end up in the commit message, so it should not contain the above comments. You can put such comments below the three dashes.
Quoted 41 lines
A port knocking implementation with daemon and user application.
Signed-off-by Michael Rommel <[email protected]>--- package/Config.in | 2 ++ package/knock/Config.in | 13 +++++++++++++ package/knock/knock.mk | 15 +++++++++++++++ 3 files changed, 30 insertions(+) create mode 100644 package/knock/Config.in create mode 100644 package/knock/knock.mkpackage/Config.in +2
-0@@ -363,6 +363,7 @@ source "package/python-protobuf/Config.in" source "package/python-pygame/Config.in" source "package/python-pyparsing/Config.in" source "package/python-pyro/Config.in" +source "package/python-pyzmq/Config.in" source "package/python-serial/Config.in" source "package/python-setuptools/Config.in" source "package/python-thrift/Config.in"@@ -754,6 +755,7 @@ source "package/ipset/Config.in" source "package/iptables/Config.in" source "package/iw/Config.in" source "package/kismet/Config.in" +source "package/knock/Config.in" source "package/lighttpd/Config.in" source "package/linknx/Config.in" source "package/links/Config.in"package/knock/Config.in new file +2
-0@@ -0,0 +1,13 @@ +config BR2_PACKAGE_KNOCK + bool "knock"
package/knock/Config.in line 12
Quoted 10 lines
package/knock/Config.in new file +10
-0+ select BR2_PACKAGE_LIBPCAP + help + A port knocking implementation. + Provides a daemon and a user application. Port knocking can be + used to run an arbitrary application, once the daemon detects + a predefined sequence of incoming TCP/UDP packets on a network + interface. This can be used, e.g. to open up ports in a + firewall. + + See also: http://www.zeroflux.org/projects/knock
The 'See also: ' should be removed here, just leave the URL.
package/knock/knock.mk line 5
Quoted 12 lines
package/knock/Config.in new file +1
-0+package/knock/knock.mk new file +5
-0@@ -0,0 +1,15 @@ +########################################## +# +# knock +# +##########################################
These # lines should be 80 characters wide.
package/knock/knock.mk line 12
Quoted 7 lines
package/knock/knock.mk new file +7
-0+ +KNOCK_VERSION=7666f2e86e18d482eaad5fe1fea46d87d80b0555 +KNOCK_SITE=https://github.com/jvinet/knock/tarball/master +KNOCK_LICENSE = GPLv2 +KNOCK_LICENSE_FILES = COPYING +KNOCK_AUTORECONF = YES +KNOCK_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install-sbinPROGRAMS
Any particular reason why the standard 'install' rule doesn't work?
package/knock/knock.mk line 15
Quoted 3 lines
package/knock/knock.mk new file +3
-0+ +$(eval $(autotools-package)) +
This last empty line can be removed.
Best regards,
Thomas
PATCH 1/1 knock: new package
In reply to Michael RommelDear Michael Rommel,
Thanks for your contribution! I won't repeat the comments made by Thomas De Schampheleire since they are all obviously valid. Let me add one other nitpick comment below.
package/knock/knock.mk line 8
Quoted 2 lines · Michael Rommel
package/knock/knock.mk new file +2
-0+KNOCK_VERSION=7666f2e86e18d482eaad5fe1fea46d87d80b0555 +KNOCK_SITE=https://github.com/jvinet/knock/tarball/master
There should be spaces around the equal sign, like you did in the lines below.
Quoted 1 line
+KNOCK_LICENSE = GPLv2
Is it really GPLv2 or GPLv2+ ? Can you check the copyright headers in the source files?
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com