Skip to contentSkip to conversation

qla2xxx: Add support for ISP8044.

SCSI Dan Carpenter 2 participants 2 messages Sep 2, 2013 – Sep 3, 2013 SCSI

lore
Share & tools
lore
#0 lore raw

Hello Atul Deshmukh,

This is a semi-automatic email about new static checker warnings.

The patch ef4647420025: "[SCSI] qla2xxx: Add support for ISP8044." from Aug 27, 2013, leads to the following Smatch complaint:

drivers/scsi/qla2xxx/qla_os.c:2962 qla2x00_probe_one()
error: we previously assumed 'base_vha' could be null (see line 2632)

drivers/scsi/qla2xxx/qla_os.c
2631 base_vha = qla2x00_create_host(sht, ha);

  2632		if (!base_vha) {
                     ^^^^^^^^

Existing check.

  2633			ret = -ENOMEM;
  2634			qla2x00_mem_free(ha);
  2635			qla2x00_free_req_que(ha, req);
  2636			qla2x00_free_rsp_que(ha, rsp);
  2637			goto probe_hw_failed;
  2638		}

[ snip ]

2954 probe_hw_failed:
2955 if (IS_QLA82XX(ha)) {
2956 qla82xx_idc_lock(ha);
2957 qla82xx_clear_drv_active(ha);
2958 qla82xx_idc_unlock(ha);
2959 }
2960 if (IS_QLA8044(ha)) {
2961 qla8044_idc_lock(ha);

  2962			qla8044_clear_drv_active(base_vha);
                                                 ^^^^^^^^

Patch adds dereference.

  2963			qla8044_idc_unlock(ha);
  2964		}

regards,
dan carpenter

#1 lore raw

Dan,

Thanks for the heads up. We'll fix this.

--Chad

Quoted 47 lines · Dan Carpenter

Hello Atul Deshmukh,

This is a semi-automatic email about new static checker warnings.

The patch ef4647420025: "[SCSI] qla2xxx: Add support for ISP8044." from Aug 27, 2013, leads to the following Smatch complaint:

drivers/scsi/qla2xxx/qla_os.c:2962 qla2x00_probe_one()
error: we previously assumed 'base_vha' could be null (see line 2632)

drivers/scsi/qla2xxx/qla_os.c
2631 base_vha = qla2x00_create_host(sht, ha);

 2632		if (!base_vha) {
                    ^^^^^^^^

Existing check.

2633 ret = -ENOMEM;
2634 qla2x00_mem_free(ha);
2635 qla2x00_free_req_que(ha, req);
2636 qla2x00_free_rsp_que(ha, rsp);
2637 goto probe_hw_failed;
2638 }

[ snip ]

2954 probe_hw_failed:
2955 if (IS_QLA82XX(ha)) {
2956 qla82xx_idc_lock(ha);
2957 qla82xx_clear_drv_active(ha);
2958 qla82xx_idc_unlock(ha);
2959 }
2960 if (IS_QLA8044(ha)) {
2961 qla8044_idc_lock(ha);

 2962			qla8044_clear_drv_active(base_vha);
                                                ^^^^^^^^

Patch adds dereference.

2963 qla8044_idc_unlock(ha);
2964 }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html