arm64: add support for kernel mode NEON
PATCH v2 1/1 arm64: add support for kernel mode NEON
Add <asm/neon.h> containing kernel_neon_begin/kernel_neon_end function declarations and corresponding definitions in fpsimd.c
These are needed to wrap uses of NEON in kernel mode. The names are identical to the ones used in arm/ so code using intrinsics or vectorized by GCC can be shared between arm and arm64.
--- arch/arm64/Kconfig | 3 +++ arch/arm64/include/asm/neon.h | 14 ++++++++++++++ arch/arm64/kernel/fpsimd.c | 28 ++++++++++++++++++++++++++++ 3 files changed, 45 insertions(+) create mode 100644 arch/arm64/include/asm/neon.h
arch/arm64/Kconfig +3 -0
@@ -95,6 +95,9 @@ config SWIOTLB config IOMMU_HELPER def_bool SWIOTLB +config KERNEL_MODE_NEON + def_bool y + source "init/Kconfig" source "kernel/Kconfig.freezer"
arch/arm64/include/asm/neon.h new file +14 -0
@@ -0,0 +1,14 @@ +/* +* linux/arch/arm64/include/asm/neon.h +* +* Copyright (C) 2013 Linaro Ltd <[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +*/ + +#define cpu_has_neon () (1) + +void kernel_neon_begin (void ); +void kernel_neon_end (void );
arch/arm64/kernel/fpsimd.c +28 -0
@@ -21,6 +21,7 @@#include <linux/init.h> #include <linux/sched.h> #include <linux/signal.h> +#include <linux/hardirq.h> #include <asm/fpsimd.h> #include <asm/cputype.h>
@@ -83,6 +84,33 @@ void fpsimd_flush_thread(void)fpsimd_load_state (¤t->thread.fpsimd_state); } +#ifdef CONFIG_KERNEL_MODE_NEON + +/* +* Kernel-side NEON support functions +*/ +void kernel_neon_begin (void ) +{ +/* Avoid using the NEON in interrupt context */ +BUG_ON (in_interrupt ()); +preempt_disable (); + +if (current->mm) +fpsimd_save_state (¤t->thread.fpsimd_state); +} +EXPORT_SYMBOL (kernel_neon_begin); + +void kernel_neon_end (void ) +{ +if (current->mm) +fpsimd_load_state (¤t->thread.fpsimd_state); + +preempt_enable (); +} +EXPORT_SYMBOL (kernel_neon_end); + +#endif /* CONFIG_KERNEL_MODE_NEON */ +/* * FP/SIMD support code initialisation. */
Signature · 1 line
1.8.1.2
PATCH v2 1/1 arm64: add support for kernel mode NEON
Hello Catalin,
Now that the ARM version of this patch has been accepted by Russell, would you please consider taking this in as well?
Regards,
Ard.
Quoted 98 lines · Ard Biesheuvel
Add <
asm/neon.h> containing kernel_neon_begin/kernel_neon_end function declarations and corresponding definitions infpsimd.cThese are needed to wrap uses of NEON in kernel mode. The names are identical to the ones used in arm/ so code using intrinsics or vectorized by GCC can be shared between arm and arm64.
Signed-off-by Ard Biesheuvel <[email protected]>--- arch/arm64/Kconfig | 3 +++ arch/arm64/include/asm/neon.h | 14 ++++++++++++++ arch/arm64/kernel/fpsimd.c | 28 ++++++++++++++++++++++++++++ 3 files changed, 45 insertions(+) create mode 100644 arch/arm64/include/asm/neon.harch/arm64/Kconfig +3
-0@@ -95,6 +95,9 @@ config SWIOTLB config IOMMU_HELPER def_bool SWIOTLB +config KERNEL_MODE_NEON + def_bool y + source "init/Kconfig" source "kernel/Kconfig.freezer"arch/arm64/include/asm/neon.h new file +14
-0@@ -0,0 +1,14 @@ +/* +* linux/arch/arm64/include/asm/neon.h +* +* Copyright (C) 2013 Linaro Ltd <[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +*/ + +#define cpu_has_neon () (1) + +void kernel_neon_begin (void ); +void kernel_neon_end (void );arch/arm64/kernel/fpsimd.c +28
-1@@ -21,6 +21,7 @@#include <linux/init.h> #include <linux/sched.h> #include <linux/signal.h> +#include <linux/hardirq.h> #include <asm/fpsimd.h> #include <asm/cputype.h> @@ -83,6 +84,33 @@ void fpsimd_flush_thread(void)fpsimd_load_state (¤t->thread.fpsimd_state); } +#ifdef CONFIG_KERNEL_MODE_NEON + +/* +* Kernel-side NEON support functions +*/ +void kernel_neon_begin (void ) +{ +/* Avoid using the NEON in interrupt context */ +BUG_ON (in_interrupt ()); +preempt_disable (); + +if (current->mm) +fpsimd_save_state (¤t->thread.fpsimd_state); +} +EXPORT_SYMBOL (kernel_neon_begin); + +void kernel_neon_end (void ) +{ +if (current->mm) +fpsimd_load_state (¤t->thread.fpsimd_state); + +preempt_enable (); +} +EXPORT_SYMBOL (kernel_neon_end); + +#endif /* CONFIG_KERNEL_MODE_NEON */ +/* * FP/SIMD support code initialisation. */ --1.8.1.2
Catalin Marinas
maintainerPATCH v2 1/1 arm64: add support for kernel mode NEON
Quoted 2 lines · Ard Biesheuvel
Now that the ARM version of this patch has been accepted by Russell, would you please consider taking this in as well?
It's already in my 'upstream' branch (and linux-next). It will get into 3.12.
Thanks.
Signature · 1 line
Catalin