Skip to contentSkip to conversation

Fix style in s3c-hsotg.c

PATCH Pavel Machek 5 participants 11 messages Sep 2, 2013 – Sep 25, 2013 USB

lore
Share & tools
lore
#0 lore raw

Hi!

checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
macro with if should be really enclosed in do {} while, and puts is going to be slightly faster.

Here's suggested patch. I don't have the hardware, so it is completely untested.

drivers/usb/gadget/s3c-hsotg.c +8 -6
index af22f24..f8e762a 100644
@@ -2091,12 +2091,14 @@ static void kill_all_requests(struct s3c_hsotg *hsotg,
 }
 
 #define call_gadget(_hs, _entry) \
+do { \
 	if ((_hs)->gadget.speed != USB_SPEED_UNKNOWN &&	\
 	    (_hs)->driver && (_hs)->driver->_entry) { \
 		spin_unlock(&_hs->lock); \
 		(_hs)->driver->_entry(&(_hs)->gadget); \
 		spin_lock(&_hs->lock); \
 		}
+} while (0)
 
 /**
  * s3c_hsotg_disconnect - disconnect service
@@ -3204,7 +3206,7 @@ static int state_show(struct seq_file *seq, void *v)
 		   readl(regs + GNPTXSTS),
 		   readl(regs + GRXSTSR));
 
-	seq_printf(seq, "\nEndpoint status:\n");
+	seq_puts(seq, "\nEndpoint status:\n");
 
 	for (idx = 0; idx < 15; idx++) {
 		u32 in, out;
@@ -3221,7 +3223,7 @@ static int state_show(struct seq_file *seq, void *v)
 		seq_printf(seq, ", DIEPTSIZ=0x%08x, DOEPTSIZ=0x%08x",
 			   in, out);
 
-		seq_printf(seq, "\n");
+		seq_puts(seq, "\n");
 	}
 
 	return 0;
@@ -3255,7 +3257,7 @@ static int fifo_show(struct seq_file *seq, void *v)
 	u32 val;
 	int idx;
 
-	seq_printf(seq, "Non-periodic FIFOs:\n");
+	seq_puts(seq, "Non-periodic FIFOs:\n");
 	seq_printf(seq, "RXFIFO: Size %d\n", readl(regs + GRXFSIZ));
 
 	val = readl(regs + GNPTXFSIZ);
@@ -3263,7 +3265,7 @@ static int fifo_show(struct seq_file *seq, void *v)
 		   val >> GNPTXFSIZ_NPTxFDep_SHIFT,
 		   val & GNPTXFSIZ_NPTxFStAddr_MASK);
 
-	seq_printf(seq, "\nPeriodic TXFIFOs:\n");
+	seq_puts(seq, "\nPeriodic TXFIFOs:\n");
 
 	for (idx = 1; idx <= 15; idx++) {
 		val = readl(regs + DPTXFSIZn(idx));
@@ -3334,7 +3336,7 @@ static int ep_show(struct seq_file *seq, void *v)
 		   readl(regs + DIEPTSIZ(index)),
 		   readl(regs + DOEPTSIZ(index)));
 
-	seq_printf(seq, "\n");
+	seq_puts(seq, "\n");
 	seq_printf(seq, "mps %d\n", ep->ep.maxpacket);
 	seq_printf(seq, "total_data=%ld\n", ep->total_data);
 
@@ -3345,7 +3347,7 @@ static int ep_show(struct seq_file *seq, void *v)
 
 	list_for_each_entry(req, &ep->queue, queue) {
 		if (--show_limit < 0) {
-			seq_printf(seq, "not showing more requests...\n");
+			seq_puts(seq, "not showing more requests...\n");
 			break;
 		}
 
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

Hello.

Quoted 14 lines · Pavel Machek

checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
macro with if should be really enclosed in do {} while, and puts is going to be slightly faster.

Here's suggested patch. I don't have the hardware, so it is completely untested.

drivers/usb/gadget/s3c-hsotg.c +0 -0
index af22f24..f8e762a 100644

drivers/usb/gadget/s3c-hsotg.c static void kill_all_requests(struct s3c_hsotg *hsotg, · line 2100

Quoted 10 lines
drivers/usb/gadget/s3c-hsotg.c +1 -0
@@ -2091,12 +2091,14 @@ static void kill_all_requests(struct s3c_hsotg *hsotg,
  }
 
  #define call_gadget(_hs, _entry) \
+do { \
  	if ((_hs)->gadget.speed != USB_SPEED_UNKNOWN &&	\
  	    (_hs)->driver && (_hs)->driver->_entry) { \
  		spin_unlock(&_hs->lock); \
  		(_hs)->driver->_entry(&(_hs)->gadget); \
  		spin_lock(&_hs->lock); \
  		}

Indentation also needs fixing on this line, maybe in another patch...

drivers/usb/gadget/s3c-hsotg.c static void kill_all_requests(struct s3c_hsotg *hsotg, · line 2101

Quoted 1 line
drivers/usb/gadget/s3c-hsotg.c +1 -0
+} while (0)

WBR, Sergei

#2 lore raw
In reply to Pavel Machek

Hi,

Quoted 10 lines · Pavel Machek

Hi!

checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
macro with if should be really enclosed in do {} while, and puts is going to be slightly faster.

Here's suggested patch. I don't have the hardware, so it is completely untested.

this is not how you send a patch, please read
Documentation/SubmittingPatches

Signature · 1 line
balbi
#3 lore raw
Quoted 9 lines · Felipe Balbi

Hi,

Quoted 6 lines · Pavel Machek

Hi!

checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
macro with if should be really enclosed in do {} while, and puts is going to be slightly faster.

Quoted 7 lines
Quoted 4 lines

Here's suggested patch. I don't have the hardware, so it is completely untested.

this is not how you send a patch, please read
Documentation/SubmittingPatches

Have you considered possibility that this is how you nudge maintainer into fix their coding style?

Thanks,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#4 lore raw
Quoted 13 lines · Pavel Machek
Quoted 12 lines · Felipe Balbi

Hi,

Quoted 9 lines · Pavel Machek

Hi!

checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
macro with if should be really enclosed in do {} while, and puts is going to be slightly faster.

Here's suggested patch. I don't have the hardware, so it is completely untested.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

this is not how you send a patch, please read
Documentation/SubmittingPatches

Have you considered possibility that this is how you nudge maintainer into fix their coding style?

cute...

Seriously though, read that file, you're commit log has garbage in it which shouldn't go to git history.

Signature · 1 line
balbi
#5 lore raw
Quoted 19 lines · Felipe Balbi
Quoted 18 lines · Pavel Machek
Quoted 16 lines · Felipe Balbi

Hi,

Quoted 10 lines · Pavel Machek

Hi!

checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
macro with if should be really enclosed in do {} while, and puts is going to be slightly faster.

Here's suggested patch. I don't have the hardware, so it is completely untested.

this is not how you send a patch, please read
Documentation/SubmittingPatches

Quoted 7 lines
Quoted 2 lines

Have you considered possibility that this is how you nudge maintainer into fix their coding style?

cute...

Seriously though, read that file, you're commit log has garbage in it which shouldn't go to git history.

Run git log on SubmittingPatches.

Then, instead of telling me what to read, run checkpatch on your files. You can either fix them yourself, or use my patch as a basis. Note there's missing } or something, so it probably will not compile, see the other mail. So you actually will have to modify that patch. Stripping "Hi!" from it should not be that hard, neither should be stripping note that patch is untested when you actually test it. And as you are the maintainer, it is your job.

No, I'll not polish patch for hardware I don't have and have little interest in. wanted to help you, but according to your first reply, you do not really want help.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#6 lore raw

Hi,

Quoted 30 lines · Pavel Machek
Quoted 19 lines · Felipe Balbi
Quoted 18 lines · Pavel Machek
Quoted 16 lines · Felipe Balbi

Hi,

Quoted 10 lines · Pavel Machek

Hi!

checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
macro with if should be really enclosed in do {} while, and puts is going to be slightly faster.

Here's suggested patch. I don't have the hardware, so it is completely untested.

this is not how you send a patch, please read
Documentation/SubmittingPatches

Quoted 7 lines
Quoted 2 lines

Have you considered possibility that this is how you nudge maintainer into fix their coding style?

cute...

Seriously though, read that file, you're commit log has garbage in it which shouldn't go to git history.

Run git log on SubmittingPatches.

Quoted 7 lines

Then, instead of telling me what to read, run checkpatch on your files. You can either fix them yourself, or use my patch as a basis. Note there's missing } or something, so it probably will not compile, see the other mail. So you actually will have to modify that patch. Stripping "Hi!" from it should not be that hard, neither should be stripping note that patch is untested when you actually test it. And as you are the maintainer, it is your job.

you misunderstand the work of maintainers. Our work is not to fix you crappy patches. If we start allowing crappy patches, we'd be fixing your nonsense forever and linux wouldn't move.

Quoted 3 lines

No, I'll not polish patch for hardware I don't have and have little interest in. wanted to help you, but according to your first reply, you do not really want help.

that's your call. Now how about you stop being such a baby and go fix your mistakes to start with ? Just because I'm the maintainer of the gadget framework, doesn't mean I'm the maintainer of s3c-hsotc.c file. Maintainer != author too, btw.

Anyway, I got much better stuff to do than babysitting grown ups.

cheers

Signature · 1 line
balbi
#7 lore raw

Hi,

Quoted 41 lines · Felipe Balbi

Hi,

Quoted 30 lines · Pavel Machek
Quoted 19 lines · Felipe Balbi
Quoted 18 lines · Pavel Machek
Quoted 16 lines · Felipe Balbi

Hi,

Quoted 10 lines · Pavel Machek

Hi!

checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
macro with if should be really enclosed in do {} while, and puts is going to be slightly faster.

Here's suggested patch. I don't have the hardware, so it is completely untested.

this is not how you send a patch, please read
Documentation/SubmittingPatches

Quoted 7 lines
Quoted 2 lines

Have you considered possibility that this is how you nudge maintainer into fix their coding style?

cute...

Seriously though, read that file, you're commit log has garbage in it which shouldn't go to git history.

Run git log on SubmittingPatches.

Quoted 7 lines

Then, instead of telling me what to read, run checkpatch on your files. You can either fix them yourself, or use my patch as a basis. Note there's missing } or something, so it probably will not compile, see the other mail. So you actually will have to modify that patch. Stripping "Hi!" from it should not be that hard, neither should be stripping note that patch is untested when you actually test it. And as you are the maintainer, it is your job.

Quoted 3 lines

you misunderstand the work of maintainers. Our work is not to fix you crappy patches. If we start allowing crappy patches, we'd be fixing your nonsense forever and linux wouldn't move.

Pavel, Felipe's remark was valid..

Quoted 10 lines
Quoted 3 lines

No, I'll not polish patch for hardware I don't have and have little interest in. wanted to help you, but according to your first reply, you do not really want help.

that's your call. Now how about you stop being such a baby and go fix your mistakes to start with ? Just because I'm the maintainer of the gadget framework, doesn't mean I'm the maintainer of s3c-hsotc.c file. Maintainer != author too, btw.

Anyway, I got much better stuff to do than babysitting grown ups.

..even if it could have been communicated in a gentler way.

Anyway s3c-hsotg.c is a driver for our hardware so I'm going to pick this patch up, polish it and then re-submit it later. Thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

#8 lore raw

Hi,

Quoted 11 lines · Bartlomiej Zolnierkiewicz

Pavel, Felipe's remark was valid..

Quoted 9 lines
Quoted 3 lines

No, I'll not polish patch for hardware I don't have and have little interest in. wanted to help you, but according to your first reply, you do not really want help.

that's your call. Now how about you stop being such a baby and go fix your mistakes to start with ? Just because I'm the maintainer of the gadget framework, doesn't mean I'm the maintainer of s3c-hsotc.c file. Maintainer != author too, btw.

Quoted 6 lines
Quoted 1 line

Anyway, I got much better stuff to do than babysitting grown ups.

..even if it could have been communicated in a gentler way.

Anyway s3c-hsotg.c is a driver for our hardware so I'm going to pick this patch up, polish it and then re-submit it later. Thanks.

I tried a few times being nice and the response was always in the lines of "you should go fix the patch yourself if you don't like it" (not exactly these words, but same message). After some time of being nice and get nowhere, I just got fed up.

cheers

Signature · 1 line
balbi
#9 lore raw

Hi!

Quoted 15 lines
Quoted 15 lines

Pavel, Felipe's remark was valid..

Quoted 10 lines
Quoted 3 lines

No, I'll not polish patch for hardware I don't have and have little interest in. wanted to help you, but according to your first reply, you do not really want help.

that's your call. Now how about you stop being such a baby and go fix your mistakes to start with ? Just because I'm the maintainer of the gadget framework, doesn't mean I'm the maintainer of s3c-hsotc.c file. Maintainer != author too, btw.

Anyway, I got much better stuff to do than babysitting grown ups.

..even if it could have been communicated in a gentler way.

Quoted 7 lines
Quoted 2 lines

Anyway s3c-hsotg.c is a driver for our hardware so I'm going to pick this patch up, polish it and then re-submit it later. Thanks.

I tried a few times being nice and the response was always in the lines of "you should go fix the patch yourself if you don't like it" (not exactly these words, but same message). After some time of being nice and get nowhere, I just got fed up.

For the record, this is Felipe's idea of being nice:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

this is not how you send a patch, please read
Documentation/SubmittingPatches

(What an useless reply. Yes, I know how to submit patches. I also know that patches need to be tested, so I was not interested in "proper" submission. I tried to explain the difference between submit patch for inclusion and make someone look at the patch and fix the code...)

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Have you considered possibility that this is how you nudge maintainer into fix their coding style?

(Felipe)

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

cute...

Seriously though, read that file, you're commit log has garbage in it which shouldn't go to git history.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#10 lore raw
In reply to Bartlomiej Zolnierkiewicz

Hi!

Quoted 9 lines
Quoted 9 lines
Quoted 3 lines

No, I'll not polish patch for hardware I don't have and have little interest in. wanted to help you, but according to your first reply, you do not really want help.

that's your call. Now how about you stop being such a baby and go fix your mistakes to start with ? Just because I'm the maintainer of the gadget framework, doesn't mean I'm the maintainer of s3c-hsotc.c file. Maintainer != author too, btw.

Quoted 6 lines
Quoted 1 line

Anyway, I got much better stuff to do than babysitting grown ups.

..even if it could have been communicated in a gentler way.

Anyway s3c-hsotg.c is a driver for our hardware so I'm going to pick this patch up, polish it and then re-submit it later. Thanks.

Here's version that should compile. Thanks,
Pavel

drivers/usb/gadget/s3c-hsotg.c +9 -7
index d69b36a..c8cdde0 100644
@@ -2092,12 +2092,14 @@ static void kill_all_requests(struct s3c_hsotg *hsotg,
 }
 
 #define call_gadget(_hs, _entry) \
+do { \
 	if ((_hs)->gadget.speed != USB_SPEED_UNKNOWN &&	\
 	    (_hs)->driver && (_hs)->driver->_entry) { \
 		spin_unlock(&_hs->lock); \
 		(_hs)->driver->_entry(&(_hs)->gadget); \
 		spin_lock(&_hs->lock); \
-		}
+		} \
+} while (0)
 
 /**
  * s3c_hsotg_disconnect - disconnect service
@@ -3205,7 +3207,7 @@ static int state_show(struct seq_file *seq, void *v)
 		   readl(regs + GNPTXSTS),
 		   readl(regs + GRXSTSR));
 
-	seq_printf(seq, "\nEndpoint status:\n");
+	seq_puts(seq, "\nEndpoint status:\n");
 
 	for (idx = 0; idx < 15; idx++) {
 		u32 in, out;
@@ -3222,7 +3224,7 @@ static int state_show(struct seq_file *seq, void *v)
 		seq_printf(seq, ", DIEPTSIZ=0x%08x, DOEPTSIZ=0x%08x",
 			   in, out);
 
-		seq_printf(seq, "\n");
+		seq_puts(seq, "\n");
 	}
 
 	return 0;
@@ -3256,7 +3258,7 @@ static int fifo_show(struct seq_file *seq, void *v)
 	u32 val;
 	int idx;
 
-	seq_printf(seq, "Non-periodic FIFOs:\n");
+	seq_puts(seq, "Non-periodic FIFOs:\n");
 	seq_printf(seq, "RXFIFO: Size %d\n", readl(regs + GRXFSIZ));
 
 	val = readl(regs + GNPTXFSIZ);
@@ -3264,7 +3266,7 @@ static int fifo_show(struct seq_file *seq, void *v)
 		   val >> GNPTXFSIZ_NPTxFDep_SHIFT,
 		   val & GNPTXFSIZ_NPTxFStAddr_MASK);
 
-	seq_printf(seq, "\nPeriodic TXFIFOs:\n");
+	seq_puts(seq, "\nPeriodic TXFIFOs:\n");
 
 	for (idx = 1; idx <= 15; idx++) {
 		val = readl(regs + DPTXFSIZn(idx));
@@ -3335,7 +3337,7 @@ static int ep_show(struct seq_file *seq, void *v)
 		   readl(regs + DIEPTSIZ(index)),
 		   readl(regs + DOEPTSIZ(index)));
 
-	seq_printf(seq, "\n");
+	seq_puts(seq, "\n");
 	seq_printf(seq, "mps %d\n", ep->ep.maxpacket);
 	seq_printf(seq, "total_data=%ld\n", ep->total_data);
 
@@ -3346,7 +3348,7 @@ static int ep_show(struct seq_file *seq, void *v)
 
 	list_for_each_entry(req, &ep->queue, queue) {
 		if (--show_limit < 0) {
-			seq_printf(seq, "not showing more requests...\n");
+			seq_puts(seq, "not showing more requests...\n");
 			break;
 		}
 
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html