Skip to contentSkip to conversation

gssd: suppress error message if rpc_pipefs dir disappears.

PATCH In review NeilBrown 2 participants 2 messages Sep 2, 2013 – Sep 5, 2013

Subsystems (2)
lore
Share & tools
lore

NeilBrown

author
#0 lore raw

PATCH 1/1 gssd: suppress error message if rpc_pipefs dir disappears.

It is possible for a race to cause a name to appear when an rpc_pipefs dir is scanned but to no longer be present when we try to open it.

So if the error is ENOENT, don't complain.

This is similar to

commit 5ac9bcfd820f09af4d3f87f1f7346d896f70bc9a

Author: David Jeffery <[email protected]>
Date:   Wed Jan 16 15:21:55 2013 -0500

rpc.idmapd: Ignore open failures in dirscancb()

which addressed a similar issue in idmapd.

utils/gssd/gssd_proc.c +3 -2
index b7e2bbb..2d3dbec 100644
@@ -467,8 +467,9 @@ process_clnt_dir(char *dir, char *pdir)
 	}
 	sprintf(clp->dirname, "%s/%s", pdir, dir);
 	if ((clp->dir_fd = open(clp->dirname, O_RDONLY)) == -1) {
-		printerr(0, "ERROR: can't open %s: %s\n",
-			 clp->dirname, strerror(errno));
+		if (errno != ENOENT)
+			printerr(0, "ERROR: can't open %s: %s\n",
+				 clp->dirname, strerror(errno));
 		goto fail_destroy_client;
 	}
 	fcntl(clp->dir_fd, F_SETSIG, DNOTIFY_SIGNAL);
#1 lore raw
Quoted 8 lines · NeilBrown

It is possible for a race to cause a name to appear when an rpc_pipefs dir is scanned but to no longer be present when we try to open it.

So if the error is ENOENT, don't complain.

This is similar to

commit 5ac9bcfd820f09af4d3f87f1f7346d896f70bc9a

Quoted 8 lines
Author: David Jeffery <[email protected]>
Date:   Wed Jan 16 15:21:55 2013 -0500

rpc.idmapd: Ignore open failures in dirscancb()

which addressed a similar issue in idmapd.

Committed!

steved.

Quoted 18 lines
utils/gssd/gssd_proc.c +3 -2
index b7e2bbb..2d3dbec 100644
@@ -467,8 +467,9 @@ process_clnt_dir(char *dir, char *pdir)
 	}
 	sprintf(clp->dirname, "%s/%s", pdir, dir);
 	if ((clp->dir_fd = open(clp->dirname, O_RDONLY)) == -1) {
-		printerr(0, "ERROR: can't open %s: %s\n",
-			 clp->dirname, strerror(errno));
+		if (errno != ENOENT)
+			printerr(0, "ERROR: can't open %s: %s\n",
+				 clp->dirname, strerror(errno));
 		goto fail_destroy_client;
 	}
 	fcntl(clp->dir_fd, F_SETSIG, DNOTIFY_SIGNAL);