caif: add a sanity check to the tty name
Subsystems (3)
PATCH 1/1 caif: add a sanity check to the tty name
"tty->name" and "name" are a 64 character buffers. My static checker complains because we add the "cf" on the front so it look like we are copying a 66 character string into a 64 character buffer.
Also if the name is larger than IFNAMSIZ (16) it triggers a BUG_ON() inside the call to alloc_netdev().
This is all under CAP_SYS_ADMIN so it's not a security fix, it just adds a little robustness.
drivers/net/caif/caif_serial.c +3 -1
@@ -347,7 +347,9 @@ static int ldisc_open(struct tty_struct *tty)/* release devices to avoid name collision */ ser_release (NULL ); -sprintf (name,"cf%s" , tty->name); + result =snprintf (name,sizeof (name),"cf%s" , tty->name); +if (result >=IFNAMSIZ ) +return -EINVAL ; dev =alloc_netdev (sizeof (*ser), name, caifdev_setup);if (!dev)return -ENOMEM ;
Hi Dan,
Agree, thank you!
With best regards,
Dmitry
Den 03. sep. 2013 11:02, skrev Dan Carpenter:
Quoted 4 lines
drivers/net/caif/caif_serial.c +3
-1-sprintf (name,"cf%s" , tty->name); + result =snprintf (name,sizeof (name),"cf%s" , tty->name); +if (result >=IFNAMSIZ ) +return -EINVAL ;
From: Dan Carpenter <[email protected]>
Date: Tue, 3 Sep 2013 12:02:32 +0300
Quoted 11 lines
"
tty->name" and "name" are a 64 character buffers. My static checker complains because we add the "cf" on the front so it look like we are copying a 66 character string into a 64 character buffer.Also if the name is larger than IFNAMSIZ (16) it triggers a
BUG_ON()inside the call toalloc_netdev().This is all under
CAP_SYS_ADMINso it's not a security fix, it just adds a little robustness.Signed-off-by Dan Carpenter <[email protected]>
Applied.