Skip to contentSkip to conversation

iser-target: introduce fast memory registration mode (FRWR)

DISCUSSION Dan Carpenter 1 participant 2 messages Sep 3, 2013 – Oct 19, 2013 1 message not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

Hello Vu Pham,

This is a semi-automatic email about new static checker warnings.

The patch 12050ce23475: "iser-target: introduce fast memory registration mode (FRWR)" from Aug 28, 2013, leads to the following Smatch complaint:

drivers/infiniband/ulp/isert/ib_isert.c:622 isert_connect_release()
warn: variable dereferenced before check 'device' (see line 598)

drivers/infiniband/ulp/isert/ib_isert.c
597 if (device->use_frwr)

                    ^^^^^^^^^^^^^^^^

Patch introduces dereference.

   598			isert_conn_free_frwr_pool(isert_conn);
   599	

[ snip ]

620 kfree(isert_conn);
621
622 if (device)

                    ^^^^^^

Existing check.

   623			isert_device_try_release(device);
   624	

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

What ever happened with this?

regards,
dan carpenter

Quoted 25 lines · Dan Carpenter

Hello Vu Pham,

This is a semi-automatic email about new static checker warnings.

The patch 12050ce23475: "iser-target: introduce fast memory registration mode (FRWR)" from Aug 28, 2013, leads to the following Smatch complaint:

drivers/infiniband/ulp/isert/ib_isert.c:622 isert_connect_release()
warn: variable dereferenced before check 'device' (see line 598)

drivers/infiniband/ulp/isert/ib_isert.c
597 if (device->use_frwr)

                    ^^^^^^^^^^^^^^^^

Patch introduces dereference.

   598			isert_conn_free_frwr_pool(isert_conn);
   599	

[ snip ]

   620		kfree(isert_conn);
   621	
   622		if (device)
                    ^^^^^^
Quoted 7 lines

Existing check.

   623			isert_device_try_release(device);
   624	

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html