libata: bugfix: Remove __le32 in ata_tf_to_fis
PATCH 1/1 libata: bugfix: Remove __le32 in ata_tf_to_fis
From: Marc Carino <[email protected]>
The endianness attribute on the 'aux' local variable is a wrong, and can lead to issues on big-endian machines,
Signed-off-by Marc Carino <[email protected]>
--- drivers/ata/libata-core.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/ata/libata-core.c +4 -6
@@ -546,8 +546,6 @@ int atapi_cmd_type(u8 opcode)*/ void ata_tf_to_fis (const struct ata_taskfile *tf,u8 pmp,int is_cmd,u8 *fis) { -const __le32 aux =cpu_to_le32 (tf->auxiliary); - fis[0 ] =0x27 ;/* Register - Host to Device FIS */ fis[1 ] = pmp &0xf ;/* Port multiplier number*/ if (is_cmd)
@@ -571,10 +569,10 @@ void ata_tf_to_fis(const struct ata_taskfile *tf, u8 pmp, int is_cmd, u8 *fis) fis[14 ] =0 ; fis[15 ] = tf->ctl; - fis[16 ] = aux &0xff ; - fis[17 ] = (aux >>8 ) &0xff ; - fis[18 ] = (aux >>16 ) &0xff ; - fis[19 ] = (aux >>24 ) &0xff ; + fis[16 ] = tf->auxiliary &0xff ; + fis[17 ] = (tf->auxiliary >>8 ) &0xff ; + fis[18 ] = (tf->auxiliary >>16 ) &0xff ; + fis[19 ] = (tf->auxiliary >>24 ) &0xff ; }/**
Signature · 1 line
1.8.1.2
Tejun Heo
AppliedQuoted 6 lines · Marc C
From: Marc Carino <[email protected]>
The endianness attribute on the 'aux' local variable is a wrong, and can lead to issues on big-endian machines,
Signed-off-by Marc Carino <[email protected]>
Applied to libata/for-3.12.
Thanks.
Signature · 1 line
tejun