Skip to contentSkip to conversation

netplug: properly install init.d script.

PATCH New Peter Sanford 3 participants 3 messages Sep 3, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netplug: properly install init.d script.

Looks like this was lost in 20d4792e.

---
 package/netplug/netplug.mk |    7 +++++++
 1 file changed, 7 insertions(+)
package/netplug/netplug.mk +7 -0
index fbc7a2d..36bd3f7 100644
@@ -16,6 +16,13 @@ define NETPLUG_INSTALL_TARGET_CMDS
 	$(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install
 endef
 
+define NETPLUG_INSTALL_INITSCRIPT
+	$(INSTALL) -m 0755 -D package/netplug/S29netplug \
+		$(TARGET_DIR)/etc/init.d/S29netplug
+endef
+
+NETPLUG_POST_INSTALL_TARGET_HOOKS += NETPLUG_INSTALL_INITSCRIPT
+
 define NETPLUG_UNINSTALL_TARGET_CMDS
 	rm -f $(TARGET_DIR)/sbin/netplugd
 	rm -rf $(TARGET_DIR)/etc/netplug*
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 netplug: properly install init.d script.

Dear Peter Sanford,

Quoted 12 lines · Peter Sanford

Looks like this was lost in 20d4792e.

---
 package/netplug/netplug.mk |    7 +++++++
 1 file changed, 7 insertions(+)
package/netplug/netplug.mk +0 -0
index fbc7a2d..36bd3f7 100644

package/netplug/netplug.mk define NETPLUG_INSTALL_TARGET_CMDS · line 24

Quoted 9 lines
package/netplug/netplug.mk +6 -0
@@ -16,6 +16,13 @@ define NETPLUG_INSTALL_TARGET_CMDS
 	$(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install
 endef
 
+define NETPLUG_INSTALL_INITSCRIPT
+	$(INSTALL) -m 0755 -D package/netplug/S29netplug \
+		$(TARGET_DIR)/etc/init.d/S29netplug
+endef
+
+NETPLUG_POST_INSTALL_TARGET_HOOKS += NETPLUG_INSTALL_INITSCRIPT

Looks good, but it should use NETPLUG_INSTALL_INIT_SYSV instead. See the Buildroot manual for details,
http://buildroot.org/downloads/manual/manual.html.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 netplug: properly install init.d script.

In reply to Peter Sanford
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Sanford <[email protected]> writes:

Peter> Looks like this was lost in 20d4792e.
Peter> Signed-off-by: Peter Sanford <[email protected]> Peter> ---

 Peter>  package/netplug/netplug.mk |    7 +++++++

Peter> 1 file changed, 7 insertions(+)

Peter> diff --git a/package/netplug/netplug.mk b/package/netplug/netplug.mk Peter> index fbc7a2d..36bd3f7 100644
Peter> --- a/package/netplug/netplug.mk
Peter> +++ b/package/netplug/netplug.mk
Peter> @@ -16,6 +16,13 @@ define NETPLUG_INSTALL_TARGET_CMDS
Peter> $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install
Peter> endef

Peter> +define NETPLUG_INSTALL_INITSCRIPT
Peter> + $(INSTALL) -m 0755 -D package/netplug/S29netplug \
Peter> + $(TARGET_DIR)/etc/init.d/S29netplug
Peter> +endef

Committed with this changed to use NETPLUG_INSTALL_INIT_SYSV, thanks.

Signature · 1 line
Bye, Peter Korsgaard