iio: ST clean-ups and new pressure sensor device
Subsystems (3)
cover iio: ST clean-ups and new pressure sensor device
This patch-set includes a few clean-ups surrounding error handling and non-mandatory functionality along with regulator support and the addition of a new pressure/temperature sensor (LPS001WP). Everything has been tested with Device Tree.
arch/arm/boot/dts/ste-dbx5x0.dtsi | 5 -- arch/arm/boot/dts/ste-snowball.dts | 10 ++++ arch/arm/configs/u8500_defconfig | 4 ++ drivers/iio/common/st_sensors/st_sensors_core.c | 11 ++-- drivers/iio/pressure/st_pressure.h | 1 + drivers/iio/pressure/st_pressure_core.c | 276 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------- drivers/iio/pressure/st_pressure_i2c.c | 18 +++---- include/linux/iio/common/st_sensors.h | 4 ++ 8 files changed, 230 insertions(+), 99 deletions(-)
PATCH 1/11 ARM: ux500: Remove PrimeCell IDs from Nomadik I2C DT nodes
Turns out that they're actually not required and the driver probes just fine without them. The ID is incorrect at the moment anyway. They actually currently specify the stn8815.
--- arch/arm/boot/dts/ste-dbx5x0.dtsi | 5 ----- 1 file changed, 5 deletions(-)
arch/arm/boot/dts/ste-dbx5x0.dtsi +0 -5
@@ -531,7 +531,6 @@ compatible = "stericsson,db8500-i2c", "st,nomadik-i2c", "arm,primecell"; reg = <0x80004000 0x1000>; interrupts = <0 21 IRQ_TYPE_LEVEL_HIGH>; - arm,primecell-periphid = <0x180024>; #address-cells = <1>; #size-cells = <0>;
@@ -544,7 +543,6 @@ compatible = "stericsson,db8500-i2c", "st,nomadik-i2c", "arm,primecell"; reg = <0x80122000 0x1000>; interrupts = <0 22 IRQ_TYPE_LEVEL_HIGH>; - arm,primecell-periphid = <0x180024>; #address-cells = <1>; #size-cells = <0>;
@@ -557,7 +555,6 @@ compatible = "stericsson,db8500-i2c", "st,nomadik-i2c", "arm,primecell"; reg = <0x80128000 0x1000>; interrupts = <0 55 IRQ_TYPE_LEVEL_HIGH>; - arm,primecell-periphid = <0x180024>; #address-cells = <1>; #size-cells = <0>;
@@ -570,7 +567,6 @@ compatible = "stericsson,db8500-i2c", "st,nomadik-i2c", "arm,primecell"; reg = <0x80110000 0x1000>; interrupts = <0 12 IRQ_TYPE_LEVEL_HIGH>; - arm,primecell-periphid = <0x180024>; #address-cells = <1>; #size-cells = <0>;
@@ -583,7 +579,6 @@ compatible = "stericsson,db8500-i2c", "st,nomadik-i2c", "arm,primecell"; reg = <0x8012a000 0x1000>; interrupts = <0 51 IRQ_TYPE_LEVEL_HIGH>; - arm,primecell-periphid = <0x180024>; #address-cells = <1>; #size-cells = <0>;
Signature · 1 line
1.8.1.2
PATCH 2/11 ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT
In reply to Lee JonesAfter applying this node the LPS001WP sensor chip should probe successfully once the driver support has also been applied.
--- arch/arm/boot/dts/ste-snowball.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/ste-snowball.dts +10 -0
@@ -153,6 +153,16 @@ status = "okay"; }; + i2c at 80128000 { + lps001wp at 5c { + compatible = "lps001wp"; + reg = <0x5c>; + + vdd-supply = <&ab8500_ldo_aux1_reg>; + vms-supply = <&db8500_vsmps2_reg>; + }; + }; + uart at 80120000 { status = "okay"; };
Signature · 1 line
1.8.1.2
Re: [PATCH 02/11] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT
Hi Lee,
Quoted 16 lines · Lee Jones
After applying this node the LPS001WP sensor chip should probe successfully once the driver support has also been applied.
Signed-off-by Lee Jones <[email protected]>--- arch/arm/boot/dts/ste-snowball.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/ste-snowball.dts +0
-0@@ -153,6 +153,16 @@ status = "okay"; };
arch/arm/boot/dts/ste-snowball.dts line 165
Quoted 10 lines
arch/arm/boot/dts/ste-snowball.dts +10
-0+ i2c at 80128000 { + lps001wp at 5c { + compatible = "lps001wp"; + reg = <0x5c>; + + vdd-supply = <&ab8500_ldo_aux1_reg>; + vms-supply = <&db8500_vsmps2_reg>; + }; + }; +
This appears to be missing a binding document. I couldn't see one anywhere in this series, or in mainline already).
As far as I can see, the compatible string should be "st,lps001wp".
Please produce a binding document.
Is there any publicly available documentation on the chip?
Thanks,
Mark.
Quoted 12 lines
arch/arm/boot/dts/ste-snowball.dts +0
-0uart at 80120000 { status = "okay"; };Signature · 7 lines
1.8.1.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 02/11] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT
Quoted 33 lines · Mark Rutland
Hi Lee,
Quoted 16 lines · Lee Jones
After applying this node the LPS001WP sensor chip should probe successfully once the driver support has also been applied.
Signed-off-by Lee Jones <[email protected]>--- arch/arm/boot/dts/ste-snowball.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/ste-snowball.dts +0
-0@@ -153,6 +153,16 @@ status = "okay"; };arch/arm/boot/dts/ste-snowball.dts line 165
Quoted 10 lines
arch/arm/boot/dts/ste-snowball.dts +10
-0+ i2c at 80128000 { + lps001wp at 5c { + compatible = "lps001wp"; + reg = <0x5c>; + + vdd-supply = <&ab8500_ldo_aux1_reg>; + vms-supply = <&db8500_vsmps2_reg>; + }; + }; +This appears to be missing a binding document. I couldn't see one anywhere in this series, or in mainline already).
Quoted 1 line
As far as I can see, the compatible string should be "st,lps001wp".
The I2C subsystem doesn't actually care about vendor prefixes. They are all stripped before use in all cases. However, I'm happy to provide one if for no other reason than to stick to convention.
Quoted 1 line
Please produce a binding document.
Again, I'm happy to provide a boilerplate document, but there's nothing special happening here.
Quoted 1 line
Is there any publicly available documentation on the chip?
If you Google the device name, it will be the first hit.
Quoted 3 lines
arch/arm/boot/dts/ste-snowball.dts line 168
Quoted 3 lines
arch/arm/boot/dts/ste-snowball.dts +0
-0uart at 80120000 { status = "okay"; };
Kind regards,
Lee
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 02/11] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT
Quoted 35 lines · Lee Jones
Quoted 33 lines · Mark Rutland
Hi Lee,
Quoted 16 lines · Lee Jones
After applying this node the LPS001WP sensor chip should probe successfully once the driver support has also been applied.
Signed-off-by Lee Jones <[email protected]>--- arch/arm/boot/dts/ste-snowball.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/ste-snowball.dts +0
-0@@ -153,6 +153,16 @@ status = "okay"; };arch/arm/boot/dts/ste-snowball.dts line 165
Quoted 10 lines
arch/arm/boot/dts/ste-snowball.dts +10
-0+ i2c at 80128000 { + lps001wp at 5c { + compatible = "lps001wp"; + reg = <0x5c>; + + vdd-supply = <&ab8500_ldo_aux1_reg>; + vms-supply = <&db8500_vsmps2_reg>; + }; + }; +This appears to be missing a binding document. I couldn't see one anywhere in this series, or in mainline already).
Quoted 5 lines
Quoted 1 line
As far as I can see, the compatible string should be "st,lps001wp".
The I2C subsystem doesn't actually care about vendor prefixes. They are all stripped before use in all cases. However, I'm happy to provide one if for no other reason than to stick to convention.
I'd prefer if we did document this. Just because Linux doesn't care about this at the moment doesn't mean we (or another OS) might want to handle it differently in future. It also gives us a semblance of consistency.
Quoted 5 lines
Quoted 2 lines
Please produce a binding document.
Again, I'm happy to provide a boilerplate document, but there's nothing special happening here.
That's not true. The names of the regulators should be documented. One seems to be optional for some reason.
Quoted 4 lines
Quoted 2 lines
Is there any publicly available documentation on the chip?
If you Google the device name, it will be the first hit.
Ok, I'll take a look.
Quoted 7 lines
Quoted 4 lines
arch/arm/boot/dts/ste-snowball.dts line 168
Quoted 4 lines
arch/arm/boot/dts/ste-snowball.dts +0
-0uart at 80120000 { status = "okay"; };Kind regards,
Lee
Cheers,
Mark.
Re: [PATCH 02/11] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT
In reply to Mark RutlandQuoted 33 lines · Mark Rutland
Hi Lee,
Quoted 16 lines · Lee Jones
After applying this node the LPS001WP sensor chip should probe successfully once the driver support has also been applied.
Signed-off-by Lee Jones <[email protected]>--- arch/arm/boot/dts/ste-snowball.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/ste-snowball.dts +0
-0@@ -153,6 +153,16 @@ status = "okay"; };arch/arm/boot/dts/ste-snowball.dts line 165
Quoted 10 lines
arch/arm/boot/dts/ste-snowball.dts +10
-0+ i2c at 80128000 { + lps001wp at 5c { + compatible = "lps001wp"; + reg = <0x5c>; + + vdd-supply = <&ab8500_ldo_aux1_reg>; + vms-supply = <&db8500_vsmps2_reg>; + }; + }; +This appears to be missing a binding document. I couldn't see one anywhere in this series, or in mainline already).
Quoted 3 lines
As far as I can see, the compatible string should be "st,lps001wp".
Please produce a binding document.
Patch sent, most of you are on CC.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v2 2/11 ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT
In reply to Lee JonesAfter applying this node the LPS001WP sensor chip should probe successfully once the driver support has also been applied.
arch/arm/boot/dts/ste-snowball.dts +10 -0
@@ -153,6 +153,16 @@ status = "okay"; }; + i2c at 80128000 { + lps001wp at 5c { + compatible = "st,lps001wp"; + reg = <0x5c>; + + vdd-supply = <&ab8500_ldo_aux1_reg>; + vms-supply = <&db8500_vsmps2_reg>; + }; + }; + uart at 80120000 { status = "okay"; };
PATCH 3/11 ARM: ux500: CONFIG: Enable ST's IIO Pressure Sensors by default
In reply to Lee Jones--- arch/arm/configs/u8500_defconfig | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/configs/u8500_defconfig +4 -0
@@ -37,6 +37,10 @@ CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_SIZE=65536 CONFIG_SENSORS_BH1780=y +CONFIG_IIO=y +CONFIG_IIO_ST_PRESS=y +CONFIG_IIO_ST_PRESS_I2C=y +CONFIG_IIO_ST_SENSORS_I2C=y CONFIG_NETDEVICES=y CONFIG_SMSC911X=y CONFIG_SMSC_PHY=y
Signature · 1 line
1.8.1.2
PATCH 4/11 iio: pressure-i2c: st: Simplify error checking in probe()
In reply to Lee JonesStrip out all the unnecessary gotos and check for NULL returns in the usual manner.
--- drivers/iio/pressure/st_pressure_i2c.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-)
drivers/iio/pressure/st_pressure_i2c.c +6 -11
@@ -26,10 +26,8 @@ static int st_press_i2c_probe(struct i2c_client *client,int err; indio_dev =iio_device_alloc (sizeof (*pdata)); -if (indio_dev ==NULL ) { - err = -ENOMEM ; - goto iio_device_alloc_error; - } +if (!indio_dev) +return -ENOMEM ; pdata =iio_priv (indio_dev); pdata->dev = &client->dev;
@@ -37,15 +35,12 @@ static int st_press_i2c_probe(struct i2c_client *client,st_sensors_i2c_configure (indio_dev, client, pdata); err =st_press_common_probe (indio_dev); -if (err <0 ) - goto st_press_common_probe_error; +if (err <0 ) { +iio_device_free (indio_dev); +return err; + }return 0 ; - -st_press_common_probe_error: -iio_device_free (indio_dev); -iio_device_alloc_error: -return err; }static int st_press_i2c_remove (struct i2c_client *client)
Signature · 1 line
1.8.1.2
Jonathan Cameron
maintainerRe: [PATCH 04/11] iio: pressure-i2c: st: Simplify error checking in probe()
Hi Lee. This won't apply as this driver has already been cleaned up using devm_iio_device_alloc.
Guessing you are basing on an old tree?
Always use at least staging-next for IIO patches.
I think this one will hit mainline in next few days.
Jonathan
Quoted 48 lines · Lee Jones
Strip out all the unnecessary gotos and check for NULL returns in the usual manner.
Signed-off-by Lee Jones <[email protected]>---
drivers/iio/pressure/st_pressure_i2c.c| 17 ++++++-----------1 file changed, 6 insertions(+), 11 deletions(-)drivers/iio/pressure/st_pressure_i2c.c +2
-4@@ -26,10 +26,8 @@ static int st_press_i2c_probe(struct i2c_client *client, int err; indio_dev =iio_device_alloc (sizeof (*pdata)); -if (indio_dev ==NULL ) { - err = -ENOMEM ; - goto iio_device_alloc_error; - } +if (!indio_dev) +return -ENOMEM ; pdata =iio_priv (indio_dev);pdata->dev = &client->dev;drivers/iio/pressure/st_pressure_i2c.c +4
-7@@ -37,15 +35,12 @@ static int st_press_i2c_probe(struct i2c_client *client,st_sensors_i2c_configure (indio_dev, client, pdata); err =st_press_common_probe (indio_dev); -if (err <0 ) - goto st_press_common_probe_error; +if (err <0 ) { +iio_device_free (indio_dev); +return err; + }return 0 ; - -st_press_common_probe_error: -iio_device_free (indio_dev); -iio_device_alloc_error: -return err; }static int
st_press_i2c_remove(struct i2c_client *client)
Signature · 1 line
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
Re: [PATCH 04/11] iio: pressure-i2c: st: Simplify error checking in probe()
Quoted 5 lines
Hi Lee. This won't apply as this driver has already been cleaned up using
devm_iio_device_alloc.Guessing you are basing on an old tree?
Always use at least staging-next for IIO patches.
Sure, I'll rebase and resubmit the set once all the other creases have been ironed out.
Quoted 1 line
I think this one will hit mainline in next few days.
Okay, great.
Quoted 50 lines
Quoted 48 lines · Lee Jones
Strip out all the unnecessary gotos and check for NULL returns in the usual manner.
Signed-off-by Lee Jones <[email protected]>---
drivers/iio/pressure/st_pressure_i2c.c| 17 ++++++-----------1 file changed, 6 insertions(+), 11 deletions(-)drivers/iio/pressure/st_pressure_i2c.c +2
-4@@ -26,10 +26,8 @@ static int st_press_i2c_probe(struct i2c_client *client, int err; indio_dev =iio_device_alloc (sizeof (*pdata)); -if (indio_dev ==NULL ) { - err = -ENOMEM ; - goto iio_device_alloc_error; - } +if (!indio_dev) +return -ENOMEM ; pdata =iio_priv (indio_dev);pdata->dev = &client->dev;drivers/iio/pressure/st_pressure_i2c.c +4
-7@@ -37,15 +35,12 @@ static int st_press_i2c_probe(struct i2c_client *client,st_sensors_i2c_configure (indio_dev, client, pdata); err =st_press_common_probe (indio_dev); -if (err <0 ) - goto st_press_common_probe_error; +if (err <0 ) { +iio_device_free (indio_dev); +return err; + }return 0 ; - -st_press_common_probe_error: -iio_device_free (indio_dev); -iio_device_alloc_error: -return err; }static int
st_press_i2c_remove(struct i2c_client *client)
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 5/11 iio: pressure-core: st: Describe LPS331AP defines by name
In reply to Lee JonesThey're currently named *_1_*, for 'Sensor 1', but the code will be much more readable if we use the naming convention *_LPS331AP_* instead.
--- drivers/iio/pressure/st_pressure_core.c | 90 ++++++++++++++++----------------- 1 file changed, 44 insertions(+), 46 deletions(-)
drivers/iio/pressure/st_pressure_core.c +44 -46
@@ -31,92 +31,90 @@#define ST_PRESS_MBAR_TO_KPASCAL (x) (x * 10)#define ST_PRESS_NUMBER_DATA_CHANNELS 1 -/* DEFAULT VALUE FOR SENSORS */ -#define ST_PRESS_DEFAULT_OUT_XL_ADDR 0x28 -#define ST_TEMP_DEFAULT_OUT_L_ADDR 0x2b -/* FULLSCALE */ #define ST_PRESS_FS_AVL_1260MB 1260 -/* CUSTOM VALUES FOR SENSOR 1 */ -#define ST_PRESS_1_WAI_EXP 0xbb -#define ST_PRESS_1_ODR_ADDR 0x20 -#define ST_PRESS_1_ODR_MASK 0x70 -#define ST_PRESS_1_ODR_AVL_1HZ_VAL 0x01 -#define ST_PRESS_1_ODR_AVL_7HZ_VAL 0x05 -#define ST_PRESS_1_ODR_AVL_13HZ_VAL 0x06 -#define ST_PRESS_1_ODR_AVL_25HZ_VAL 0x07 -#define ST_PRESS_1_PW_ADDR 0x20 -#define ST_PRESS_1_PW_MASK 0x80 -#define ST_PRESS_1_FS_ADDR 0x23 -#define ST_PRESS_1_FS_MASK 0x30 -#define ST_PRESS_1_FS_AVL_1260_VAL 0x00 -#define ST_PRESS_1_FS_AVL_1260_GAIN ST_PRESS_MBAR_TO_KPASCAL(244141) -#define ST_PRESS_1_FS_AVL_TEMP_GAIN 2083000 -#define ST_PRESS_1_BDU_ADDR 0x20 -#define ST_PRESS_1_BDU_MASK 0x04 -#define ST_PRESS_1_DRDY_IRQ_ADDR 0x22 -#define ST_PRESS_1_DRDY_IRQ_MASK 0x04 -#define ST_PRESS_1_MULTIREAD_BIT true -#define ST_PRESS_1_TEMP_OFFSET 42500 +/* CUSTOM VALUES FOR LPS331AP SENSOR */ +#define ST_PRESS_LPS331AP_WAI_EXP 0xbb +#define ST_PRESS_LPS331AP_ODR_ADDR 0x20 +#define ST_PRESS_LPS331AP_ODR_MASK 0x70 +#define ST_PRESS_LPS331AP_ODR_AVL_1HZ_VAL 0x01 +#define ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL 0x05 +#define ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL 0x06 +#define ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL 0x07 +#define ST_PRESS_LPS331AP_PW_ADDR 0x20 +#define ST_PRESS_LPS331AP_PW_MASK 0x80 +#define ST_PRESS_LPS331AP_FS_ADDR 0x23 +#define ST_PRESS_LPS331AP_FS_MASK 0x30 +#define ST_PRESS_LPS331AP_FS_AVL_1260_VAL 0x00 +#define ST_PRESS_LPS331AP_FS_AVL_1260_GAIN ST_PRESS_MBAR_TO_KPASCAL(244141) +#define ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN 2083000 +#define ST_PRESS_LPS331AP_BDU_ADDR 0x20 +#define ST_PRESS_LPS331AP_BDU_MASK 0x04 +#define ST_PRESS_LPS331AP_DRDY_IRQ_ADDR 0x22 +#define ST_PRESS_LPS331AP_DRDY_IRQ_MASK 0x04 +#define ST_PRESS_LPS331AP_MULTIREAD_BIT true +#define ST_PRESS_LPS331AP_TEMP_OFFSET 42500 +#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28 +#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2bstatic const struct iio_chan_spec st_press_channels[] = {ST_SENSORS_LSM_CHANNELS (IIO_PRESSURE ,BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ),ST_SENSORS_SCAN_X ,0 ,IIO_NO_MOD ,'u' ,IIO_LE ,24 ,24 , -ST_PRESS_DEFAULT_OUT_XL_ADDR ), +ST_PRESS_LPS331AP_OUT_XL_ADDR ),ST_SENSORS_LSM_CHANNELS (IIO_TEMP ,BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ) |BIT (IIO_CHAN_INFO_OFFSET ),-1 ,0 ,IIO_NO_MOD ,'s' ,IIO_LE ,16 ,16 , -ST_TEMP_DEFAULT_OUT_L_ADDR ), +ST_TEMP_LPS331AP_OUT_L_ADDR ),IIO_CHAN_SOFT_TIMESTAMP (1 ) };static const struct st_sensors st_press_sensors[] = { { - .wai =ST_PRESS_1_WAI_EXP , + .wai =ST_PRESS_LPS331AP_WAI_EXP , .sensors_supported = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, .ch = (struct iio_chan_spec *)st_press_channels, .odr = { - .addr =ST_PRESS_1_ODR_ADDR , - .mask =ST_PRESS_1_ODR_MASK , + .addr =ST_PRESS_LPS331AP_ODR_ADDR , + .mask =ST_PRESS_LPS331AP_ODR_MASK , .odr_avl = { - {1 ,ST_PRESS_1_ODR_AVL_1HZ_VAL , }, - {7 ,ST_PRESS_1_ODR_AVL_7HZ_VAL , }, - {13 ,ST_PRESS_1_ODR_AVL_13HZ_VAL , }, - {25 ,ST_PRESS_1_ODR_AVL_25HZ_VAL , }, + {1 ,ST_PRESS_LPS331AP_ODR_AVL_1HZ_VAL , }, + {7 ,ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL , }, + {13 ,ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL , }, + {25 ,ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL , }, }, }, .pw = { - .addr =ST_PRESS_1_PW_ADDR , - .mask =ST_PRESS_1_PW_MASK , + .addr =ST_PRESS_LPS331AP_PW_ADDR , + .mask =ST_PRESS_LPS331AP_PW_MASK , .value_on =ST_SENSORS_DEFAULT_POWER_ON_VALUE , .value_off =ST_SENSORS_DEFAULT_POWER_OFF_VALUE , }, .fs = { - .addr =ST_PRESS_1_FS_ADDR , - .mask =ST_PRESS_1_FS_MASK , + .addr =ST_PRESS_LPS331AP_FS_ADDR , + .mask =ST_PRESS_LPS331AP_FS_MASK , .fs_avl = { [0 ] = { .num =ST_PRESS_FS_AVL_1260MB , - .value =ST_PRESS_1_FS_AVL_1260_VAL , - .gain =ST_PRESS_1_FS_AVL_1260_GAIN , - .gain2 =ST_PRESS_1_FS_AVL_TEMP_GAIN , + .value =ST_PRESS_LPS331AP_FS_AVL_1260_VAL , + .gain =ST_PRESS_LPS331AP_FS_AVL_1260_GAIN , + .gain2 =ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN , }, }, }, .bdu = { - .addr =ST_PRESS_1_BDU_ADDR , - .mask =ST_PRESS_1_BDU_MASK , + .addr =ST_PRESS_LPS331AP_BDU_ADDR , + .mask =ST_PRESS_LPS331AP_BDU_MASK , }, .drdy_irq = { - .addr =ST_PRESS_1_DRDY_IRQ_ADDR , - .mask =ST_PRESS_1_DRDY_IRQ_MASK , + .addr =ST_PRESS_LPS331AP_DRDY_IRQ_ADDR , + .mask =ST_PRESS_LPS331AP_DRDY_IRQ_MASK , }, - .multi_read_bit =ST_PRESS_1_MULTIREAD_BIT , + .multi_read_bit =ST_PRESS_LPS331AP_MULTIREAD_BIT , .bootime =2 , }, };
Signature · 1 line
1.8.1.2
Re: [PATCH 05/11] iio: pressure-core: st: Describe LPS331AP defines by name
Hi Lee,
Quoted 2 lines
They're currently named *_1_*, for 'Sensor 1', but the code will be much more readable if we use the naming convention *_LPS331AP_* instead.
You are right, but the reason is to maintain the same structure of the other sensors drivers (like accel, gyro and magn). Often some sensors can use the same data and using 1,2,... I think it's more general.
Denis
Quoted 146 lines
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 90 ++++++++++++++++----------------- 1 file changed, 44 insertions(+), 46 deletions(-)drivers/iio/pressure/st_pressure_core.c +44
-46@@ -31,92 +31,90 @@#define ST_PRESS_MBAR_TO_KPASCAL (x) (x * 10)#define ST_PRESS_NUMBER_DATA_CHANNELS 1 -/* DEFAULT VALUE FOR SENSORS */ -#define ST_PRESS_DEFAULT_OUT_XL_ADDR 0x28 -#define ST_TEMP_DEFAULT_OUT_L_ADDR 0x2b -/* FULLSCALE */ #define ST_PRESS_FS_AVL_1260MB 1260 -/* CUSTOM VALUES FOR SENSOR 1 */ -#define ST_PRESS_1_WAI_EXP 0xbb -#define ST_PRESS_1_ODR_ADDR 0x20 -#define ST_PRESS_1_ODR_MASK 0x70 -#define ST_PRESS_1_ODR_AVL_1HZ_VAL 0x01 -#define ST_PRESS_1_ODR_AVL_7HZ_VAL 0x05 -#define ST_PRESS_1_ODR_AVL_13HZ_VAL 0x06 -#define ST_PRESS_1_ODR_AVL_25HZ_VAL 0x07 -#define ST_PRESS_1_PW_ADDR 0x20 -#define ST_PRESS_1_PW_MASK 0x80 -#define ST_PRESS_1_FS_ADDR 0x23 -#define ST_PRESS_1_FS_MASK 0x30 -#define ST_PRESS_1_FS_AVL_1260_VAL 0x00 -#define ST_PRESS_1_FS_AVL_1260_GAIN ST_PRESS_MBAR_TO_KPASCAL(244141) -#define ST_PRESS_1_FS_AVL_TEMP_GAIN 2083000 -#define ST_PRESS_1_BDU_ADDR 0x20 -#define ST_PRESS_1_BDU_MASK 0x04 -#define ST_PRESS_1_DRDY_IRQ_ADDR 0x22 -#define ST_PRESS_1_DRDY_IRQ_MASK 0x04 -#define ST_PRESS_1_MULTIREAD_BIT true -#define ST_PRESS_1_TEMP_OFFSET 42500 +/* CUSTOM VALUES FOR LPS331AP SENSOR */ +#define ST_PRESS_LPS331AP_WAI_EXP 0xbb +#define ST_PRESS_LPS331AP_ODR_ADDR 0x20 +#define ST_PRESS_LPS331AP_ODR_MASK 0x70 +#define ST_PRESS_LPS331AP_ODR_AVL_1HZ_VAL 0x01 +#define ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL 0x05 +#define ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL 0x06 +#define ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL 0x07 +#define ST_PRESS_LPS331AP_PW_ADDR 0x20 +#define ST_PRESS_LPS331AP_PW_MASK 0x80 +#define ST_PRESS_LPS331AP_FS_ADDR 0x23 +#define ST_PRESS_LPS331AP_FS_MASK 0x30 +#define ST_PRESS_LPS331AP_FS_AVL_1260_VAL 0x00 +#define ST_PRESS_LPS331AP_FS_AVL_1260_GAIN ST_PRESS_MBAR_TO_KPASCAL(244141) +#define ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN 2083000 +#define ST_PRESS_LPS331AP_BDU_ADDR 0x20 +#define ST_PRESS_LPS331AP_BDU_MASK 0x04 +#define ST_PRESS_LPS331AP_DRDY_IRQ_ADDR 0x22 +#define ST_PRESS_LPS331AP_DRDY_IRQ_MASK 0x04 +#define ST_PRESS_LPS331AP_MULTIREAD_BIT true +#define ST_PRESS_LPS331AP_TEMP_OFFSET 42500 +#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28 +#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2bstatic const struct iio_chan_spec st_press_channels[] = {ST_SENSORS_LSM_CHANNELS (IIO_PRESSURE ,BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ),ST_SENSORS_SCAN_X ,0 ,IIO_NO_MOD ,'u' ,IIO_LE ,24 ,24 , -ST_PRESS_DEFAULT_OUT_XL_ADDR ), +ST_PRESS_LPS331AP_OUT_XL_ADDR ),ST_SENSORS_LSM_CHANNELS (IIO_TEMP ,BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ) |BIT (IIO_CHAN_INFO_OFFSET ),-1 ,0 ,IIO_NO_MOD ,'s' ,IIO_LE ,16 ,16 , -ST_TEMP_DEFAULT_OUT_L_ADDR ), +ST_TEMP_LPS331AP_OUT_L_ADDR ),IIO_CHAN_SOFT_TIMESTAMP (1 ) };static const struct st_sensors st_press_sensors[] = { { - .wai =ST_PRESS_1_WAI_EXP , + .wai =ST_PRESS_LPS331AP_WAI_EXP , .sensors_supported = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, .ch = (struct iio_chan_spec *)st_press_channels, .odr = { - .addr =ST_PRESS_1_ODR_ADDR , - .mask =ST_PRESS_1_ODR_MASK , + .addr =ST_PRESS_LPS331AP_ODR_ADDR , + .mask =ST_PRESS_LPS331AP_ODR_MASK , .odr_avl = { - {1 ,ST_PRESS_1_ODR_AVL_1HZ_VAL , }, - {7 ,ST_PRESS_1_ODR_AVL_7HZ_VAL , }, - {13 ,ST_PRESS_1_ODR_AVL_13HZ_VAL , }, - {25 ,ST_PRESS_1_ODR_AVL_25HZ_VAL , }, + {1 ,ST_PRESS_LPS331AP_ODR_AVL_1HZ_VAL , }, + {7 ,ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL , }, + {13 ,ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL , }, + {25 ,ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL , }, }, }, .pw = { - .addr =ST_PRESS_1_PW_ADDR , - .mask =ST_PRESS_1_PW_MASK , + .addr =ST_PRESS_LPS331AP_PW_ADDR , + .mask =ST_PRESS_LPS331AP_PW_MASK , .value_on =ST_SENSORS_DEFAULT_POWER_ON_VALUE , .value_off =ST_SENSORS_DEFAULT_POWER_OFF_VALUE , }, .fs = { - .addr =ST_PRESS_1_FS_ADDR , - .mask =ST_PRESS_1_FS_MASK , + .addr =ST_PRESS_LPS331AP_FS_ADDR , + .mask =ST_PRESS_LPS331AP_FS_MASK , .fs_avl = { [0 ] = { .num =ST_PRESS_FS_AVL_1260MB , - .value =ST_PRESS_1_FS_AVL_1260_VAL , - .gain =ST_PRESS_1_FS_AVL_1260_GAIN , - .gain2 =ST_PRESS_1_FS_AVL_TEMP_GAIN , + .value =ST_PRESS_LPS331AP_FS_AVL_1260_VAL , + .gain =ST_PRESS_LPS331AP_FS_AVL_1260_GAIN , + .gain2 =ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN , }, }, }, .bdu = { - .addr =ST_PRESS_1_BDU_ADDR , - .mask =ST_PRESS_1_BDU_MASK , + .addr =ST_PRESS_LPS331AP_BDU_ADDR , + .mask =ST_PRESS_LPS331AP_BDU_MASK , }, .drdy_irq = { - .addr =ST_PRESS_1_DRDY_IRQ_ADDR , - .mask =ST_PRESS_1_DRDY_IRQ_MASK , + .addr =ST_PRESS_LPS331AP_DRDY_IRQ_ADDR , + .mask =ST_PRESS_LPS331AP_DRDY_IRQ_MASK , }, - .multi_read_bit =ST_PRESS_1_MULTIREAD_BIT , + .multi_read_bit =ST_PRESS_LPS331AP_MULTIREAD_BIT , .bootime =2 , }, };
Re: [PATCH 05/11] iio: pressure-core: st: Describe LPS331AP defines by name
Quoted 5 lines
Quoted 2 lines
They're currently named *_1_*, for 'Sensor 1', but the code will be much more readable if we use the naming convention *_LPS331AP_* instead.
You are right, but the reason is to maintain the same structure of the other sensors drivers (like accel, gyro and magn). Often some sensors can use the same data and using 1,2,... I think it's more general.
I've just coded this up for the pressure sensor [1] and in my opinion it looks pretty ugly. We save 5 lines in this usecase, but we're separating out some of the register addresses from the masks etc.
Besides some code space #defines don't actually cost anything, so unless the register set is almost identical I'd suggest putting them in a header file out the way and separating them out like in the original patch. I personally think it makes things so much clearer for the reader.
I haven't looked at the other sensors yet, so perhaps we need to evaluate this on a case by case basis, but certainly for this driver, as we only support two sensors currently and for the sake of 5 lines I think it's better to have them clearly defined per-sensor.
What do you think?
[1]:
/* GROUP VALUES SENSOR */
#define ST_PRESS_1_ODR_ADDR 0x20
#define ST_PRESS_1_ODR_AVL_1HZ_VAL 0x01
#define ST_PRESS_1_PW_ADDR 0x20
#define ST_PRESS_1_BDU_ADDR 0x20
#define ST_PRESS_1_MULTIREAD_BIT true
/* CUSTOM VALUES FOR LPS331AP SENSOR */
#define ST_PRESS_LPS331AP_WAI_EXP 0xbb
#define ST_PRESS_LPS331AP_ODR_MASK 0x70
#define ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL 0x05
#define ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL 0x06
#define ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL 0x07
#define ST_PRESS_LPS331AP_PW_MASK 0x80
#define ST_PRESS_LPS331AP_FS_ADDR 0x23
#define ST_PRESS_LPS331AP_FS_MASK 0x30
#define ST_PRESS_LPS331AP_FS_AVL_1260_VAL 0x00
#define ST_PRESS_LPS331AP_FS_AVL_1260_GAIN ST_PRESS_MBAR_TO_KPASCAL(244141)
#define ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN 2083000
#define ST_PRESS_LPS331AP_BDU_MASK 0x04
#define ST_PRESS_LPS331AP_DRDY_IRQ_ADDR 0x22
#define ST_PRESS_LPS331AP_DRDY_IRQ_MASK 0x04
#define ST_PRESS_LPS331AP_TEMP_OFFSET 42500
#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28
#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2b
/* CUSTOM VALUES FOR LPS001WP SENSOR */
#define ST_PRESS_LPS001WP_WAI_EXP 0xba
#define ST_PRESS_LPS001WP_ODR_MASK 0x30
#define ST_PRESS_LPS001WP_ODR_AVL_7HZ_VAL 0x02
#define ST_PRESS_LPS001WP_ODR_AVL_13HZ_VAL 0x03
#define ST_PRESS_LPS001WP_PW_MASK 0x40
#define ST_PRESS_LPS001WP_BDU_MASK 0x04
#define ST_PRESS_LPS001WP_OUT_L_ADDR 0x28
#define ST_TEMP_LPS001WP_OUT_L_ADDR 0x2a
static const struct iio_chan_spec st_press_lsp331ap_channels[] = {
{
.type = IIO_PRESSURE,
.channel2 = IIO_NO_MOD,
.address = ST_PRESS_LPS331AP_OUT_XL_ADDR,
.scan_index = ST_SENSORS_SCAN_X,
.scan_type = {
.sign = 'u',
.realbits = 24,
.storagebits = 24,
.endianness = IIO_LE,
},
.info_mask_separate =
BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE),
.modified = 0,
},
{
.type = IIO_TEMP,
.channel2 = IIO_NO_MOD,
.address = ST_TEMP_LPS331AP_OUT_L_ADDR,
.scan_index = -1,
.scan_type = {
.sign = 'u',
.realbits = 16,
.storagebits = 16,
.endianness = IIO_LE,
},
.info_mask_separate =
BIT(IIO_CHAN_INFO_RAW) |
BIT(IIO_CHAN_INFO_SCALE) |
BIT(IIO_CHAN_INFO_OFFSET),
.modified = 0,
},
IIO_CHAN_SOFT_TIMESTAMP(1)
};static const struct iio_chan_spec st_press_lps001wp_channels[] = {
{
.type = IIO_PRESSURE,
.channel2 = IIO_NO_MOD,
.address = ST_PRESS_LPS001WP_OUT_L_ADDR,
.scan_index = ST_SENSORS_SCAN_X,
.scan_type = {
.sign = 'u',
.realbits = 16,
.storagebits = 16,
.endianness = IIO_LE,
},
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
.modified = 0,
},
{
.type = IIO_TEMP,
.channel2 = IIO_NO_MOD,
.address = ST_TEMP_LPS001WP_OUT_L_ADDR,
.scan_index = -1,
.scan_type = {
.sign = 'u',
.realbits = 16,
.storagebits = 16,
.endianness = IIO_LE,
},
.info_mask_separate =
BIT(IIO_CHAN_INFO_RAW) |
BIT(IIO_CHAN_INFO_OFFSET),
.modified = 0,
},
IIO_CHAN_SOFT_TIMESTAMP(1)
};static const struct st_sensors st_press_sensors[] = {
{
.wai = ST_PRESS_LPS331AP_WAI_EXP,
.sensors_supported = {
[0] = LPS331AP_PRESS_DEV_NAME,
},
.ch = (struct iio_chan_spec *)st_press_lsp331ap_channels,
.num_ch = ARRAY_SIZE(st_press_lsp331ap_channels),
.odr = {
.addr = ST_PRESS_1_ODR_ADDR,
.mask = ST_PRESS_LPS331AP_ODR_MASK,
.odr_avl = {
{ 1, ST_PRESS_1_ODR_AVL_1HZ_VAL, },
{ 7, ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL, },
{ 13, ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL, },
{ 25, ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL, },
},
},
.pw = {
.addr = ST_PRESS_1_PW_ADDR,
.mask = ST_PRESS_LPS331AP_PW_MASK,
.value_on = ST_SENSORS_DEFAULT_POWER_ON_VALUE,
.value_off = ST_SENSORS_DEFAULT_POWER_OFF_VALUE,
},
.fs = {
.addr = ST_PRESS_LPS331AP_FS_ADDR,
.mask = ST_PRESS_LPS331AP_FS_MASK,
.fs_avl = {
[0] = {
.num = ST_PRESS_FS_AVL_1260MB,
.value = ST_PRESS_LPS331AP_FS_AVL_1260_VAL,
.gain = ST_PRESS_LPS331AP_FS_AVL_1260_GAIN,
.gain2 = ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN,
},
},
},
.bdu = {
.addr = ST_PRESS_1_BDU_ADDR,
.mask = ST_PRESS_LPS331AP_BDU_MASK,
},
.drdy_irq = {
.addr = ST_PRESS_LPS331AP_DRDY_IRQ_ADDR,
.mask = ST_PRESS_LPS331AP_DRDY_IRQ_MASK,
},
.multi_read_bit = ST_PRESS_1_MULTIREAD_BIT,
.bootime = 2,
},
{
.wai = ST_PRESS_LPS001WP_WAI_EXP,
.sensors_supported = {
[0] = LPS001WP_PRESS_DEV_NAME,
},
.ch = (struct iio_chan_spec *)st_press_lps001wp_channels,
.num_ch = ARRAY_SIZE(st_press_lps001wp_channels),
.odr = {
.addr = ST_PRESS_1_ODR_ADDR,
.mask = ST_PRESS_LPS001WP_ODR_MASK,
.odr_avl = {
{ 1, ST_PRESS_1_ODR_AVL_1HZ_VAL, },
{ 7, ST_PRESS_LPS001WP_ODR_AVL_7HZ_VAL, },
{ 13, ST_PRESS_LPS001WP_ODR_AVL_13HZ_VAL, },
},
},
.pw = {
.addr = ST_PRESS_1_PW_ADDR,
.mask = ST_PRESS_LPS001WP_PW_MASK,
.value_on = ST_SENSORS_DEFAULT_POWER_ON_VALUE,
.value_off = ST_SENSORS_DEFAULT_POWER_OFF_VALUE,
},
.fs = {
.addr = 0,
},
.bdu = {
.addr = ST_PRESS_1_BDU_ADDR,
.mask = ST_PRESS_LPS001WP_BDU_MASK,
},
.drdy_irq = {
.addr = 0,
},
.multi_read_bit = ST_PRESS_1_MULTIREAD_BIT,
.bootime = 2,
},
};Quoted 126 lines
Quoted 126 lines
drivers/iio/pressure/st_pressure_core.c +44
-42-/* CUSTOM VALUES FOR SENSOR 1 */ -#define ST_PRESS_1_WAI_EXP 0xbb -#define ST_PRESS_1_ODR_ADDR 0x20 -#define ST_PRESS_1_ODR_MASK 0x70 -#define ST_PRESS_1_ODR_AVL_1HZ_VAL 0x01 -#define ST_PRESS_1_ODR_AVL_7HZ_VAL 0x05 -#define ST_PRESS_1_ODR_AVL_13HZ_VAL 0x06 -#define ST_PRESS_1_ODR_AVL_25HZ_VAL 0x07 -#define ST_PRESS_1_PW_ADDR 0x20 -#define ST_PRESS_1_PW_MASK 0x80 -#define ST_PRESS_1_FS_ADDR 0x23 -#define ST_PRESS_1_FS_MASK 0x30 -#define ST_PRESS_1_FS_AVL_1260_VAL 0x00 -#define ST_PRESS_1_FS_AVL_1260_GAIN ST_PRESS_MBAR_TO_KPASCAL(244141) -#define ST_PRESS_1_FS_AVL_TEMP_GAIN 2083000 -#define ST_PRESS_1_BDU_ADDR 0x20 -#define ST_PRESS_1_BDU_MASK 0x04 -#define ST_PRESS_1_DRDY_IRQ_ADDR 0x22 -#define ST_PRESS_1_DRDY_IRQ_MASK 0x04 -#define ST_PRESS_1_MULTIREAD_BIT true -#define ST_PRESS_1_TEMP_OFFSET 42500 +/* CUSTOM VALUES FOR LPS331AP SENSOR */ +#define ST_PRESS_LPS331AP_WAI_EXP 0xbb +#define ST_PRESS_LPS331AP_ODR_ADDR 0x20 +#define ST_PRESS_LPS331AP_ODR_MASK 0x70 +#define ST_PRESS_LPS331AP_ODR_AVL_1HZ_VAL 0x01 +#define ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL 0x05 +#define ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL 0x06 +#define ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL 0x07 +#define ST_PRESS_LPS331AP_PW_ADDR 0x20 +#define ST_PRESS_LPS331AP_PW_MASK 0x80 +#define ST_PRESS_LPS331AP_FS_ADDR 0x23 +#define ST_PRESS_LPS331AP_FS_MASK 0x30 +#define ST_PRESS_LPS331AP_FS_AVL_1260_VAL 0x00 +#define ST_PRESS_LPS331AP_FS_AVL_1260_GAIN ST_PRESS_MBAR_TO_KPASCAL(244141) +#define ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN 2083000 +#define ST_PRESS_LPS331AP_BDU_ADDR 0x20 +#define ST_PRESS_LPS331AP_BDU_MASK 0x04 +#define ST_PRESS_LPS331AP_DRDY_IRQ_ADDR 0x22 +#define ST_PRESS_LPS331AP_DRDY_IRQ_MASK 0x04 +#define ST_PRESS_LPS331AP_MULTIREAD_BIT true +#define ST_PRESS_LPS331AP_TEMP_OFFSET 42500 +#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28 +#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2bstatic const struct iio_chan_spec st_press_channels[] = {ST_SENSORS_LSM_CHANNELS (IIO_PRESSURE ,BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ),ST_SENSORS_SCAN_X ,0 ,IIO_NO_MOD ,'u' ,IIO_LE ,24 ,24 , -ST_PRESS_DEFAULT_OUT_XL_ADDR ), +ST_PRESS_LPS331AP_OUT_XL_ADDR ),ST_SENSORS_LSM_CHANNELS (IIO_TEMP ,BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ) |BIT (IIO_CHAN_INFO_OFFSET ),-1 ,0 ,IIO_NO_MOD ,'s' ,IIO_LE ,16 ,16 , -ST_TEMP_DEFAULT_OUT_L_ADDR ), +ST_TEMP_LPS331AP_OUT_L_ADDR ),IIO_CHAN_SOFT_TIMESTAMP (1 ) };static const struct st_sensors st_press_sensors[] = { { - .wai =ST_PRESS_1_WAI_EXP , + .wai =ST_PRESS_LPS331AP_WAI_EXP , .sensors_supported = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, .ch = (struct iio_chan_spec *)st_press_channels, .odr = { - .addr =ST_PRESS_1_ODR_ADDR , - .mask =ST_PRESS_1_ODR_MASK , + .addr =ST_PRESS_LPS331AP_ODR_ADDR , + .mask =ST_PRESS_LPS331AP_ODR_MASK , .odr_avl = { - {1 ,ST_PRESS_1_ODR_AVL_1HZ_VAL , }, - {7 ,ST_PRESS_1_ODR_AVL_7HZ_VAL , }, - {13 ,ST_PRESS_1_ODR_AVL_13HZ_VAL , }, - {25 ,ST_PRESS_1_ODR_AVL_25HZ_VAL , }, + {1 ,ST_PRESS_LPS331AP_ODR_AVL_1HZ_VAL , }, + {7 ,ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL , }, + {13 ,ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL , }, + {25 ,ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL , }, }, }, .pw = { - .addr =ST_PRESS_1_PW_ADDR , - .mask =ST_PRESS_1_PW_MASK , + .addr =ST_PRESS_LPS331AP_PW_ADDR , + .mask =ST_PRESS_LPS331AP_PW_MASK , .value_on =ST_SENSORS_DEFAULT_POWER_ON_VALUE , .value_off =ST_SENSORS_DEFAULT_POWER_OFF_VALUE , }, .fs = { - .addr =ST_PRESS_1_FS_ADDR , - .mask =ST_PRESS_1_FS_MASK , + .addr =ST_PRESS_LPS331AP_FS_ADDR , + .mask =ST_PRESS_LPS331AP_FS_MASK , .fs_avl = { [0 ] = { .num =ST_PRESS_FS_AVL_1260MB , - .value =ST_PRESS_1_FS_AVL_1260_VAL , - .gain =ST_PRESS_1_FS_AVL_1260_GAIN , - .gain2 =ST_PRESS_1_FS_AVL_TEMP_GAIN , + .value =ST_PRESS_LPS331AP_FS_AVL_1260_VAL , + .gain =ST_PRESS_LPS331AP_FS_AVL_1260_GAIN , + .gain2 =ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN , }, }, }, .bdu = { - .addr =ST_PRESS_1_BDU_ADDR , - .mask =ST_PRESS_1_BDU_MASK , + .addr =ST_PRESS_LPS331AP_BDU_ADDR , + .mask =ST_PRESS_LPS331AP_BDU_MASK , }, .drdy_irq = { - .addr =ST_PRESS_1_DRDY_IRQ_ADDR , - .mask =ST_PRESS_1_DRDY_IRQ_MASK , + .addr =ST_PRESS_LPS331AP_DRDY_IRQ_ADDR , + .mask =ST_PRESS_LPS331AP_DRDY_IRQ_MASK , }, - .multi_read_bit =ST_PRESS_1_MULTIREAD_BIT , + .multi_read_bit =ST_PRESS_LPS331AP_MULTIREAD_BIT , .bootime =2 , }, };
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 6/11 iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor
In reply to Lee JonesDue to the MACRO used, the task of reading, understanding and maintaining the LPS331AP's channel descriptor is substantially difficult. This patch is based on the view that it's better to have easy to read, maintainable code than to save a few lines here and there. For that reason we're expanding the array so initialisation is completed in full.
--- drivers/iio/pressure/st_pressure_core.c | 45 +++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 11 deletions(-)
drivers/iio/pressure/st_pressure_core.c +34 -11
@@ -58,16 +58,39 @@#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2b -static const struct iio_chan_spec st_press_channels[] = { -ST_SENSORS_LSM_CHANNELS (IIO_PRESSURE , +static const struct iio_chan_spec st_press_lsp331ap_channels[] = { + { + .type =IIO_PRESSURE , + .channel2 =IIO_NO_MOD , + .address =ST_PRESS_LPS331AP_OUT_XL_ADDR , + .scan_index =ST_SENSORS_SCAN_X , + .scan_type = { + .sign ='u' , + .realbits =24 , + .storagebits =24 , + .endianness =IIO_LE , + }, + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ), -ST_SENSORS_SCAN_X ,0 ,IIO_NO_MOD ,'u' ,IIO_LE ,24 ,24 , -ST_PRESS_LPS331AP_OUT_XL_ADDR ), -ST_SENSORS_LSM_CHANNELS (IIO_TEMP , -BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ) | -BIT (IIO_CHAN_INFO_OFFSET ), --1 ,0 ,IIO_NO_MOD ,'s' ,IIO_LE ,16 ,16 , -ST_TEMP_LPS331AP_OUT_L_ADDR ), + .modified =0 , + }, + { + .type =IIO_TEMP , + .channel2 =IIO_NO_MOD , + .address =ST_TEMP_LPS331AP_OUT_L_ADDR , + .scan_index =-1 , + .scan_type = { + .sign ='u' , + .realbits =16 , + .storagebits =16 , + .endianness =IIO_LE , + }, + .info_mask_separate = +BIT (IIO_CHAN_INFO_RAW ) | +BIT (IIO_CHAN_INFO_SCALE ) | +BIT (IIO_CHAN_INFO_OFFSET ), + .modified =0 , + },IIO_CHAN_SOFT_TIMESTAMP (1 ) };
@@ -77,7 +100,7 @@ static const struct st_sensors st_press_sensors[] = { .sensors_supported = { [0] = LPS331AP_PRESS_DEV_NAME, }, - .ch = (struct iio_chan_spec *)st_press_channels, + .ch = (struct iio_chan_spec *)st_press_lsp331ap_channels, .odr = { .addr = ST_PRESS_LPS331AP_ODR_ADDR, .mask = ST_PRESS_LPS331AP_ODR_MASK,
@@ -214,7 +237,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; pdata->multiread_bit = pdata->sensor->multi_read_bit; indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels =ARRAY_SIZE (st_press_channels); + indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); pdata->current_fullscale = (struct st_sensor_fullscale_avl *) &pdata->sensor->fs.fs_avl[0 ];
Signature · 1 line
1.8.1.2
Re: [PATCH 06/11] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor
Quoted 5 lines
Due to the MACRO used, the task of reading, understanding and maintaining the LPS331AP's channel descriptor is substantially difficult. This patch is based on the view that it's better to have easy to read, maintainable code than to save a few lines here and there. For that reason we're expanding the array so initialisation is completed in full.
Also for this one, the channel names are general and can be shared between different sensors. For the channel definition it's not a problem for me, but I think it's not necessary adds all that code...
Denis
Quoted 76 lines
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 45 +++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 11 deletions(-)drivers/iio/pressure/st_pressure_core.c +34
-11@@ -58,16 +58,39 @@#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2b -static const struct iio_chan_spec st_press_channels[] = { -ST_SENSORS_LSM_CHANNELS (IIO_PRESSURE , +static const struct iio_chan_spec st_press_lsp331ap_channels[] = { + { + .type =IIO_PRESSURE , + .channel2 =IIO_NO_MOD , + .address =ST_PRESS_LPS331AP_OUT_XL_ADDR , + .scan_index =ST_SENSORS_SCAN_X , + .scan_type = { + .sign ='u' , + .realbits =24 , + .storagebits =24 , + .endianness =IIO_LE , + }, + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ), -ST_SENSORS_SCAN_X ,0 ,IIO_NO_MOD ,'u' ,IIO_LE ,24 ,24 , -ST_PRESS_LPS331AP_OUT_XL_ADDR ), -ST_SENSORS_LSM_CHANNELS (IIO_TEMP , -BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ) | -BIT (IIO_CHAN_INFO_OFFSET ), --1 ,0 ,IIO_NO_MOD ,'s' ,IIO_LE ,16 ,16 , -ST_TEMP_LPS331AP_OUT_L_ADDR ), + .modified =0 , + }, + { + .type =IIO_TEMP , + .channel2 =IIO_NO_MOD , + .address =ST_TEMP_LPS331AP_OUT_L_ADDR , + .scan_index =-1 , + .scan_type = { + .sign ='u' , + .realbits =16 , + .storagebits =16 , + .endianness =IIO_LE , + }, + .info_mask_separate = +BIT (IIO_CHAN_INFO_RAW ) | +BIT (IIO_CHAN_INFO_SCALE ) | +BIT (IIO_CHAN_INFO_OFFSET ), + .modified =0 , + },IIO_CHAN_SOFT_TIMESTAMP (1 ) };@@ -77,7 +100,7 @@ static const struct st_sensors st_press_sensors[] = { .sensors_supported = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, - .ch = (struct iio_chan_spec *)st_press_channels, + .ch = (struct iio_chan_spec *)st_press_lsp331ap_channels, .odr = { .addr =ST_PRESS_LPS331AP_ODR_ADDR , .mask = ST_PRESS_LPS331AP_ODR_MASK,@@ -214,7 +237,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; pdata->multiread_bit = pdata->sensor->multi_read_bit; indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels =ARRAY_SIZE (st_press_channels); + indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); pdata->current_fullscale = (struct st_sensor_fullscale_avl *) &pdata->sensor->fs.fs_avl[0 ];
Re: [PATCH 06/11] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor
Quoted 8 lines · Denis CIOCCA
Quoted 5 lines
Due to the MACRO used, the task of reading, understanding and maintaining the LPS331AP's channel descriptor is substantially difficult. This patch is based on the view that it's better to have easy to read, maintainable code than to save a few lines here and there. For that reason we're expanding the array so initialisation is completed in full.
Also for this one, the channel names are general and can be shared between different sensors. For the channel definition it's not a problem for me, but I think it's not necessary adds all that code...
I'm not sure what you mean by this. Would you be kind enough to explain it in a different way please?
Quoted 76 lines
Quoted 76 lines
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 45 +++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 11 deletions(-)drivers/iio/pressure/st_pressure_core.c +34
-11@@ -58,16 +58,39 @@#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2b -static const struct iio_chan_spec st_press_channels[] = { -ST_SENSORS_LSM_CHANNELS (IIO_PRESSURE , +static const struct iio_chan_spec st_press_lsp331ap_channels[] = { + { + .type =IIO_PRESSURE , + .channel2 =IIO_NO_MOD , + .address =ST_PRESS_LPS331AP_OUT_XL_ADDR , + .scan_index =ST_SENSORS_SCAN_X , + .scan_type = { + .sign ='u' , + .realbits =24 , + .storagebits =24 , + .endianness =IIO_LE , + }, + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ), -ST_SENSORS_SCAN_X ,0 ,IIO_NO_MOD ,'u' ,IIO_LE ,24 ,24 , -ST_PRESS_LPS331AP_OUT_XL_ADDR ), -ST_SENSORS_LSM_CHANNELS (IIO_TEMP , -BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ) | -BIT (IIO_CHAN_INFO_OFFSET ), --1 ,0 ,IIO_NO_MOD ,'s' ,IIO_LE ,16 ,16 , -ST_TEMP_LPS331AP_OUT_L_ADDR ), + .modified =0 , + }, + { + .type =IIO_TEMP , + .channel2 =IIO_NO_MOD , + .address =ST_TEMP_LPS331AP_OUT_L_ADDR , + .scan_index =-1 , + .scan_type = { + .sign ='u' , + .realbits =16 , + .storagebits =16 , + .endianness =IIO_LE , + }, + .info_mask_separate = +BIT (IIO_CHAN_INFO_RAW ) | +BIT (IIO_CHAN_INFO_SCALE ) | +BIT (IIO_CHAN_INFO_OFFSET ), + .modified =0 , + },IIO_CHAN_SOFT_TIMESTAMP (1 ) };@@ -77,7 +100,7 @@ static const struct st_sensors st_press_sensors[] = { .sensors_supported = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, - .ch = (struct iio_chan_spec *)st_press_channels, + .ch = (struct iio_chan_spec *)st_press_lsp331ap_channels, .odr = { .addr =ST_PRESS_LPS331AP_ODR_ADDR , .mask = ST_PRESS_LPS331AP_ODR_MASK,@@ -214,7 +237,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; pdata->multiread_bit = pdata->sensor->multi_read_bit; indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels =ARRAY_SIZE (st_press_channels); + indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); pdata->current_fullscale = (struct st_sensor_fullscale_avl *) &pdata->sensor->fs.fs_avl[0 ];
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 06/11] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor
Quoted 11 lines
Quoted 9 lines
Quoted 6 lines
Due to the MACRO used, the task of reading, understanding and maintaining the LPS331AP's channel descriptor is substantially difficult. This patch is based on the view that it's better to have easy to read, maintainable code than to save a few lines here and there. For that reason we're expanding the array so initialisation is completed in full.
Also for this one, the channel names are general and can be shared between different sensors. For the channel definition it's not a problem for me, but I think it's not necessary adds all that code...
I'm not sure what you mean by this. Would you be kind enough to explain it in a different way please?
The channel name (in this case st_press_channels) is not only specific for one sensor but can be shared. Ok in this driver now is used only for the lps331ap but for example in accelerometer driver is used by several sensors. It's possible in the future for new pressure sensors use the same channels definition.
The channel definition is intended the switch by macro ST_SENSORS_LSM_CHANNELS to the full definition, for me is not a problem but I think it's not necessary.
Denis
Quoted 76 lines
Quoted 76 lines
Quoted 76 lines
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 45 +++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 11 deletions(-)drivers/iio/pressure/st_pressure_core.c +34
-11@@ -58,16 +58,39 @@#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2b -static const struct iio_chan_spec st_press_channels[] = { -ST_SENSORS_LSM_CHANNELS (IIO_PRESSURE , +static const struct iio_chan_spec st_press_lsp331ap_channels[] = { + { + .type =IIO_PRESSURE , + .channel2 =IIO_NO_MOD , + .address =ST_PRESS_LPS331AP_OUT_XL_ADDR , + .scan_index =ST_SENSORS_SCAN_X , + .scan_type = { + .sign ='u' , + .realbits =24 , + .storagebits =24 , + .endianness =IIO_LE , + }, + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ), -ST_SENSORS_SCAN_X ,0 ,IIO_NO_MOD ,'u' ,IIO_LE ,24 ,24 , -ST_PRESS_LPS331AP_OUT_XL_ADDR ), -ST_SENSORS_LSM_CHANNELS (IIO_TEMP , -BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ) | -BIT (IIO_CHAN_INFO_OFFSET ), --1 ,0 ,IIO_NO_MOD ,'s' ,IIO_LE ,16 ,16 , -ST_TEMP_LPS331AP_OUT_L_ADDR ), + .modified =0 , + }, + { + .type =IIO_TEMP , + .channel2 =IIO_NO_MOD , + .address =ST_TEMP_LPS331AP_OUT_L_ADDR , + .scan_index =-1 , + .scan_type = { + .sign ='u' , + .realbits =16 , + .storagebits =16 , + .endianness =IIO_LE , + }, + .info_mask_separate = +BIT (IIO_CHAN_INFO_RAW ) | +BIT (IIO_CHAN_INFO_SCALE ) | +BIT (IIO_CHAN_INFO_OFFSET ), + .modified =0 , + },IIO_CHAN_SOFT_TIMESTAMP (1 ) };@@ -77,7 +100,7 @@ static const struct st_sensors st_press_sensors[] = { .sensors_supported = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, - .ch = (struct iio_chan_spec *)st_press_channels, + .ch = (struct iio_chan_spec *)st_press_lsp331ap_channels, .odr = { .addr =ST_PRESS_LPS331AP_ODR_ADDR , .mask = ST_PRESS_LPS331AP_ODR_MASK,@@ -214,7 +237,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; pdata->multiread_bit = pdata->sensor->multi_read_bit; indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels =ARRAY_SIZE (st_press_channels); + indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); pdata->current_fullscale = (struct st_sensor_fullscale_avl *) &pdata->sensor->fs.fs_avl[0 ];
Re: [PATCH 06/11] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor
Quoted 9 lines · Denis CIOCCA
Quoted 9 lines
Quoted 9 lines
Quoted 6 lines
Due to the MACRO used, the task of reading, understanding and maintaining the LPS331AP's channel descriptor is substantially difficult. This patch is based on the view that it's better to have easy to read, maintainable code than to save a few lines here and there. For that reason we're expanding the array so initialisation is completed in full.
Also for this one, the channel names are general and can be shared between different sensors. For the channel definition it's not a problem for me, but I think it's not necessary adds all that code...
Quoted 7 lines
Quoted 2 lines
I'm not sure what you mean by this. Would you be kind enough to explain it in a different way please?
The channel name (in this case
st_press_channels) is not only specific for one sensor but can be shared. Ok in this driver now is used only for the lps331ap but for example in accelerometer driver is used by several sensors. It's possible in the future for new pressure sensors use the same channels definition.
Ah yes I see what you mean. Well as you say, for the moment, as they're separated, this naming convention seems the most appropriate. If we add anymore devices which share the definition, we can pick the best naming convention for the situation I think. For instance, I like that you've split the channels up into the number of bits they support in the gyro and accel cases, so something of that nature could be utilised if other device support is added.
Quoted 3 lines
The channel definition is intended the switch by macro
ST_SENSORS_LSM_CHANNELSto the full definition, for me is not a problem but I think it's not necessary.
If you are familiar with the macro I guess you could get used to working with it, but coming from in as a first time reader, adding a new device was pretty difficult. I had to look up the macro in the header file, then have the original struct open too and cross reference in 3 different places. It's made even more difficult by the macro being in a different order to the original struct.
Now I've had time to work with it, I could probably work with it as well. I was just thinking about helping out any new person that comes along and tries to add support for a new sensor.
Quoted 76 lines
Quoted 76 lines
Quoted 76 lines
Quoted 76 lines
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 45 +++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 11 deletions(-)drivers/iio/pressure/st_pressure_core.c +34
-11@@ -58,16 +58,39 @@#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2b -static const struct iio_chan_spec st_press_channels[] = { -ST_SENSORS_LSM_CHANNELS (IIO_PRESSURE , +static const struct iio_chan_spec st_press_lsp331ap_channels[] = { + { + .type =IIO_PRESSURE , + .channel2 =IIO_NO_MOD , + .address =ST_PRESS_LPS331AP_OUT_XL_ADDR , + .scan_index =ST_SENSORS_SCAN_X , + .scan_type = { + .sign ='u' , + .realbits =24 , + .storagebits =24 , + .endianness =IIO_LE , + }, + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ), -ST_SENSORS_SCAN_X ,0 ,IIO_NO_MOD ,'u' ,IIO_LE ,24 ,24 , -ST_PRESS_LPS331AP_OUT_XL_ADDR ), -ST_SENSORS_LSM_CHANNELS (IIO_TEMP , -BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ) | -BIT (IIO_CHAN_INFO_OFFSET ), --1 ,0 ,IIO_NO_MOD ,'s' ,IIO_LE ,16 ,16 , -ST_TEMP_LPS331AP_OUT_L_ADDR ), + .modified =0 , + }, + { + .type =IIO_TEMP , + .channel2 =IIO_NO_MOD , + .address =ST_TEMP_LPS331AP_OUT_L_ADDR , + .scan_index =-1 , + .scan_type = { + .sign ='u' , + .realbits =16 , + .storagebits =16 , + .endianness =IIO_LE , + }, + .info_mask_separate = +BIT (IIO_CHAN_INFO_RAW ) | +BIT (IIO_CHAN_INFO_SCALE ) | +BIT (IIO_CHAN_INFO_OFFSET ), + .modified =0 , + },IIO_CHAN_SOFT_TIMESTAMP (1 ) };@@ -77,7 +100,7 @@ static const struct st_sensors st_press_sensors[] = { .sensors_supported = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, - .ch = (struct iio_chan_spec *)st_press_channels, + .ch = (struct iio_chan_spec *)st_press_lsp331ap_channels, .odr = { .addr =ST_PRESS_LPS331AP_ODR_ADDR , .mask = ST_PRESS_LPS331AP_ODR_MASK,@@ -214,7 +237,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; pdata->multiread_bit = pdata->sensor->multi_read_bit; indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels =ARRAY_SIZE (st_press_channels); + indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); pdata->current_fullscale = (struct st_sensor_fullscale_avl *) &pdata->sensor->fs.fs_avl[0 ];
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 06/11] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor
Lee, I got your point. For me is ok...
Denis
Quoted 115 lines · Denis CIOCCA
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 6 lines
Due to the MACRO used, the task of reading, understanding and maintaining the LPS331AP's channel descriptor is substantially difficult. This patch is based on the view that it's better to have easy to read, maintainable code than to save a few lines here and there. For that reason we're expanding the array so initialisation is completed in full.
Also for this one, the channel names are general and can be shared between different sensors. For the channel definition it's not a problem for me, but I think it's not necessary adds all that code...
Quoted 7 lines
Quoted 2 lines
I'm not sure what you mean by this. Would you be kind enough to explain it in a different way please?
The channel name (in this case
st_press_channels) is not only specific for one sensor but can be shared. Ok in this driver now is used only for the lps331ap but for example in accelerometer driver is used by several sensors. It's possible in the future for new pressure sensors use the same channels definition.Ah yes I see what you mean. Well as you say, for the moment, as they're separated, this naming convention seems the most appropriate. If we add anymore devices which share the definition, we can pick the best naming convention for the situation I think. For instance, I like that you've split the channels up into the number of bits they support in the gyro and accel cases, so something of that nature could be utilised if other device support is added.
Quoted 3 lines
The channel definition is intended the switch by macro
ST_SENSORS_LSM_CHANNELSto the full definition, for me is not a problem but I think it's not necessary.If you are familiar with the macro I guess you could get used to working with it, but coming from in as a first time reader, adding a new device was pretty difficult. I had to look up the macro in the header file, then have the original struct open too and cross reference in 3 different places. It's made even more difficult by the macro being in a different order to the original struct.
Now I've had time to work with it, I could probably work with it as well. I was just thinking about helping out any new person that comes along and tries to add support for a new sensor.
Quoted 76 lines
Quoted 76 lines
Quoted 76 lines
Quoted 76 lines
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 45 +++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 11 deletions(-)drivers/iio/pressure/st_pressure_core.c +34
-11@@ -58,16 +58,39 @@#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2b -static const struct iio_chan_spec st_press_channels[] = { -ST_SENSORS_LSM_CHANNELS (IIO_PRESSURE , +static const struct iio_chan_spec st_press_lsp331ap_channels[] = { + { + .type =IIO_PRESSURE , + .channel2 =IIO_NO_MOD , + .address =ST_PRESS_LPS331AP_OUT_XL_ADDR , + .scan_index =ST_SENSORS_SCAN_X , + .scan_type = { + .sign ='u' , + .realbits =24 , + .storagebits =24 , + .endianness =IIO_LE , + }, + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ), -ST_SENSORS_SCAN_X ,0 ,IIO_NO_MOD ,'u' ,IIO_LE ,24 ,24 , -ST_PRESS_LPS331AP_OUT_XL_ADDR ), -ST_SENSORS_LSM_CHANNELS (IIO_TEMP , -BIT (IIO_CHAN_INFO_RAW ) |BIT (IIO_CHAN_INFO_SCALE ) | -BIT (IIO_CHAN_INFO_OFFSET ), --1 ,0 ,IIO_NO_MOD ,'s' ,IIO_LE ,16 ,16 , -ST_TEMP_LPS331AP_OUT_L_ADDR ), + .modified =0 , + }, + { + .type =IIO_TEMP , + .channel2 =IIO_NO_MOD , + .address =ST_TEMP_LPS331AP_OUT_L_ADDR , + .scan_index =-1 , + .scan_type = { + .sign ='u' , + .realbits =16 , + .storagebits =16 , + .endianness =IIO_LE , + }, + .info_mask_separate = +BIT (IIO_CHAN_INFO_RAW ) | +BIT (IIO_CHAN_INFO_SCALE ) | +BIT (IIO_CHAN_INFO_OFFSET ), + .modified =0 , + },IIO_CHAN_SOFT_TIMESTAMP (1 ) };@@ -77,7 +100,7 @@ static const struct st_sensors st_press_sensors[] = { .sensors_supported = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, - .ch = (struct iio_chan_spec *)st_press_channels, + .ch = (struct iio_chan_spec *)st_press_lsp331ap_channels, .odr = { .addr =ST_PRESS_LPS331AP_ODR_ADDR , .mask = ST_PRESS_LPS331AP_ODR_MASK,@@ -214,7 +237,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; pdata->multiread_bit = pdata->sensor->multi_read_bit; indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels =ARRAY_SIZE (st_press_channels); + indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); pdata->current_fullscale = (struct st_sensor_fullscale_avl *) &pdata->sensor->fs.fs_avl[0 ];
PATCH 7/11 iio: sensors-core: st: Allow full-scale to be an optional feature
In reply to Lee JonesSome chips either don't support it or fail to provide adequate documentation, so sometimes it's impossible to enable the feature even if it is supported.
--- drivers/iio/common/st_sensors/st_sensors_core.c | 11 +++++++---- drivers/iio/pressure/st_pressure_core.c | 6 ++++-- 2 files changed, 11 insertions(+), 6 deletions(-)
drivers/iio/common/st_sensors/st_sensors_core.c +7 -4
@@ -209,10 +209,13 @@ int st_sensors_init_sensor(struct iio_dev *indio_dev)if (err <0 ) goto init_error; - err =st_sensors_set_fullscale (indio_dev, - sdata->current_fullscale->num); -if (err <0 ) - goto init_error; +if (sdata->current_fullscale) { + err =st_sensors_set_fullscale (indio_dev, + sdata->current_fullscale->num); +if (err <0 ) + goto init_error; + }else +dev_info (&indio_dev->dev,"Full-scale not possible\n" ); err =st_sensors_set_odr (indio_dev, sdata->odr);if (err <0 )
drivers/iio/pressure/st_pressure_core.c +4 -2
@@ -239,8 +239,10 @@ int st_press_common_probe(struct iio_dev *indio_dev) indio_dev->channels = pdata->sensor->ch; indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); - pdata->current_fullscale = (struct st_sensor_fullscale_avl *) - &pdata->sensor->fs.fs_avl[0 ]; +if (pdata->sensor->fs.addr !=0 ) + pdata->current_fullscale = (struct st_sensor_fullscale_avl *) + &pdata->sensor->fs.fs_avl[0 ]; + pdata->odr = pdata->sensor->odr.odr_avl[0 ].hz; err =st_sensors_init_sensor (indio_dev);
Signature · 1 line
1.8.1.2
Re: [PATCH 07/11] iio: sensors-core: st: Allow full-scale to be an optional feature
Quoted 48 lines
Some chips either don't support it or fail to provide adequate documentation, so sometimes it's impossible to enable the feature even if it is supported.
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/common/st_sensors/st_sensors_core.c | 11 +++++++---- drivers/iio/pressure/st_pressure_core.c | 6 ++++-- 2 files changed, 11 insertions(+), 6 deletions(-)drivers/iio/common/st_sensors/st_sensors_core.c +7
-4@@ -209,10 +209,13 @@ int st_sensors_init_sensor(struct iio_dev *indio_dev)if (err <0 ) goto init_error; - err =st_sensors_set_fullscale (indio_dev, - sdata->current_fullscale->num); -if (err <0 ) - goto init_error; +if (sdata->current_fullscale) { + err =st_sensors_set_fullscale (indio_dev, + sdata->current_fullscale->num); +if (err <0 ) + goto init_error; + }else +dev_info (&indio_dev->dev,"Full-scale not possible\n" ); err =st_sensors_set_odr (indio_dev, sdata->odr);if (err <0 )drivers/iio/pressure/st_pressure_core.c +4
-2@@ -239,8 +239,10 @@ int st_press_common_probe(struct iio_dev *indio_dev) indio_dev->channels = pdata->sensor->ch; indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); - pdata->current_fullscale = (struct st_sensor_fullscale_avl *) - &pdata->sensor->fs.fs_avl[0 ]; +if (pdata->sensor->fs.addr !=0 ) + pdata->current_fullscale = (struct st_sensor_fullscale_avl *) + &pdata->sensor->fs.fs_avl[0 ]; + pdata->odr = pdata->sensor->odr.odr_avl[0 ].hz; err =st_sensors_init_sensor (indio_dev);
PATCH 8/11 iio: pressure-core: st: Allow for number of channels to vary
In reply to Lee JonesAt the moment the number of channels specified is dictated by the first sensor supported by the driver. As we add support for more sensors this is likely to vary. Instead of using the ARRAY_SIZE() of the LPS331AP's channel specifier we'll use a new adaptable 'struct st_sensors' element instead.
--- drivers/iio/pressure/st_pressure_core.c | 3 ++- include/linux/iio/common/st_sensors.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/iio/pressure/st_pressure_core.c +2 -1
@@ -101,6 +101,7 @@ static const struct st_sensors st_press_sensors[] = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, .ch = (struct iio_chan_spec *)st_press_lsp331ap_channels, + .num_ch = ARRAY_SIZE(st_press_lsp331ap_channels), .odr = { .addr =ST_PRESS_LPS331AP_ODR_ADDR , .mask =ST_PRESS_LPS331AP_ODR_MASK ,
@@ -237,7 +238,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; pdata->multiread_bit = pdata->sensor->multi_read_bit; indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); + indio_dev->num_channels = pdata->sensor->num_ch;if (pdata->sensor->fs.addr !=0 ) pdata->current_fullscale = (struct st_sensor_fullscale_avl *)
include/linux/iio/common/st_sensors.h +1 -0
@@ -180,6 +180,7 @@ struct st_sensors {u8 wai;char sensors_supported[ST_SENSORS_MAX_4WAI ][ST_SENSORS_MAX_NAME ];struct iio_chan_spec *ch; +int num_ch;struct st_sensor_odr odr;struct st_sensor_power pw;struct st_sensor_axis enable_axis;
Signature · 1 line
1.8.1.2
Re: [PATCH 08/11] iio: pressure-core: st: Allow for number of channels to vary
Quoted 45 lines
At the moment the number of channels specified is dictated by the first sensor supported by the driver. As we add support for more sensors this is likely to vary. Instead of using the
ARRAY_SIZE()of the LPS331AP's channel specifier we'll use a new adaptable 'structst_sensors' element instead.Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 3 ++- include/linux/iio/common/st_sensors.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)drivers/iio/pressure/st_pressure_core.c +2
-1@@ -101,6 +101,7 @@ static const struct st_sensors st_press_sensors[] = { [0 ] =LPS331AP_PRESS_DEV_NAME , }, .ch = (struct iio_chan_spec *)st_press_lsp331ap_channels, + .num_ch = ARRAY_SIZE(st_press_lsp331ap_channels), .odr = { .addr =ST_PRESS_LPS331AP_ODR_ADDR , .mask =ST_PRESS_LPS331AP_ODR_MASK ,@@ -237,7 +238,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; pdata->multiread_bit = pdata->sensor->multi_read_bit; indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels =ARRAY_SIZE (st_press_lsp331ap_channels); + indio_dev->num_channels = pdata->sensor->num_ch;if (pdata->sensor->fs.addr !=0 ) pdata->current_fullscale = (struct st_sensor_fullscale_avl *)include/linux/iio/common/st_sensors.h +1
-0@@ -180,6 +180,7 @@ struct st_sensors {u8 wai;char sensors_supported[ST_SENSORS_MAX_4WAI ][ST_SENSORS_MAX_NAME ];struct iio_chan_spec *ch; +int num_ch;struct st_sensor_odr odr;struct st_sensor_power pw;struct st_sensor_axis enable_axis;
PATCH 9/11 iio: pressure-core: st: Clean-up error handling in probe function
In reply to Lee JonesThis patch contains some pretty basic clean-ups in probe() pertaining to the simplification of error handling and a couple of readability adaptions.
--- drivers/iio/pressure/st_pressure_core.c | 41 +++++++++++++++------------------ 1 file changed, 19 insertions(+), 22 deletions(-)
drivers/iio/pressure/st_pressure_core.c +19 -22
@@ -224,21 +224,23 @@ static const struct iio_trigger_ops st_press_trigger_ops = {int st_press_common_probe (struct iio_dev *indio_dev) { -int err;struct st_sensor_data *pdata =iio_priv (indio_dev); +int irq = pdata->get_irq_data_ready (indio_dev); +int err; indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &press_info; err =st_sensors_check_device_support (indio_dev, -ARRAY_SIZE (st_press_sensors), st_press_sensors); +ARRAY_SIZE (st_press_sensors), + st_press_sensors);if (err <0 ) - goto st_press_common_probe_error; +return err; pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; - pdata->multiread_bit = pdata->sensor->multi_read_bit; - indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels = pdata->sensor->num_ch; + pdata->multiread_bit = pdata->sensor->multi_read_bit; + indio_dev->channels = pdata->sensor->ch; + indio_dev->num_channels = pdata->sensor->num_ch;if (pdata->sensor->fs.addr !=0 ) pdata->current_fullscale = (struct st_sensor_fullscale_avl *)
@@ -248,32 +250,27 @@ int st_press_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev);if (err <0 ) - goto st_press_common_probe_error; +return err; -if (pdata->get_irq_data_ready (indio_dev) >0 ) { +if (irq >0 ) { err =st_press_allocate_ring (indio_dev);if (err <0 ) - goto st_press_common_probe_error; +return err; err =st_sensors_allocate_trigger (indio_dev, -ST_PRESS_TRIGGER_OPS ); -if (err <0 ) - goto st_press_probe_trigger_error; +ST_PRESS_TRIGGER_OPS ); +if (err <0 ) { +st_press_deallocate_ring (indio_dev); +return err; + } } err =iio_device_register (indio_dev); -if (err) - goto st_press_device_register_error; - -return err; - -st_press_device_register_error: -if (pdata->get_irq_data_ready (indio_dev) >0 ) +if (err && irq >0 ) {st_sensors_deallocate_trigger (indio_dev); -st_press_probe_trigger_error: -if (pdata->get_irq_data_ready (indio_dev) >0 )st_press_deallocate_ring (indio_dev); -st_press_common_probe_error: + } +return err; }EXPORT_SYMBOL (st_press_common_probe);
Signature · 1 line
1.8.1.2
Jonathan Cameron
maintainerRe: [PATCH 09/11] iio: pressure-core: st: Clean-up error handling in probe function
Quoted 6 lines · Lee Jones
This patch contains some pretty basic clean-ups in
probe()pertaining to
the simplification of error handling and a couple of readability adaptions.Signed-off-by Lee Jones <[email protected]>
Hi Lee
Most of this series look fine but I am not that keen on some of this one.
The white space changes are definitely a matter of taste and honestly I don't care either way.
The returns are fine when there is no cleanup to do.
GOTOs and a clean unwind of the function is to my eye easier to review than unwinding directly after each error.
If reviewing original driver I would probably not bother commenting but for a cleanup patch the cleanup wants to be a clear improvement!
Out of time now so will have to get to the rest of the series sometime soon.
Quoted 86 lines
---
drivers/iio/pressure/st_pressure_core.c| 41
+++++++++++++++------------------1 file changed, 19 insertions(+), 22 deletions(-)drivers/iio/pressure/st_pressure_core.c +8
-6@@ -224,21 +224,23 @@ static const struct iio_trigger_ops st_press_trigger_ops = {int st_press_common_probe (struct iio_dev *indio_dev) { -int err;struct st_sensor_data *pdata =iio_priv (indio_dev); +int irq = pdata->get_irq_data_ready (indio_dev); +int err; indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &press_info; err =st_sensors_check_device_support (indio_dev, -ARRAY_SIZE (st_press_sensors), st_press_sensors); +ARRAY_SIZE (st_press_sensors), + st_press_sensors);if (err <0 ) - goto st_press_common_probe_error; +return err; pdata->num_data_channels =ST_PRESS_NUMBER_DATA_CHANNELS ; - pdata->multiread_bit = pdata->sensor->multi_read_bit; - indio_dev->channels = pdata->sensor->ch; - indio_dev->num_channels = pdata->sensor->num_ch; + pdata->multiread_bit = pdata->sensor->multi_read_bit; + indio_dev->channels = pdata->sensor->ch; + indio_dev->num_channels = pdata->sensor->num_ch;if (pdata->sensor->fs.addr !=0 )pdata->current_fullscale = (struct st_sensor_fullscale_avl *)drivers/iio/pressure/st_pressure_core.c +11
-16@@ -248,32 +250,27 @@ int st_press_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev);if (err <0 ) - goto st_press_common_probe_error; +return err; -if (pdata->get_irq_data_ready (indio_dev) >0 ) { +if (irq >0 ) { err =st_press_allocate_ring (indio_dev);if (err <0 ) - goto st_press_common_probe_error; +return err; err =st_sensors_allocate_trigger (indio_dev, -ST_PRESS_TRIGGER_OPS ); -if (err <0 ) - goto st_press_probe_trigger_error; +ST_PRESS_TRIGGER_OPS ); +if (err <0 ) { +st_press_deallocate_ring (indio_dev); +return err; + } } err =iio_device_register (indio_dev); -if (err) - goto st_press_device_register_error; - -return err; - -st_press_device_register_error: -if (pdata->get_irq_data_ready (indio_dev) >0 ) +if (err && irq >0 ) {st_sensors_deallocate_trigger (indio_dev); -st_press_probe_trigger_error: -if (pdata->get_irq_data_ready (indio_dev) >0 )st_press_deallocate_ring (indio_dev); -st_press_common_probe_error: + } +return err; }
EXPORT_SYMBOL(st_press_common_probe);
Signature · 1 line
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
PATCH 10/11 iio: pressure: st: Add support for new LPS001WP pressure sensor
In reply to Lee JonesHere we use existing practices to introduce support for another pressure/temperature sensor, the LPS001WP.
--- drivers/iio/pressure/st_pressure.h | 1 + drivers/iio/pressure/st_pressure_core.c | 84 +++++++++++++++++++++++++++++++++ drivers/iio/pressure/st_pressure_i2c.c | 1 + 3 files changed, 86 insertions(+)
drivers/iio/pressure/st_pressure.h +1 -0
@@ -15,6 +15,7 @@#include <linux/iio/common/st_sensors.h> #define LPS331AP_PRESS_DEV_NAME "lps331ap" +#define LPS001WP_PRESS_DEV_NAME "lps001wp"int st_press_common_probe (struct iio_dev *indio_dev);void st_press_common_remove (struct iio_dev *indio_dev);
drivers/iio/pressure/st_pressure_core.c +84 -0
102 lines not on this page · raw message
drivers/iio/pressure/st_pressure_i2c.c +1 -0
@@ -52,6 +52,7 @@ static int st_press_i2c_remove(struct i2c_client *client)static const struct i2c_device_id st_press_id_table[] = { {LPS331AP_PRESS_DEV_NAME }, + {LPS001WP_PRESS_DEV_NAME }, {}, };MODULE_DEVICE_TABLE (i2c, st_press_id_table);
Signature · 1 line
1.8.1.2
PATCH 11/11 iio: pressure-core: st: Provide correct regulator support
In reply to Lee JonesThe power to some of the sensors are controlled by regulators. In most cases these are 'always on', but if not they will fail to work until the regulator is enabled using the relevant APIs.
--- drivers/iio/pressure/st_pressure_core.c | 13 +++++++++++++ include/linux/iio/common/st_sensors.h | 3 +++ 2 files changed, 16 insertions(+)
drivers/iio/pressure/st_pressure_core.c +13 -0
@@ -23,6 +23,7 @@#include <linux/iio/sysfs.h> #include <linux/iio/trigger.h> #include <linux/iio/buffer.h> +#include <linux/regulator/consumer.h> #include <asm/unaligned.h> #include <linux/iio/common/st_sensors.h>
@@ -315,6 +316,15 @@ int st_press_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &press_info; +/* Regulator not mandatory, but if requested we should enable it. */ + pdata->regulator =regulator_get (&indio_dev->dev,"vdd" ); +if (!IS_ERR_OR_NULL (pdata->regulator)) { + err =regulator_enable (pdata->regulator); +if (err !=0 ) +dev_warn (&indio_dev->dev, +"Failed to enable specified vdd regulator\n" ); + } + err =st_sensors_check_device_support (indio_dev,ARRAY_SIZE (st_press_sensors), st_press_sensors);
@@ -363,6 +373,9 @@ void st_press_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *pdata =iio_priv (indio_dev); +if (!IS_ERR_OR_NULL (pdata->regulator)) +regulator_disable (pdata->regulator); +iio_device_unregister (indio_dev);if (pdata->get_irq_data_ready (indio_dev) >0 ) {st_sensors_deallocate_trigger (indio_dev);
include/linux/iio/common/st_sensors.h +3 -0
@@ -16,6 +16,7 @@#include <linux/irqreturn.h> #include <linux/iio/trigger.h> #include <linux/bitops.h> +#include <linux/regulator/consumer.h> #define ST_SENSORS_TX_MAX_LENGTH 2#define ST_SENSORS_RX_MAX_LENGTH 6
@@ -197,6 +198,7 @@ struct st_sensors {* @trig: The trigger in use by the core driver. * @sensor: Pointer to the current sensor struct in use. * @current_fullscale: Maximum range of measure by the sensor. +* @regulator: Pointer to sensor's power supply * @enabled: Status of the sensor (false->off, true->on). * @multiread_bit: Use or not particular bit for [I2C/SPI] multiread. * @buffer_data: Data used by buffer part.
@@ -211,6 +213,7 @@ struct st_sensor_data {struct iio_trigger *trig;struct st_sensors *sensor;struct st_sensor_fullscale_avl *current_fullscale; +struct regulator *regulator;bool enabled;bool multiread_bit;
Signature · 1 line
1.8.1.2
Re: [PATCH 11/11] iio: pressure-core: st: Provide correct regulator support
Hi Lee,
Quoted 23 lines · Lee Jones
The power to some of the sensors are controlled by regulators. In most cases these are 'always on', but if not they will fail to work until the regulator is enabled using the relevant APIs.
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 13 +++++++++++++ include/linux/iio/common/st_sensors.h | 3 +++ 2 files changed, 16 insertions(+)drivers/iio/pressure/st_pressure_core.c +1
-0@@ -23,6 +23,7 @@#include <linux/iio/sysfs.h> #include <linux/iio/trigger.h> #include <linux/iio/buffer.h> +#include <linux/regulator/consumer.h> #include <asm/unaligned.h> #include <linux/iio/common/st_sensors.h>
drivers/iio/pressure/st_pressure_core.c int st_press_common_probe(struct iio_dev *indio_dev) · line 321
Quoted 6 lines
drivers/iio/pressure/st_pressure_core.c +3
-0@@ -315,6 +316,15 @@ int st_press_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &press_info; +/* Regulator not mandatory, but if requested we should enable it. */ + pdata->regulator =regulator_get (&indio_dev->dev,"vdd" ); +if (!IS_ERR_OR_NULL (pdata->regulator)) {
Can regulator_get return NULL? As far as I can see, it either returns a valid reulator pointer or an ERR_PTR value.
When you say "if requested", do you mean "if described in the dt"? If so, the above doesn't distunguish between a regulator not being listed and one failing to be got (e.g. if we got EPROBE_DEFER from regulator_get).
I think this would be better handled with something like Mark Brown's suggested regulator_get_optional [1,2].
Thanks,
Mark.
[1] https://lkml.org/lkml/2013/7/30/328 (cover)
[2] https://lkml.org/lkml/2013/7/30/334 (patches)
Quoted 56 lines
drivers/iio/pressure/st_pressure_core.c +9
-0+ err =regulator_enable (pdata->regulator); +if (err !=0 ) +dev_warn (&indio_dev->dev, +"Failed to enable specified vdd regulator\n" ); + } + err =st_sensors_check_device_support (indio_dev,ARRAY_SIZE (st_press_sensors), st_press_sensors);@@ -363,6 +373,9 @@ void st_press_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *pdata =iio_priv (indio_dev); +if (!IS_ERR_OR_NULL (pdata->regulator)) +regulator_disable (pdata->regulator); +iio_device_unregister (indio_dev);if (pdata->get_irq_data_ready (indio_dev) >0 ) {st_sensors_deallocate_trigger (indio_dev);include/linux/iio/common/st_sensors.h +3
-0@@ -16,6 +16,7 @@#include <linux/irqreturn.h> #include <linux/iio/trigger.h> #include <linux/bitops.h> +#include <linux/regulator/consumer.h> #define ST_SENSORS_TX_MAX_LENGTH 2#define ST_SENSORS_RX_MAX_LENGTH 6@@ -197,6 +198,7 @@ struct st_sensors {* @trig: The trigger in use by the core driver. * @sensor: Pointer to the current sensor struct in use. * @current_fullscale: Maximum range of measure by the sensor. +* @regulator: Pointer to sensor's power supply * @enabled: Status of the sensor (false->off, true->on). * @multiread_bit: Use or not particular bit for [I2C/SPI] multiread. * @buffer_data: Data used by buffer part. @@ -211,6 +213,7 @@ struct st_sensor_data {struct iio_trigger *trig;struct st_sensors *sensor;struct st_sensor_fullscale_avl *current_fullscale; +struct regulator *regulator;bool enabled;bool multiread_bit;Signature · 7 lines
1.8.1.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 11/11] iio: pressure-core: st: Provide correct regulator support
Quoted 36 lines · Mark Rutland
Hi Lee,
Quoted 23 lines · Lee Jones
The power to some of the sensors are controlled by regulators. In most cases these are 'always on', but if not they will fail to work until the regulator is enabled using the relevant APIs.
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 13 +++++++++++++ include/linux/iio/common/st_sensors.h | 3 +++ 2 files changed, 16 insertions(+)drivers/iio/pressure/st_pressure_core.c +1
-0@@ -23,6 +23,7 @@#include <linux/iio/sysfs.h> #include <linux/iio/trigger.h> #include <linux/iio/buffer.h> +#include <linux/regulator/consumer.h> #include <asm/unaligned.h> #include <linux/iio/common/st_sensors.h> drivers/iio/pressure/st_pressure_core.c int st_press_common_probe(struct iio_dev *indio_dev) · line 321
Quoted 6 lines
drivers/iio/pressure/st_pressure_core.c +3
-0@@ -315,6 +316,15 @@ int st_press_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &press_info; +/* Regulator not mandatory, but if requested we should enable it. */ + pdata->regulator =regulator_get (&indio_dev->dev,"vdd" ); +if (!IS_ERR_OR_NULL (pdata->regulator)) {Can
regulator_getreturn NULL? As far as I can see, it either returns a valid reulator pointer or anERR_PTRvalue.
Quoted 7 lines
When you say "if requested", do you mean "if described in the dt"? If so, the above doesn't distunguish between a regulator not being listed and one failing to be got (e.g. if we got
EPROBE_DEFERfromregulator_get).I think this would be better handled with something like Mark Brown's suggested
regulator_get_optional[1,2].
It can return NULL, but NULL is actually a valid regulator in that case, so the check should only be IS_ERR. And yes regulator_get_optional is what should be used here.
- Lars
Re: [PATCH 11/11] iio: pressure-core: st: Provide correct regulator support
Quoted 37 lines · Lars-Peter Clausen
Quoted 36 lines · Mark Rutland
Hi Lee,
Quoted 23 lines · Lee Jones
The power to some of the sensors are controlled by regulators. In most cases these are 'always on', but if not they will fail to work until the regulator is enabled using the relevant APIs.
Signed-off-by Lee Jones <[email protected]>--- drivers/iio/pressure/st_pressure_core.c | 13 +++++++++++++ include/linux/iio/common/st_sensors.h | 3 +++ 2 files changed, 16 insertions(+)drivers/iio/pressure/st_pressure_core.c +1
-0@@ -23,6 +23,7 @@#include <linux/iio/sysfs.h> #include <linux/iio/trigger.h> #include <linux/iio/buffer.h> +#include <linux/regulator/consumer.h> #include <asm/unaligned.h> #include <linux/iio/common/st_sensors.h> drivers/iio/pressure/st_pressure_core.c int st_press_common_probe(struct iio_dev *indio_dev) · line 321
Quoted 6 lines
drivers/iio/pressure/st_pressure_core.c +3
-0@@ -315,6 +316,15 @@ int st_press_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &press_info; +/* Regulator not mandatory, but if requested we should enable it. */ + pdata->regulator =regulator_get (&indio_dev->dev,"vdd" ); +if (!IS_ERR_OR_NULL (pdata->regulator)) {Can
regulator_getreturn NULL? As far as I can see, it either returns a valid reulator pointer or anERR_PTRvalue.
Quoted 7 lines
Quoted 7 lines
When you say "if requested", do you mean "if described in the dt"? If so, the above doesn't distunguish between a regulator not being listed and one failing to be got (e.g. if we got
EPROBE_DEFERfromregulator_get).I think this would be better handled with something like Mark Brown's suggested
regulator_get_optional[1,2].
Thanks Mark, I didn't know that existed.
Quoted 3 lines
It can return NULL, but NULL is actually a valid regulator in that case, so the check should only be
IS_ERR. And yesregulator_get_optionalis what should be used here.
Okay, I'll use that instead.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 11/11] iio: pressure-core: st: Provide correct regulator support
Quoted 6 lines · Lee Jones
Quoted 2 lines · Lars-Peter Clausen
Quoted 2 lines
I think this would be better handled with something like Mark Brown's suggested
regulator_get_optional[1,2].Thanks Mark, I didn't know that existed.
It's only just gone into Linus' tree this merge window so it's very new.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130904/6ceaf0c4/attachment.sig>
Re: [PATCH 11/11] iio: pressure-core: st: Provide correct regulator support
In reply to Mark RutlandQuoted 8 lines · Mark Rutland
drivers/iio/pressure/st_pressure_core.c int st_press_common_probe(struct iio_dev *indio_dev) · line 321
Quoted 3 lines · Lee Jones
drivers/iio/pressure/st_pressure_core.c +3
-0+/* Regulator not mandatory, but if requested we should enable it. */ + pdata->regulator =regulator_get (&indio_dev->dev,"vdd" ); +if (!IS_ERR_OR_NULL (pdata->regulator)) {Can
regulator_getreturn NULL? As far as I can see, it either returns a valid reulator pointer or anERR_PTRvalue.
Yes, NULL is a valid regulator.
Quoted 7 lines
When you say "if requested", do you mean "if described in the dt"? If so, the above doesn't distunguish between a regulator not being listed and one failing to be got (e.g. if we got
EPROBE_DEFERfromregulator_get).I think this would be better handled with something like Mark Brown's suggested
regulator_get_optional[1,2].
If the regulator may genuinely be absent from the system then it should
be being requested using regulator_get_optional(). Otherwise it should
be being requested using regulator_get(). In both cases it is important
that the driver pays attention to errors.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130904/2740eea2/attachment.sig>