esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 3 lines
(quoted diff) +3
-0+struct esas2r_adapter { + struct esas2r_target targetdb[ESAS2R_MAX_TARGETS]; + struct esas2r_target *targetdb_end;
...
Quoted 10 lines
(quoted diff) +8
-0+ u8 fw_coredump_buff[ESAS2R_FWCOREDUMP_SZ]; +void esas2r_reset_chip(struct esas2r_adapter *a) +{ + if (!esas2r_is_adapter_present(a)) + return; + + /* + * Before we reset the chip, save off the VDA core dump. The VDA core
Review
Quoted 10 lines
(quoted diff) +10
-0+ * dump is located in the upper 512KB of the onchip SRAM. Make sure + * to not overwrite a previous crash that was saved. + */ + if ((a->flags2 & AF2_COREDUMP_AVAIL) + && !(a->flags2 & AF2_COREDUMP_SAVED) + && a->fw_coredump_buff) { + esas2r_read_mem_block(a, + a->fw_coredump_buff, + MW_DATA_ADDR_SRAM + 0x80000, + ESAS2R_FWCOREDUMP_SZ);
Comparing an array (fw_coredump_buff) to null probably isn't what you intended here.
Dave