Skip to contentSkip to conversation

dvb-usb/technisat-usb2: Fix cut-n-paste thinko

PATCH Dave Jones 2 participants 2 messages Sep 4, 2013 – Sep 5, 2013 Media (V4L/DVB)

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

This looks like it was cut and pasted from the code above which does similar checks on txlen, but someone forgot to change the variable.

drivers/media/usb/dvb-usb/technisat-usb2.c +1 -1
index 40832a1..98d24ae 100644
@@ -102,7 +102,7 @@ static int technisat_usb2_i2c_access(struct usb_device *udev,
 	if (rxlen > 62) {
 		err("i2c RX buffer can't exceed 62 bytes (dev 0x%02x)",
 				device_addr);
-		txlen = 62;
+		rxlen = 62;
 	}
 
 	b[0] = I2C_SPEED_100KHZ_BIT;
#1 lore raw

Hi Dave,

Quoted 2 lines · On Wednesday 04 September 2013 19:59:17 Dave Jones wrote:

This looks like it was cut and pasted from the code above which does similar checks on txlen, but someone forgot to change the variable.

This someone would be me.

Quoted 8 lines
(quoted diff) +0 -0

b/drivers/media/usb/dvb-usb/technisat-usb2.c index 40832a1..98d24ae 100644

drivers/media/usb/dvb-usb/technisat-usb2.c static int technisat_usb2_i2c_access(struct usb_device · line 108

Quoted 8 lines
drivers/media/usb/dvb-usb/technisat-usb2.c +1 -1
@@ -102,7 +102,7 @@ static int technisat_usb2_i2c_access(struct usb_device
 *udev, if (rxlen > 62) {
 		err("i2c RX buffer can't exceed 62 bytes (dev 0x%02x)",
 				device_addr);
-		txlen = 62;
+		rxlen = 62;
 	}
 
 	b[0] = I2C_SPEED_100KHZ_BIT;

Nice catch.

Mauro, feel free to add my signed-off-line, when integrating

--
Patrick