Add missing braces to do_tcp_setsockopt

PATCH In review Dave Jones 3 participants 4 messages Sep 5, 2013

Subsystems (3)

Networking Network drivers TCP

lore

Share & tools

lore

Dave Jones

author

2013-09-05 17:43 UTC #0 lore raw

PATCH 1/1 Add missing braces to do_tcp_setsockopt

Signed-off-by Dave Jones <[email protected]>

net/ipv4/tcp.c +2 -1

index b2f6c74..95544e4 100644
@@ -2454,10 +2454,11 @@ static int do_tcp_setsockopt(struct sock *sk, int level,
 	case TCP_THIN_DUPACK:
 		if (val < 0 || val > 1)
 			err = -EINVAL;
-		else
+		else {
 			tp->thin_dupack = val;
 			if (tp->thin_dupack)
 				tcp_disable_early_retrans(tp);
+		}
 		break;
 
 	case TCP_REPAIR:

Neal Cardwell

maintainer Acked-by on v1 1/1

2013-09-05 17:55 UTC #1 lore raw

Quoted 1 line · Dave Jones

Signed-off-by Dave Jones <[email protected]>

Acked-by Neal Cardwell <[email protected]>

neal

Dave Jones

author

2013-09-05 17:59 UTC #2 lore raw

Quoted 6 lines · Neal Cardwell

Quoted 1 line · Dave Jones
Signed-off-by Dave Jones <[email protected]>
Acked-by Neal Cardwell <[email protected]>
neal

Crap, I forgot the

introduced in eed530b6c67624db3f2cf477bac7c4d005d8f7ba ("tcp: early retransmit")

Dave, shall I resend ?

Dave

David Miller

maintainer

2013-09-05 18:18 UTC #3 lore raw

From: Dave Jones <[email protected]>
Date: Thu, 5 Sep 2013 13:58:47 -0400

Quoted 6 lines · Neal Cardwell

Quoted 5 lines · Dave Jones
Quoted 1 line
Signed-off-by Dave Jones <[email protected]>
Acked-by Neal Cardwell <[email protected]>

Quoted 7 lines

Quoted 1 line
neal
Crap, I forgot the
introduced in eed530b6c67624db3f2cf477bac7c4d005d8f7ba ("tcp: early retransmit")
Dave, shall I resend ?

I'll take care of it.