Skip to contentSkip to conversation

inetutils: Remove empty usr/lib

PATCH In review Khem Raj 3 participants 4 messages Sep 5, 2013 – Sep 6, 2013

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 inetutils: Remove empty usr/lib

This directory is empty and is flagged by QA checker

ERROR: QA Issue: inetutils: Files/directories were installed but not shipped
/usr/lib

---
 meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb +2 -0
index 7c7343e..e371ae5 100644
@@ -70,6 +70,8 @@ do_install_append () {
     cp ${WORKDIR}/telnet.xinetd.inetutils  ${D}/${sysconfdir}/xinetd.d/telnet
     cp ${WORKDIR}/tftpd.xinetd.inetutils  ${D}/${sysconfdir}/xinetd.d/tftpd
     rm -rf ${D}${libexecdir}/
+    # remove usr/lib if empty
+    rmdir ${D}${libdir}
 }
 
 PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
Signature · 1 line
1.8.4
#1 lore raw
Quoted 16 lines · Khem Raj

This directory is empty and is flagged by QA checker

ERROR: QA Issue: inetutils: Files/directories were installed but not shipped
/usr/lib

---
 meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb +0 -0
index 7c7343e..e371ae5 100644

meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb do_install_append () { · line 74

Quoted 5 lines
meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb +2 -0
@@ -70,6 +70,8 @@ do_install_append () {
     cp ${WORKDIR}/telnet.xinetd.inetutils  ${D}/${sysconfdir}/xinetd.d/telnet
     cp ${WORKDIR}/tftpd.xinetd.inetutils  ${D}/${sysconfdir}/xinetd.d/tftpd
     rm -rf ${D}${libexecdir}/
+    # remove usr/lib if empty
+    rmdir ${D}${libdir}

The comment suggests missing --ignore-fail-on-non-empty

Quoted 10 lines
meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb +0 -0
 }
 
 PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
Signature · 6 lines
1.8.4

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
author
#2 lore raw
Quoted 12 lines · Martin Jansa
Quoted 11 lines · Khem Raj

This directory is empty and is flagged by QA checker

ERROR: QA Issue: inetutils: Files/directories were installed but not shipped
/usr/lib

---
 meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb | 2 ++
 1 file changed, 2 insertions(+)
Quoted 12 lines

meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb do_install_append () { · line 74

Quoted 10 lines
meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb +2 -0
index 7c7343e..e371ae5 100644
@@ -70,6 +70,8 @@ do_install_append () {
     cp ${WORKDIR}/telnet.xinetd.inetutils  ${D}/${sysconfdir}/xinetd.d/telnet
     cp ${WORKDIR}/tftpd.xinetd.inetutils  ${D}/${sysconfdir}/xinetd.d/tftpd
     rm -rf ${D}${libexecdir}/
+    # remove usr/lib if empty
+    rmdir ${D}${libdir}

The comment suggests missing --ignore-fail-on-non-empty

hmmm,I would add it when that happens and also then take opportunity to make sure that they are packaged
into right packages, so far I have not found a case where its populated.

Quoted 20 lines
Quoted 11 lines
meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb +0 -1
 }
 
 PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
--

1.8.4

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Martin 'JaMa' Jansa jabber: [email protected]

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 26 lines · [Re: [oe] [meta-networking][PATCH] inetutils: Remove empty usr/lib] On…
Quoted 12 lines · Martin Jansa
Quoted 11 lines · Khem Raj

This directory is empty and is flagged by QA checker

ERROR: QA Issue: inetutils: Files/directories were installed but not shipped
/usr/lib

---
 meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb | 2 ++
 1 file changed, 2 insertions(+)
Quoted 12 lines

meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb do_install_append () { · line 74

Quoted 10 lines
meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb +2 -0
index 7c7343e..e371ae5 100644
@@ -70,6 +70,8 @@ do_install_append () {
     cp ${WORKDIR}/telnet.xinetd.inetutils  ${D}/${sysconfdir}/xinetd.d/telnet
     cp ${WORKDIR}/tftpd.xinetd.inetutils  ${D}/${sysconfdir}/xinetd.d/tftpd
     rm -rf ${D}${libexecdir}/
+    # remove usr/lib if empty
+    rmdir ${D}${libdir}

The comment suggests missing --ignore-fail-on-non-empty

Quoted 3 lines

hmmm,I would add it when that happens and also then take opportunity to make sure that they are packaged
into right packages, so far I have not found a case where its populated.

Yep, I'm sold.

Merged.

-J.

Quoted 25 lines
Quoted 13 lines
Quoted 8 lines
meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb +0 -1
 }
 
 PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
--

1.8.4

Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 8 lines

--
Martin 'JaMa' Jansa jabber: [email protected]

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 2 lines
-Joe MacDonald.
:wq