RDMA/ocrdma: silence an integer underflow warning

PATCH New Dan Carpenter 1 participant 1 message Sep 6, 2013

Subsystems (3)

Kernel janitors InfiniBand Emulex oneconnect RoCE driver

lore

Share & tools

lore

Dan Carpenter

author

2013-09-06 08:50 UTC #0 lore raw

PATCH 1/1 RDMA/ocrdma: silence an integer underflow warning

We recently added a cap on "max_wqe_allocated" in 43a6b4025c ('RDMA/ocrdma: Create IRD queue fix').

My static checker complains that the cap has a problem because it casts large values to negative. "attrs->cap.max_send_wr" is a u32. It comes from the user, but it's capped in ocrdma_check_qp_params() so it can't wrap here.

Signed-off-by Dan Carpenter <[email protected]>

drivers/infiniband/hw/ocrdma/ocrdma_hw.c +1 -1

index 4ed8235..db39146 100644
@@ -1783,7 +1783,7 @@ static int ocrdma_set_create_qp_sq_cmd(struct ocrdma_create_qp_req *cmd,
 	u32 max_sges = attrs->cap.max_send_sge;
 
 	/* QP1 may exceed 127 */
-	max_wqe_allocated = min_t(int, attrs->cap.max_send_wr + 1,
+	max_wqe_allocated = min_t(u32, attrs->cap.max_send_wr + 1,
 				dev->attr.max_wqe);
 
 	status = ocrdma_build_q_conf(&max_wqe_allocated,