Skip to contentSkip to conversation

imx51.dtsi: fix PATA device clock

PATCH New Arnaud Patard (Rtp) 4 participants 4 messages Sep 7, 2013 – Sep 9, 2013

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 imx51.dtsi: fix PATA device clock

Minor nit: It's Steev Klimaszewski, not Steve.

Quoted 29 lines · Arnaud Patard

Commit 718a35006f3fa48540d69bd649ff76ea4cdc1ef2 adds pata support to the imx51.dtsi file and is using clock 161. The problem is that the right clock is 172, according to 5d530bb0ad84d403d1aac79a8a8acf2c2b0a8dd7. Using the clock 172 makes things work again (and kills a nasty system freeze)

Index: linux-next/arch/arm/boot/dts/imx51.dtsi
===================================================================

arch/arm/boot/dts/imx51.dtsi 2013-09-07 15:08:37.338278750 +0200 renamed from arch/arm/boot/dts/imx51.dtsi 2013-09-07 15:08:05.042280170 +0200 +1 -1
@@ -490,7 +490,7 @@
                                compatible = "fsl,imx51-pata", "fsl,imx27-pata";
                                reg = <0x83fe0000 0x4000>;
                                interrupts = <70>;
-                               clocks = <&clks 161>;
+                               clocks = <&clks 172>;
                                status = "disabled";
                        };
 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 4 lines
This e-mail and any attachments are for the sole use of the intended 
recipients(s) and may be confidential. Use of any Pwnie Express product 
signifies your agreement to the Rapid Focus Security EULA<http://pwnieexpress.com/pdfs/RFSEULA.pdf>and is subject to export controls under the U.S. Commerce Department's 
Export Administration Regulations ("EAR").
#2 lore raw

PATCH 1/1 imx51.dtsi: fix PATA device clock

In reply to Arnaud Patard (Rtp)

Hello.

On 07-09-2013 17:23, Arnaud Patard (Rtp) wrote:

Why you sent the patch as attachment?

Quoted 3 lines

Commit 718a35006f3fa48540d69bd649ff76ea4cdc1ef2 adds pata support to the imx51.dtsi file and is using clock 161. The problem is that the right clock is 172, according to 5d530bb0ad84d403d1aac79a8a8acf2c2b0a8dd7.

Please specify those commits' summaries in paren

Quoted 5 lines

Using the clock 172 makes things work again (and kills a nasty system freeze)

WBR, Sergei

#3 lore raw

PATCH 1/1 imx51.dtsi: fix PATA device clock

In reply to Arnaud Patard (Rtp)
Quoted 8 lines · Arnaud Patard

Commit 718a35006f3fa48540d69bd649ff76ea4cdc1ef2 adds pata support to the imx51.dtsi file and is using clock 161. The problem is that the right clock is 172, according to 5d530bb0ad84d403d1aac79a8a8acf2c2b0a8dd7. Using the clock 172 makes things work again (and kills a nasty system freeze)

Applied with the commit log as below.

ARM: imx51.dtsi: fix PATA device clock

Commit 718a350 (ARM: i.MX51: Add PATA support) adds pata support to the imx51.dtsi file and is using clock 161. The problem is that the right clock is 172, according to commit 5d530bb (ARM: i.MX5: Add PATA and SRTC clocks). Using the clock 172 makes things work again (and kills a nasty system freeze).

Shawn

Quoted 16 lines

Index: linux-next/arch/arm/boot/dts/imx51.dtsi
===================================================================

arch/arm/boot/dts/imx51.dtsi +1 -1
@@ -490,7 +490,7 @@
 				compatible = "fsl,imx51-pata", "fsl,imx27-pata";
 				reg = <0x83fe0000 0x4000>;
 				interrupts = <70>;
-				clocks = <&clks 161>;
+				clocks = <&clks 172>;
 				status = "disabled";
 			};