Skip to contentSkip to conversation

powerpc: export cpu_to_chip_id

PATCH In review Vladimir Murzin 2 participants 3 messages Sep 10, 2013 – Sep 11, 2013 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 powerpc: export cpu_to_chip_id

While cross-building for PPC64 I've got

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

mtip32xx refer to topology_physical_package_id, which stands for cpu_to_chip-id.

Make cpu_to_chip-id (and topology_physical_package_id) available for external users.

---
 arch/powerpc/kernel/smp.c |    1 +
 1 file changed, 1 insertion(+)
arch/powerpc/kernel/smp.c +1 -0
index 442d8e2..1d9c1c2 100644
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
 	of_node_put(np);
 	return of_get_ibm_chip_id(np);
 }
+EXPORT_SYMBOL_GPL(cpu_to_chip_id);
 
 /* Helper routines for cpu to core mapping */
 int cpu_core_index_of_thread(int cpu)
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 2 lines · Vladimir Murzin

While cross-building for PPC64 I've got

Vladimir,

Below commit ID fixes this issue.

commit 256588fda10f2a712631f8a4e72641a66adebdb8

Author: Guenter Roeck <[email protected]>
Date:   Mon Sep 9 18:37:56 2013 -0700

powerpc: Export cpu_to_chip_id() to fix build error

-Vasant

Quoted 26 lines

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

mtip32xx refer to topology_physical_package_id, which stands for cpu_to_chip-id.

Make cpu_to_chip-id (and topology_physical_package_id) available for external users.

---
  arch/powerpc/kernel/smp.c |    1 +
  1 file changed, 1 insertion(+)
arch/powerpc/kernel/smp.c +1 -0
index 442d8e2..1d9c1c2 100644
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
  	of_node_put(np);
  	return of_get_ibm_chip_id(np);
  }
+EXPORT_SYMBOL_GPL(cpu_to_chip_id);
 
  /* Helper routines for cpu to core mapping */
  int cpu_core_index_of_thread(int cpu)
#2 lore raw
Quoted 6 lines · Vasant Hegde
Quoted 2 lines · Vladimir Murzin

While cross-building for PPC64 I've got

Vladimir,

Below commit ID fixes this issue.

Great! For whatever reason I thought _GPL is default policy for exported symbols... but, never mind ;)

Sorry for the noise
Vladimir

Quoted 36 lines

commit 256588fda10f2a712631f8a4e72641a66adebdb8

Author: Guenter Roeck <[email protected]>
Date:   Mon Sep 9 18:37:56 2013 -0700

powerpc: Export cpu_to_chip_id() to fix build error

-Vasant

Quoted 26 lines

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

mtip32xx refer to topology_physical_package_id, which stands for cpu_to_chip-id.

Make cpu_to_chip-id (and topology_physical_package_id) available for external users.

---
  arch/powerpc/kernel/smp.c |    1 +
  1 file changed, 1 insertion(+)
arch/powerpc/kernel/smp.c +1 -0
index 442d8e2..1d9c1c2 100644
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
  	of_node_put(np);
  	return of_get_ibm_chip_id(np);
  }
+EXPORT_SYMBOL_GPL(cpu_to_chip_id);
 
  /* Helper routines for cpu to core mapping */
  int cpu_core_index_of_thread(int cpu)