regulator: core: Split devres code out into a separate file
Mark Brown
maintainerPATCH 1/1 regulator: core: Split devres code out into a separate file
From: Mark Brown <[email protected]>
Cut down on the size of core.c a bit more and ensure that the devres versions of things don't do too much peering inside the internals of the APIs they wrap.
--- drivers/regulator/Makefile | 2 +- drivers/regulator/core.c | 252 +------------------------------------------ drivers/regulator/devres.c | 252 +++++++++++++++++++++++++++++++++++++++++++ drivers/regulator/internal.h | 38 +++++++ 4 files changed, 292 insertions(+), 252 deletions(-) create mode 100644 drivers/regulator/devres.c create mode 100644 drivers/regulator/internal.h
drivers/regulator/Makefile +1 -1
@@ -3,7 +3,7 @@ # -obj-$(CONFIG_REGULATOR) += core.o dummy.o fixed-helper.o helpers.o +obj-$(CONFIG_REGULATOR) += core.o dummy.o fixed-helper.o helpers.o devres.o obj-$(CONFIG_OF) += of_regulator.o obj-$(CONFIG_REGULATOR_FIXED_VOLTAGE) += fixed.o obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o
drivers/regulator/core.c +1 -251
312 lines not on this page · raw message
drivers/regulator/devres.c new file +252 -0
252 lines not on this page · raw message
drivers/regulator/internal.h new file +38 -0
@@ -0,0 +1,38 @@ +/* +* internal.h -- Voltage/Current Regulator framework internal code +* +* Copyright 2007, 2008 Wolfson Microelectronics PLC. +* Copyright 2008 SlimLogic Ltd. +* +* Author: Liam Girdwood <[email protected]> +* +* This program is free software; you can redistribute it and/or modify it +* under the terms of the GNU General Public License as published by the +* Free Software Foundation; either version 2 of the License, or (at your +* option) any later version. +* +*/ + +#ifndef __REGULATOR_INTERNAL_H +#define __REGULATOR_INTERNAL_H + +/* +* struct regulator +* +* One for each consumer device. +*/ +struct regulator { +struct device *dev; +struct list_head list; +unsigned int always_on:1 ; +unsigned int bypass:1 ; +int uA_load; +int min_uV; +int max_uV; +char *supply_name; +struct device_attribute dev_attr; +struct regulator_dev *rdev; +struct dentry *debugfs; +}; + +#endif
Signature · 1 line
1.8.4.rc3
Quoted 48 lines · Mark Brown
From: Mark Brown <[email protected]>
Cut down on the size of
core.ca bit more and ensure that the devres versions of things don't do too much peering inside the internals of the APIs they wrap.Signed-off-by Mark Brown <[email protected]>--- drivers/regulator/Makefile | 2 +- drivers/regulator/core.c | 252 +------------------------------------------ drivers/regulator/devres.c | 252 +++++++++++++++++++++++++++++++++++++++++++ drivers/regulator/internal.h | 38 +++++++ 4 files changed, 292 insertions(+), 252 deletions(-) create mode 100644 drivers/regulator/devres.c create mode 100644 drivers/regulator/internal.hdrivers/regulator/internal.h new file +27
-0@@ -0,0 +1,38 @@ +/* +* internal.h -- Voltage/Current Regulator framework internal code +* +* Copyright 2007, 2008 Wolfson Microelectronics PLC. +* Copyright 2008 SlimLogic Ltd. +* +* Author: Liam Girdwood <[email protected]> +* +* This program is free software; you can redistribute it and/or modify it +* under the terms of the GNU General Public License as published by the +* Free Software Foundation; either version 2 of the License, or (at your +* option) any later version. +* +*/ + +#ifndef __REGULATOR_INTERNAL_H +#define __REGULATOR_INTERNAL_H + +/* + * struct regulator + * + * One for each consumer device. + */ +struct regulator { + struct device *dev; + struct list_head list; + unsigned int always_on:1;
drivers/regulator/internal.h line 37
Quoted 10 lines
drivers/regulator/internal.h new file +10
-0+ unsigned int bypass:1; +int uA_load; +int min_uV; +int max_uV; +char *supply_name; +struct device_attribute dev_attr; +struct regulator_dev *rdev; +struct dentry *debugfs; +}; +
don't you need any forward declaration here nor any include (like for list_head and device_attribute)?
--
Thiago
Mark Brown
maintainerQuoted 2 lines · Thiago Farina
don't you need any forward declaration here nor any include (like for
list_headanddevice_attribute)?
Probably, though all the users should have pulled in the regulator API headers.