Skip to contentSkip to conversation

xfs: remove dead code from xlog_recover_inode_pass2

PATCH In review Mark Tinguely 2 participants 2 messages Sep 12, 2013 1 message not in the archive XFS filesystem

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 xfs: remove dead code from xlog_recover_inode_pass2

Additional code in the error handler of xlog_recover_inode_pass2() results in the following error:

static checker warning: "fs/xfs/xfs_log_recover.c:2999 xlog_recover_inode_pass2()
info: ignoring unreachable code."

---
 fs/xfs/xfs_log_recover.c |    3 ---
 1 file changed, 3 deletions(-)
fs/xfs/xfs_log_recover.c +0 -3
Index: b/fs/xfs/xfs_log_recover.c
===================================================================
@@ -2995,9 +2995,6 @@ error:
 	if (need_free)
 		kmem_free(in_f);
 	return XFS_ERROR(error);
-
-	xfs_buf_relse(bp);
-	goto error;
 }
 
 /*

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#2 lore raw
Quoted 9 lines · Mark Tinguely

Additional code in the error handler of xlog_recover_inode_pass2() results in the following error:

static checker warning: "fs/xfs/xfs_log_recover.c:2999 xlog_recover_inode_pass2()
info: ignoring unreachable code."

Looks fine. Applied.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs