Skip to contentSkip to conversation

Implementing --detail-platform for DDF

DISCUSSION Martin Wilck 3 participants 5 messages Sep 11, 2013 – Sep 13, 2013 MD RAID

lore
Share & tools
lore
#0 lore raw

Hi Neil,

I thought I might come up with an implementation of mdadm --detail-platform for DDF, but I encountered a problem I'd like to discuss.

For DDF, we can't scan PCI devices like IMSM does, because we don't know all controllers supporting DDF. Thus I considered scanning block devices instead and looking at "foreign" vendor strings in the meta data; possibly also filtering by device names or types. It occured to me that it might be elegant to simply call conf_get_devs() for a list of devices to be scanned. But if I do that, config.o and its dependencies must be linked with mdmon, blowing up its size considerably. I figure that that's a no-go. But I'm also reluctant to write my own DDF-specific block device scanning code while there is conf_get_devs() already.

Perhaps I am misunderstanding the purpose of --detail-platform? I wouldn't bother with it if YaST2/libstorage didn't call it in order to check if a "fake RAID" platform is present.

Regards
Martin

#1 lore raw
Quoted 15 lines · On Wed, 11 Sep 2013 23:00:06 +0200 Martin Wilck <[email protected]> wrote:

Hi Neil,

I thought I might come up with an implementation of mdadm --detail-platform for DDF, but I encountered a problem I'd like to discuss.

For DDF, we can't scan PCI devices like IMSM does, because we don't know all controllers supporting DDF. Thus I considered scanning block devices instead and looking at "foreign" vendor strings in the meta data; possibly also filtering by device names or types. It occured to me that it might be elegant to simply call conf_get_devs() for a list of devices to be scanned. But if I do that, config.o and its dependencies must be linked with mdmon, blowing up its size considerably. I figure that that's a no-go. But I'm also reluctant to write my own DDF-specific block device scanning code while there is conf_get_devs() already.

Quoted 6 lines

Perhaps I am misunderstanding the purpose of --detail-platform? I wouldn't bother with it if YaST2/libstorage didn't call it in order to check if a "fake RAID" platform is present.

Regards
Martin

I think it would be wrong for --detail-platform to look at the contents of disk drives. If anything, it must look at the 'platform' - the controller.

If YaST2 uses --detail-platform for anything other than IMSM it is doing it wrong.
I'm currently building a virtual machine running openSUSE 13.1-M4 with DDF devices. I'll see what yast thinks of it...

NeilBrown

#2 lore raw
Quoted 21 lines · NeilBrown
Quoted 19 lines · On Wed, 11 Sep 2013 23:00:06 +0200 Martin Wilck <[email protected]> wrote:

Hi Neil,

I thought I might come up with an implementation of mdadm --detail-platform for DDF, but I encountered a problem I'd like to discuss.

For DDF, we can't scan PCI devices like IMSM does, because we don't know all controllers supporting DDF. Thus I considered scanning block devices instead and looking at "foreign" vendor strings in the meta data; possibly also filtering by device names or types. It occured to me that it might be elegant to simply call conf_get_devs() for a list of devices to be scanned. But if I do that, config.o and its dependencies must be linked with mdmon, blowing up its size considerably. I figure that that's a no-go. But I'm also reluctant to write my own DDF-specific block device scanning code while there is conf_get_devs() already.

Perhaps I am misunderstanding the purpose of --detail-platform? I wouldn't bother with it if YaST2/libstorage didn't call it in order to check if a "fake RAID" platform is present.

Quoted 7 lines
Quoted 2 lines

Regards
Martin

I think it would be wrong for --detail-platform to look at the contents of disk drives. If anything, it must look at the 'platform' - the controller.

If YaST2 uses --detail-platform for anything other than IMSM it is

doing it

Quoted 1 line

wrong.

The current libstorage logic is as follows:
1. runs mdadm --detail-platform to see if there is IMSM

    no -> 2, yes -> 3

2. start dmraid, then mdadm. -> 5
3. run mdadm -Es to derive a list of array names, and ask user if he
wants to drive these arrays with mdadm (this will look weird to the user if the array names are empty).

    no -> 2, yes -> 4

4. start mdadm, then dmraid
5. proceed with LVM etc.

Quoted 2 lines

I'm currently building a virtual machine running openSUSE 13.1-M4 with DDF devices. I'll see what yast thinks of it...

You may want to have a look at
https://build.opensuse.org/project/show/home:mwilck:mdadm-DDF:openSUSE

It contains almost-up-to-date mdadm and tentative patches for libstorage. I successfully installed both OpenSUSE 12.3 and Factory with these packages on a DUD. The libstorage patch I am using is pretty simplistic but it does the job.

Martin

#3 lore raw
In reply to Martin Wilck
Quoted 15 lines · Martin Wilck

Hi Neil,

I thought I might come up with an implementation of mdadm --detail-platform for DDF, but I encountered a problem I'd like to discuss.

For DDF, we can't scan PCI devices like IMSM does, because we don't know all controllers supporting DDF. Thus I considered scanning block devices instead and looking at "foreign" vendor strings in the meta data; possibly also filtering by device names or types. It occured to me that it might be elegant to simply call conf_get_devs() for a list of devices to be scanned. But if I do that, config.o and its dependencies must be linked with mdmon, blowing up its size considerably. I figure that that's a no-go. But I'm also reluctant to write my own DDF-specific block device scanning code while there is conf_get_devs() already.

Quoted 3 lines

Perhaps I am misunderstanding the purpose of --detail-platform? I wouldn't bother with it if YaST2/libstorage didn't call it in order to check if a "fake RAID" platform is present.

--detail-platform is more about finding the presence of the raid option-rom / firmware support. I can imagine the installer may want to confirm that an array is bootable before installing to it.

Is it enough to scan for devices that self-report as raid controllers?
Problem then becomes finding a cross-implementation method to parse
the firmware signature to detect DDF capabilities.

--
Dan

#4 lore raw
Quoted 20 lines · Dan Williams
Quoted 15 lines · Martin Wilck

Hi Neil,

I thought I might come up with an implementation of mdadm --detail-platform for DDF, but I encountered a problem I'd like to discuss.

For DDF, we can't scan PCI devices like IMSM does, because we don't know all controllers supporting DDF. Thus I considered scanning block devices instead and looking at "foreign" vendor strings in the meta data; possibly also filtering by device names or types. It occured to me that it might be elegant to simply call conf_get_devs() for a list of devices to be scanned. But if I do that, config.o and its dependencies must be linked with mdmon, blowing up its size considerably. I figure that that's a no-go. But I'm also reluctant to write my own DDF-specific block device scanning code while there is conf_get_devs() already.

Quoted 3 lines

Perhaps I am misunderstanding the purpose of --detail-platform? I wouldn't bother with it if YaST2/libstorage didn't call it in order to check if a "fake RAID" platform is present.

Quoted 7 lines

--detail-platform is more about finding the presence of the raid option-rom / firmware support. I can imagine the installer may want to confirm that an array is bootable before installing to it.

Is it enough to scan for devices that self-report as raid controllers?
Problem then becomes finding a cross-implementation method to parse
the firmware signature to detect DDF capabilities.

That'd certainly be nice to have, but I can't imagine a way how to collect these data unless the vendors contribute directly, as Intel did. For LSI I'd be able to dig up a list of PCI IDs of RAID-capable controllers, but that's about all I can think of. For other vendors I have no information.

Regards
Martin

Quoted 3 lines

--
Dan