at91: add support for CDU9G25 board
PATCH v3 1/1 at91: add support for CDU9G25 board
This patch adds support for our companies board CDU9G25 with Atmel AT91SAM9G25, 128MB DDR2, 256MB NAND.
---
v2
Fixed static IP and MAC addr cofiguration by random MAC and DHCP. Added entry to MAINTAINERS.
Fixed line lenght, trailing spaces and other cosmetics. v3
Removed static eth_gadget addresses.
MAC address set from serial number of F-RAM.
Kept CONFIG_SERVERIP as default configuration.
MAINTAINERS | 3 + board/cdu9g25/Makefile | 34 +++++++ board/cdu9g25/cdu9g25.c | 201 +++++++++++++++++++++++++++++++++++++++++ board/cdu9g25/config.mk | 1 + boards.cfg | 1 + include/configs/cdu9g25.h | 216 +++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 456 insertions(+) create mode 100644 board/cdu9g25/Makefile create mode 100644 board/cdu9g25/cdu9g25.c create mode 100644 board/cdu9g25/config.mk create mode 100644 include/configs/cdu9g25.h
MAINTAINERS +3 -0
@@ -851,6 +851,9 @@ Matt Porter <[email protected]> ti814x_evm ARM ARMV7 (TI814x Soc) +Jiri Prchal <[email protected]> + cdu9g25 ARM926EJS (AT91SAM9G25 SoC) + Dave Purdy <[email protected]> pogo_e02 ARM926EJS (Kirkwood SoC)
board/cdu9g25/Makefile new file +34 -0
@@ -0,0 +1,34 @@ +# +# U-boot - Makefile +# +# (C) Copyright 2013 +# Jiri Prchal <[email protected]> +# AK signal <www.aksignal.cz> +# +# (C) Copyright 2000-2006 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# SPDX-License-Identifier: GPL-2.0+ +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).o + +COBJS-y += cdu9g25.o + +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS-y)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) + +######################################################################### + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +#########################################################################
board/cdu9g25/cdu9g25.c new file +201 -0
201 lines not on this page · raw message
board/cdu9g25/config.mk new file +1 -0
@@ -0,0 +1 @@ +CONFIG_SYS_TEXT_BASE = 0x27f00000
boards.cfg +1 -0
@@ -77,6 +77,7 @@ integratorcp_cm926ejs arm arm926ejs integrator armltd aspenite arm arm926ejs - Marvell armada100 gplugd arm arm926ejs - Marvell armada100 afeb9260 arm arm926ejs - - at91 +cdu9g25 arm arm926ejs - - at91 at91sam9260ek_dataflash_cs0 arm arm926ejs at91sam9260ek atmel at91 at91sam9260ek:AT91SAM9260,SYS_USE_DATAFLASH_CS0 at91sam9260ek_dataflash_cs1 arm arm926ejs at91sam9260ek atmel at91 at91sam9260ek:AT91SAM9260,SYS_USE_DATAFLASH_CS1 at91sam9260ek_nandflash arm arm926ejs at91sam9260ek atmel at91 at91sam9260ek:AT91SAM9260,SYS_USE_NANDFLASH
include/configs/cdu9g25.h new file +216 -0
216 lines not on this page · raw message
--
1.7.9.5
PATCH v3 1/1 at91: add support for CDU9G25 board
Dear Jiri Prchal,
In message <[email protected]> you wrote:
...
board/cdu9g25/cdu9g25.c line 145
Quoted 5 lines
board/cdu9g25/cdu9g25.c new file +5
-0+err_spi_setup_slave: +if (!is_valid_ether_addr (sernum)) { +debug ("Using random MAC address\n" ); +eth_random_enetaddr (sernum); + }
Pleas change this debug() into a puts() [or rather a printf() and also print the value.] The user is supposed to know when something goes badly wrong and random addresses get used, and what these are.
board/cdu9g25/cdu9g25.c line 146
Quoted 1 line
board/cdu9g25/cdu9g25.c new file +1
-0+eth_setenv_enetaddr ("ethaddr" , sernum);
NAK. Here you unconditionally overwrite the MAC address, even if one is already present in the environment. This must never be done. If the user defines an address, shis shall always be respected.
Thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unser Kopf ist rund, damit das Denken die Richtung wechseln kann.
-- Francis Picabia