Skip to contentSkip to conversation

ubifs filesystem image: line up and improve Config.in options

PATCH New Thomas De Schampheleire 3 participants 3 messages Sep 8, 2013 – Sep 12, 2013 UBI file system (UBIFS)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ubifs filesystem image: line up and improve Config.in options

Triggered by the 'some comment required here', this patch updates the Config.in comments for the ubifs filesystem image options. This includes:
- 'erase block' --> 'eraseblock' (following mtd online documentation)
- remove 'UBI' prefix to make options uniform. Sometimes the option is not a property of UBI but rather of the flash. Also, line up the name of the option with the help of mkfs.ubifs.
- add help text on all options, referring to the mkfs.ubifs/ubinize options

---
 fs/ubifs/Config.in |  31 ++++++++++++++++++++-----------
 1 files changed, 20 insertions(+), 11 deletions(-)
fs/ubifs/Config.in +20 -11
@@ -6,27 +6,33 @@ config BR2_TARGET_ROOTFS_UBIFS
 if BR2_TARGET_ROOTFS_UBIFS
 
 config BR2_TARGET_ROOTFS_UBIFS_LEBSIZE
-	hex "UBI logical erase block size"
+	hex "logical eraseblock size"
 	default 0x1f800
+	help
+	  Logical eraseblock (LEB) size. The value provided here is
+	  passed to the -e/--leb-size option of mkfs.ubifs.
 
 config BR2_TARGET_ROOTFS_UBIFS_MINIOSIZE
-	hex "UBI minimum I/O size"
+	hex "minimum I/O unit size"
 	default 0x800
 	help
-	  Some comment required here
+	  Minimum I/O unit size. The value provided here is passed
+	  to the -m/--min-io-size option of mkfs.ubifs/ubinize.
 
 config BR2_TARGET_ROOTFS_UBIFS_MAXLEBCNT
-	int "Maximum LEB count"
+	int "maximum logical eraseblock count"
 	default 2048
 	help
-	  Some comment required here
+	  Maximum logical eraseblock (LEB) count. The value provided
+	  here is passed to the -c/--max-leb-cnt option of mkfs.ubifs.
 
 choice
 	prompt "ubifs runtime compression"
 	default BR2_TARGET_ROOTFS_UBIFS_RT_LZO
 	help
 	  Select which compression format to use at run-time within
-	  the ubifs file system.
+	  the ubifs file system. The choice made here is passed to
+	  the -x/--compr option of mkfs.ubifs
 
 config BR2_TARGET_ROOTFS_UBIFS_RT_NONE
 	bool "no compression"
@@ -97,18 +103,21 @@ config BR2_TARGET_ROOTFS_UBI
 if BR2_TARGET_ROOTFS_UBI
 
 config BR2_TARGET_ROOTFS_UBI_PEBSIZE
-	hex "UBI physical erase block size"
+	hex "physical eraseblock size"
 	default 0x20000
 	help
-	  Tells ubinize the physical eraseblock size of the flash chip
-	  the ubi image is created for.
+	  Tells ubinize the physical eraseblock (PEB) size of the
+	  flash chip the ubi image is created for. The value provided
+	  here is passed to the -p/--peb-size option of ubinize.
 
 config BR2_TARGET_ROOTFS_UBI_SUBSIZE
-	int "UBI sub-page size"
+	int "sub-page size"
 	default 512
 	help
 	  Tells ubinize that the flash supports sub-pages and the sub-page
-	  size. Use 0 if subpages are not supported on flash chip.
+	  size. Use 0 if sub-pages are not supported on flash chip.
+	  The value provided here is passed to the -s/--sub-page-size
+	  option of ubinize.
 
 config BR2_TARGET_ROOTFS_UBI_OPTS
 	string "Additional ubinize options"
#1 lore raw

PATCH 1/1 ubifs filesystem image: line up and improve Config.in options

Dear Thomas De Schampheleire,

Quoted 9 lines · Thomas De Schampheleire

Triggered by the 'some comment required here', this patch updates the Config.in comments for the ubifs filesystem image options. This includes:
- 'erase block' --> 'eraseblock' (following mtd online documentation)
- remove 'UBI' prefix to make options uniform. Sometimes the option is not a property of UBI but rather of the flash. Also, line up the name of the option with the help of mkfs.ubifs.
- add help text on all options, referring to the mkfs.ubifs/ubinize options

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 ubifs filesystem image: line up and improve Config.in options

In reply to Thomas De Schampheleire
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

Thomas> Triggered by the 'some comment required here', this patch updates the Config.in Thomas> comments for the ubifs filesystem image options. This includes:
Thomas> - 'erase block' --> 'eraseblock' (following mtd online documentation) Thomas> - remove 'UBI' prefix to make options uniform. Sometimes the option is not a
Thomas> property of UBI but rather of the flash. Also, line up the name of the option
Thomas> with the help of mkfs.ubifs.
Thomas> - add help text on all options, referring to the mkfs.ubifs/ubinize options

Thomas> Signed-off-by: Thomas De Schampheleire <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard