Skip to contentSkip to conversation

Staging: Remove a few superfluous braces

PATCH In review Sean Williams 3 participants 3 messages Sep 7, 2013 – Sep 12, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: Remove a few superfluous braces

Please don't flame me :) I'm getting my feet wet with kernel contribution.
One example I saw in a video by GKH suggested cleaning up coding style as a good first commit.

---
 drivers/staging/comedi/drivers/ni_at_a2150.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/ni_at_a2150.c +3 -4
index 2512ce8..c77d343 100644
@@ -684,13 +684,12 @@ static int a2150_set_chanlist(struct comedi_device *dev,
 		devpriv->config_bits |= CHANNEL_BITS(0x4 | start_channel);
 		break;
 	case 2:
-		if (start_channel == 0) {
+		if (start_channel == 0)
 			devpriv->config_bits |= CHANNEL_BITS(0x2);
-		} else if (start_channel == 2) {
+		else if (start_channel == 2)
 			devpriv->config_bits |= CHANNEL_BITS(0x3);
-		} else {
+		else
 			return -1;
-		}
 		break;
 	case 4:
 		devpriv->config_bits |= CHANNEL_BITS(0x1);
Signature · 1 line
1.8.1.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Sean Williams

Please don't flame me :) I'm getting my feet wet with kernel contribution.
One example I saw in a video by GKH suggested cleaning up coding style as a good first commit.

Fair enough.

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
maintainer
#2 lore raw

Re: [PATCH] Staging: comedi: ni_at_a2150: Remove a few superfluous braces

In reply to Sean Williams
Quoted 1 line · Sean Williams

Please don't flame me :) I'm getting my feet wet with kernel contribution.

Why would we flame anyone for sending us patches?

It's as if we are bunch of scary people or something...

Nice job with this, I'll queue it up after 3.12-rc1 is out.

thanks,

greg k-h