netfilter: ipv6: icmpv6_manip_pkt comparing codes to types
Subsystems (2)
PATCH 1/1 netfilter: ipv6: icmpv6_manip_pkt comparing codes to types
In commit 58a317f1 (netfilter: ipv6: add IPv6 NAT support), icmpv6_manip_pkt was added with an incorrect comparison of ICMP codes to types. This causes problems when using NAT rules with the --random option. Correct the comparison.
This closes netfilter bugzilla #851, reported by Alexander Neumann.
Signed-off-by Phil Oester <[email protected]>
net/ipv6/netfilter/nf_nat_proto_icmpv6.c +2 -2
@@ -69,8 +69,8 @@ icmpv6_manip_pkt(struct sk_buff *skb, hdr = (struct icmp6hdr *)(skb->data + hdroff); l3proto->csum_update (skb, iphdroff, &hdr->icmp6_cksum, tuple, maniptype); -if (hdr->icmp6_code ==ICMPV6_ECHO_REQUEST || - hdr->icmp6_code ==ICMPV6_ECHO_REPLY ) { +if (hdr->icmp6_type ==ICMPV6_ECHO_REQUEST || + hdr->icmp6_type ==ICMPV6_ECHO_REPLY ) {inet_proto_csum_replace2 (&hdr->icmp6_cksum, skb, hdr->icmp6_identifier, tuple->src.u.icmp.id,0 );
Quoted 6 lines · Phil Oester
In commit
58a317f1(netfilter: ipv6: add IPv6 NAT support),icmpv6_manip_pktwas added with an incorrect comparison of ICMP codes to types. This causes problems when using NAT rules with the --random option. Correct the comparison.This closes netfilter bugzilla #851, reported by Alexander Neumann.
Applied, thanks Phil.