ASoC: max98095: a couple array underflows
Subsystems (3)
PATCH 1/1 ASoC: max98095: a couple array underflows
The ->put() function are called from snd_ctl_elem_write() with user supplied data. The limit checks here could underflow leading to a crash.
Signed-off-by Dan Carpenter <[email protected]>
sound/soc/codecs/max98095.c +2 -2
@@ -1863,7 +1863,7 @@ static int max98095_put_eq_enum(struct snd_kcontrol *kcontrol,struct max98095_pdata *pdata = max98095->pdata;int channel =max98095_get_eq_channel (kcontrol->id.name);struct max98095_cdata *cdata; -int sel = ucontrol->value.integer.value[0 ]; +unsigned int sel = ucontrol->value.integer.value[0 ];struct max98095_eq_cfg *coef_set;int fs, best, best_val, i;int regmask, regsave;
@@ -2016,7 +2016,7 @@ static int max98095_put_bq_enum(struct snd_kcontrol *kcontrol,struct max98095_pdata *pdata = max98095->pdata;int channel =max98095_get_bq_channel (codec, kcontrol->id.name);struct max98095_cdata *cdata; -int sel = ucontrol->value.integer.value[0 ]; +unsigned int sel = ucontrol->value.integer.value[0 ];struct max98095_biquad_cfg *coef_set;int fs, best, best_val, i;int regmask, regsave;
Quoted 3 lines · Dan Carpenter
The ->put() function are called from
snd_ctl_elem_write()with user supplied data. The limit checks here could underflow leading to a crash.
Applied, thanks.