Skip to contentSkip to conversation

ASoC: 88pm860x: array overflow in snd_soc_put_volsw_2r_st()

PATCH Applied Dan Carpenter 2 participants 2 messages Sep 13, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: 88pm860x: array overflow in snd_soc_put_volsw_2r_st()

This is called from snd_ctl_elem_write() with user supplied data so we need to add some bounds checking.

sound/soc/codecs/88pm860x-codec.c +3 -0
index 8af0434..259d1ac 100644
@@ -349,6 +349,9 @@ static int snd_soc_put_volsw_2r_st(struct snd_kcontrol *kcontrol,
 	val = ucontrol->value.integer.value[0];
 	val2 = ucontrol->value.integer.value[1];
 
+	if (val >= ARRAY_SIZE(st_table) || val2 >= ARRAY_SIZE(st_table))
+		return -EINVAL;
+
 	err = snd_soc_update_bits(codec, reg, 0x3f, st_table[val].m);
 	if (err < 0)
 		return err;
maintainer Applied
#1 lore raw
Quoted 2 lines · Dan Carpenter

This is called from snd_ctl_elem_write() with user supplied data so we need to add some bounds checking.

Applied, thanks.