Skip to contentSkip to conversation

skd: remove unneeded NULL check

PATCH In review Dan Carpenter 1 participant 1 message Sep 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 4/4 skd: remove unneeded NULL check

We already dereferenced "skdev" a few lines earlier in the debug code so my static checker complains. I audited the callers and "skdev" is never NULL here so I have removed the check.

drivers/block/skd_main.c +1 -1
index 20ad843..827f927 100644
@@ -2909,7 +2909,7 @@ static void skd_do_inq_page_da(struct skd_device *skdev,
 
 	inq.page_code = DRIVER_INQ_EVPD_PAGE_CODE;
 
-	if (skdev && skdev->pdev && skdev->pdev->bus) {
+	if (skdev->pdev && skdev->pdev->bus) {
 		skd_get_link_info(skdev->pdev,
 				  &inq.pcie_link_speed, &inq.pcie_link_lanes);
 		inq.pcie_bus_number = cpu_to_be16(skdev->pdev->bus->number);