Skip to contentSkip to conversation

video/matrox/matroxfb_maven: Use module_i2c_driver to register driver

PATCH In review Jean Delvare 2 participants 2 messages Sep 13, 2013 – Sep 16, 2013 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 video/matrox/matroxfb_maven: Use module_i2c_driver to register driver

From: Peter Huewe <[email protected]>

Removing some boilerplate by using module_i2c_driver instead of calling register and unregister in the otherwise empty init/exit functions. Also removed a useless comment as suggested by Jean Delvare.

Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Tomi Valkeinen <[email protected]>

---
Looks like this patch got lost so I am resending it.

 drivers/video/matrox/matroxfb_maven.c |   14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
drivers/video/matrox/matroxfb_maven.c +1 -13
@@ -1295,19 +1295,7 @@ static struct i2c_driver maven_driver={
 	.id_table	= maven_id,
 };
 
-static int __init matroxfb_maven_init(void)
-{
-	return i2c_add_driver(&maven_driver);
-}
-
-static void __exit matroxfb_maven_exit(void)
-{
-	i2c_del_driver(&maven_driver);
-}
-
+module_i2c_driver(maven_driver);
 MODULE_AUTHOR("(c) 1999-2002 Petr Vandrovec <[email protected]>");
 MODULE_DESCRIPTION("Matrox G200/G400 Matrox MGA-TVO driver");
 MODULE_LICENSE("GPL");
-module_init(matroxfb_maven_init);
-module_exit(matroxfb_maven_exit);
-/* we do not have __setup() yet */
Signature · 1 line
Jean Delvare
#1 lore raw
Quoted 6 lines · Jean Delvare

From: Peter Huewe <[email protected]>

Removing some boilerplate by using module_i2c_driver instead of calling register and unregister in the otherwise empty init/exit functions. Also removed a useless comment as suggested by Jean Delvare.

Quoted 7 lines
Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Tomi Valkeinen <[email protected]>

---
Looks like this patch got lost so I am resending it.

Thanks, applying for 3.13.

Tomi