Skip to contentSkip to conversation

arm64: KVM: Increase max VCPUs per-Guest to 8

PATCH New Anup Patel 3 participants 6 messages Sep 11, 2013 – Sep 14, 2013

Subsystems (2)
lore
Share & tools
lore

Anup Patel

author
#0 lore raw

PATCH 1/1 arm64: KVM: Increase max VCPUs per-Guest to 8

Current max VCPUs per-Guest is set to 4 which is preventing us from creating a Guest (or VM) with 8 VCPUs on Host (e.g. X-Gene Storm SOC) with 8 Host CPUs.

The correct value of max VCPUs per-Guest should be same as the max CPUs supported by GICv2 which is 8 hence this patch increases KVM_MAX_VCPUS to 8.

---
 arch/arm64/include/asm/kvm_host.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/include/asm/kvm_host.h +1 -1
index 0859a4d..60ef29e 100644
@@ -26,7 +26,7 @@
 #include <asm/kvm_asm.h>
 #include <asm/kvm_mmio.h>
 
-#define KVM_MAX_VCPUS 4
+#define KVM_MAX_VCPUS 8
 #define KVM_USER_MEM_SLOTS 32
 #define KVM_PRIVATE_MEM_SLOTS 4
 #define KVM_COALESCED_MMIO_PAGE_OFFSET 1
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 arm64: KVM: Increase max VCPUs per-Guest to 8

Quoted 7 lines · Anup Patel

Current max VCPUs per-Guest is set to 4 which is preventing us from creating a Guest (or VM) with 8 VCPUs on Host (e.g. X-Gene Storm SOC) with 8 Host CPUs.

The correct value of max VCPUs per-Guest should be same as the max CPUs supported by GICv2 which is 8 hence this patch increases KVM_MAX_VCPUS to 8.

If anything, please make it configurable just like we have on 32bit. No reason to impose the extra overhead on everyone.

Thanks,

	M.
Quoted 20 lines
---
 arch/arm64/include/asm/kvm_host.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/include/asm/kvm_host.h +1 -1
index 0859a4d..60ef29e 100644
@@ -26,7 +26,7 @@
 #include <asm/kvm_asm.h>
 #include <asm/kvm_mmio.h>
 
-#define KVM_MAX_VCPUS 4
+#define KVM_MAX_VCPUS 8
 #define KVM_USER_MEM_SLOTS 32
 #define KVM_PRIVATE_MEM_SLOTS 4
 #define KVM_COALESCED_MMIO_PAGE_OFFSET 1
Signature · 1 line
Jazz is not dead. It just smells funny...
#2 lore raw

PATCH 1/1 arm64: KVM: Increase max VCPUs per-Guest to 8

Quoted 11 lines · Marc Zyngier
Quoted 7 lines · Anup Patel

Current max VCPUs per-Guest is set to 4 which is preventing us from creating a Guest (or VM) with 8 VCPUs on Host (e.g. X-Gene Storm SOC) with 8 Host CPUs.

The correct value of max VCPUs per-Guest should be same as the max CPUs supported by GICv2 which is 8 hence this patch increases KVM_MAX_VCPUS to 8.

If anything, please make it configurable just like we have on 32bit. No reason to impose the extra overhead on everyone.

I have a couple patches I've been meaning to post, one of which does this. I'll get them posted now.

drew

Quoted 35 lines

Thanks,

	M.
Quoted 20 lines
---
 arch/arm64/include/asm/kvm_host.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/include/asm/kvm_host.h +1 -1
index 0859a4d..60ef29e 100644
@@ -26,7 +26,7 @@
 #include <asm/kvm_asm.h>
 #include <asm/kvm_mmio.h>
 
-#define KVM_MAX_VCPUS 4
+#define KVM_MAX_VCPUS 8
 #define KVM_USER_MEM_SLOTS 32
 #define KVM_PRIVATE_MEM_SLOTS 4
 #define KVM_COALESCED_MMIO_PAGE_OFFSET 1
Signature · 7 lines
Jazz is not dead. It just smells funny...


_______________________________________________
kvmarm mailing list
kvmarm at lists.cs.columbia.edu
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
#3 lore raw

PATCH 1/1 arm64: KVM: Increase max VCPUs per-Guest to 8

In reply to Marc Zyngier
Quoted 11 lines · Marc Zyngier
Quoted 7 lines · Anup Patel

Current max VCPUs per-Guest is set to 4 which is preventing us from creating a Guest (or VM) with 8 VCPUs on Host (e.g. X-Gene Storm SOC) with 8 Host CPUs.

The correct value of max VCPUs per-Guest should be same as the max CPUs supported by GICv2 which is 8 hence this patch increases KVM_MAX_VCPUS to 8.

If anything, please make it configurable just like we have on 32bit. No reason to impose the extra overhead on everyone.

What type of overhead are we talking about? Memory, right? as kvm_for_each_vcpu is almost always used when iterating. But Anup says in his v2 of this patch "can make things slower". If it's memory, then is so much consumed by each vcpu that we shouldn't always set KVM_MAX_VCPUS to at least the highest number that current hardware supports? Particularly for aarch64 I think we should always be considering multi-platform with the kernel configs.

drew

Quoted 35 lines

Thanks,

	M.
Quoted 20 lines
---
 arch/arm64/include/asm/kvm_host.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/include/asm/kvm_host.h +1 -1
index 0859a4d..60ef29e 100644
@@ -26,7 +26,7 @@
 #include <asm/kvm_asm.h>
 #include <asm/kvm_mmio.h>
 
-#define KVM_MAX_VCPUS 4
+#define KVM_MAX_VCPUS 8
 #define KVM_USER_MEM_SLOTS 32
 #define KVM_PRIVATE_MEM_SLOTS 4
 #define KVM_COALESCED_MMIO_PAGE_OFFSET 1
Signature · 7 lines
Jazz is not dead. It just smells funny...


_______________________________________________
kvmarm mailing list
kvmarm at lists.cs.columbia.edu
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
#4 lore raw

PATCH 1/1 arm64: KVM: Increase max VCPUs per-Guest to 8

Quoted 10 lines · Andrew Jones
Quoted 9 lines · Marc Zyngier
Quoted 7 lines · Anup Patel

Current max VCPUs per-Guest is set to 4 which is preventing us from creating a Guest (or VM) with 8 VCPUs on Host (e.g. X-Gene Storm SOC) with 8 Host CPUs.

The correct value of max VCPUs per-Guest should be same as the max CPUs supported by GICv2 which is 8 hence this patch increases KVM_MAX_VCPUS to 8.

Quoted 5 lines
Quoted 3 lines

If anything, please make it configurable just like we have on 32bit. No
reason to impose the extra overhead on everyone.

What type of overhead are we talking about? Memory, right? as

Memory indeed.

Quoted 5 lines

kvm_for_each_vcpu is almost always used when iterating. But Anup says in
his v2 of this patch "can make things slower". If it's memory, then is so
much consumed by each vcpu that we shouldn't always set KVM_MAX_VCPUS

Not only. See how the GIC emulation also has per-VCPU data, and this results in potentially huge data structures. I have plans to address this in the future though.

Quoted 5 lines

to at least the highest number that current hardware supports? Particularly
for aarch64 I think we should always be considering multi-platform with the
kernel configs.

What do you mean by multiplatform? This constant has nothing to do with being multiplatform, and the initial commit message was quite misleading in this respect. You can perfectly have 8 VCPUs on a single CPU host, and nothing so far impacts multiplatform.

The limit of 8 VCPUs has to do with a GICv2 limitation, which we emulate for the guest. Once we'll have GICv3 support in the kernel, this limit will be lifted.

         M.
Signature · 1 line
Fast, cheap, reliable. Pick two.
#5 lore raw

PATCH 1/1 arm64: KVM: Increase max VCPUs per-Guest to 8

Quoted 35 lines · Marc Zyngier
Quoted 10 lines · Andrew Jones
Quoted 9 lines · Marc Zyngier
Quoted 7 lines · Anup Patel

Current max VCPUs per-Guest is set to 4 which is preventing us from creating a Guest (or VM) with 8 VCPUs on Host (e.g. X-Gene Storm SOC) with 8 Host CPUs.

The correct value of max VCPUs per-Guest should be same as the max CPUs supported by GICv2 which is 8 hence this patch increases KVM_MAX_VCPUS to 8.

Quoted 5 lines
Quoted 3 lines

If anything, please make it configurable just like we have on 32bit. No
reason to impose the extra overhead on everyone.

What type of overhead are we talking about? Memory, right? as

Memory indeed.

Quoted 5 lines

kvm_for_each_vcpu is almost always used when iterating. But Anup says in
his v2 of this patch "can make things slower". If it's memory, then is so
much consumed by each vcpu that we shouldn't always set KVM_MAX_VCPUS

Not only. See how the GIC emulation also has per-VCPU data, and this results in potentially huge data structures. I have plans to address this in the future though.

Quoted 5 lines

to at least the highest number that current hardware supports? Particularly
for aarch64 I think we should always be considering multi-platform with the
kernel configs.

Quoted 4 lines

What do you mean by multiplatform? This constant has nothing to do with being multiplatform, and the initial commit message was quite misleading in this respect. You can perfectly have 8 VCPUs on a single CPU host, and nothing so far impacts multiplatform.

I meant compile the kernel once, but still have it useful on multiple hosts (some with 4 cpus, some with 8...). Of course with config option that's still possible, just compile with CONFIG_KVM_MAX_VCPUS=8. So I guess this is really more of a debate about what the default should be. Considering the GIC code may be a bit of an over-consumer at the moment and 8-cpu hosts may not be that widely deployed, then maybe 4 is the better default right now?

drew