ARM: shmobile: Extend SCU CPU notifier to handle CPUIdle

PATCH New Magnus Damm 1 participant 1 message Sep 14, 2013

Subsystems (4)

Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture

lore

Share & tools

lore

Magnus Damm

author maintainer

2013-09-14 14:15 UTC #0 lore raw

PATCH 1/2 ARM: shmobile: Extend SCU CPU notifier to handle CPUIdle

From: Magnus Damm <[email protected]>

Not-Yet-Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/platsmp-scu.c |   21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

arch/arm/mach-shmobile/platsmp-scu.c +18 -3

@@ -22,12 +22,27 @@ static int shmobile_smp_scu_notifier_cal
 {
 	unsigned int cpu = (long)hcpu;
 
+	/* During SMP boot and for CPU Hotplug, use CPU_UP_PREPARE
+	 * to register boot vector. Runtime CPU power management
+	 * via a separate CPUIdle driver requires a different boot
+	 * vector which is installed at CPU_ONLINE time.
+	 */
+
 	switch (action) {
 	case CPU_UP_PREPARE:
 		/* For this particular CPU register SCU SMP boot vector */
 		shmobile_smp_hook(cpu, virt_to_phys(shmobile_boot_scu),
 				  (unsigned long)shmobile_scu_base);
 		break;
+ 	case CPU_UP_CANCELED:
+ 	case CPU_POST_DEAD:
+		/* Unregister boot vector */
+		shmobile_smp_hook(cpu, 0, 0);
+ 		break;
+ 	case CPU_ONLINE:
+		/* Register CPUIdle boot vector */
+		shmobile_smp_hook(cpu, virt_to_phys(cpu_resume), 0);
+ 		break;
 	};
 
 	return NOTIFY_OK;

@@ -49,14 +64,14 @@ void __init shmobile_smp_scu_prepare_cpu
 
 	/* Use CPU notifier for reset vector control */
 	register_cpu_notifier(&shmobile_smp_scu_notifier);
+
+	/* Make sure boot CPU also gets CPUIdle initialized */
+	shmobile_smp_scu_notifier_call(NULL, CPU_ONLINE, 0);
 }
 
 #ifdef CONFIG_HOTPLUG_CPU
 void shmobile_smp_scu_cpu_die(unsigned int cpu)
 {
-	/* For this particular CPU deregister boot vector */
-	shmobile_smp_hook(cpu, 0, 0);
-
 	dsb();
 	flush_cache_all();