Skip to contentSkip to conversation

BLK_TN_PROCESS events not delivered for all devices

DISCUSSION Jan Kara 2 participants 5 messages Sep 16, 2013 – Sep 17, 2013

lore
Share & tools
lore

Jan Kara

author
#0 lore raw

Hi,

I've been looking into a problem where BLK_TN_PROCESS events are not
delivered to all devices which are being traced. This results in process name being (null) when trace for a single device is parsed.

The reason for this problem is that trace_note_tsk() is called only if tsk->btrace_seq != blktrace_seq and it updates tsk->btrace_seq to blktrace_seq. Thus after a trace for another device is started BLK_TN_PROCESS event is sent only on behalf of the first device with which the task interacts. That isn't necessarily the new device thus traces for some devices accumulate several BLK_TN_PROCESS events for one task while other have none. Is this a known problem and is this intended to work better?

I was thinking how to fix that for a while and it doesn't seem to be possible without tracking with each block trace which tasks it has been notified about. And that is relatively expensive...

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#1 lore raw
Quoted 15 lines · Jan Kara

Hi,

I've been looking into a problem where BLK_TN_PROCESS events are not
delivered to all devices which are being traced. This results in process name being (null) when trace for a single device is parsed.

The reason for this problem is that trace_note_tsk() is called only if tsk->btrace_seq != blktrace_seq and it updates tsk->btrace_seq to blktrace_seq. Thus after a trace for another device is started BLK_TN_PROCESS event is sent only on behalf of the first device with which the task interacts. That isn't necessarily the new device thus traces for some devices accumulate several BLK_TN_PROCESS events for one task while other have none. Is this a known problem and is this intended to work better?

Quoted 3 lines

I was thinking how to fix that for a while and it doesn't seem to be possible without tracking with each block trace which tasks it has been notified about. And that is relatively expensive...

It is unfortunately a known issue... I have not come up with a good way to fix it either, while keeping it cheap. So if you think of something, do let me know.

Signature · 1 line
Jens Axboe
author
#2 lore raw
Quoted 16 lines · Jens Axboe
Quoted 15 lines · Jan Kara

Hi,

I've been looking into a problem where BLK_TN_PROCESS events are not
delivered to all devices which are being traced. This results in process name being (null) when trace for a single device is parsed.

The reason for this problem is that trace_note_tsk() is called only if tsk->btrace_seq != blktrace_seq and it updates tsk->btrace_seq to blktrace_seq. Thus after a trace for another device is started BLK_TN_PROCESS event is sent only on behalf of the first device with which the task interacts. That isn't necessarily the new device thus traces for some devices accumulate several BLK_TN_PROCESS events for one task while other have none. Is this a known problem and is this intended to work better?

Quoted 7 lines
Quoted 3 lines

I was thinking how to fix that for a while and it doesn't seem to be possible without tracking with each block trace which tasks it has been notified about. And that is relatively expensive...

It is unfortunately a known issue... I have not come up with a good way to fix it either, while keeping it cheap. So if you think of something, do let me know.

Hum... How about linking all running block traces (struct blk_trace) in a
linked list and sending BLK_TN_PROCESS to all the traces? Sure we will be spamming with BLK_TN_PROCESS a bit but starting a trace isn't such a common thing so it shouldn't be too bad. What do you think?

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#3 lore raw
Quoted 21 lines · Jan Kara
Quoted 20 lines · Jens Axboe
Quoted 18 lines · Jan Kara

Hi,

I've been looking into a problem where BLK_TN_PROCESS events are not
delivered to all devices which are being traced. This results in process name being (null) when trace for a single device is parsed.

The reason for this problem is that trace_note_tsk() is called only if tsk->btrace_seq != blktrace_seq and it updates tsk->btrace_seq to blktrace_seq. Thus after a trace for another device is started BLK_TN_PROCESS event is sent only on behalf of the first device with which the task interacts. That isn't necessarily the new device thus traces for some devices accumulate several BLK_TN_PROCESS events for one task while other have none. Is this a known problem and is this intended to work better?

I was thinking how to fix that for a while and it doesn't seem to be possible without tracking with each block trace which tasks it has been notified about. And that is relatively expensive...

Quoted 7 lines
Quoted 3 lines

It is unfortunately a known issue... I have not come up with a good way to fix it either, while keeping it cheap. So if you think of something, do let me know.

Hum... How about linking all running block traces (struct blk_trace) in a
linked list and sending BLK_TN_PROCESS to all the traces? Sure we will be spamming with BLK_TN_PROCESS a bit but starting a trace isn't such a common thing so it shouldn't be too bad. What do you think?

That might be good enough. I'm not worried about start/stop type expenses, those things generally don't matter. And the list wont add any fast path overhead when tracing.

Signature · 1 line
Jens Axboe
author
#4 lore raw
Quoted 25 lines · Jens Axboe
Quoted 24 lines · Jan Kara
Quoted 23 lines · Jens Axboe
Quoted 15 lines · Jan Kara

Hi,

I've been looking into a problem where BLK_TN_PROCESS events are not
delivered to all devices which are being traced. This results in process name being (null) when trace for a single device is parsed.

The reason for this problem is that trace_note_tsk() is called only if tsk->btrace_seq != blktrace_seq and it updates tsk->btrace_seq to blktrace_seq. Thus after a trace for another device is started BLK_TN_PROCESS event is sent only on behalf of the first device with which the task interacts. That isn't necessarily the new device thus traces for some devices accumulate several BLK_TN_PROCESS events for one task while other have none. Is this a known problem and is this intended to work better?

Quoted 3 lines

I was thinking how to fix that for a while and it doesn't seem to be possible without tracking with each block trace which tasks it has been notified about. And that is relatively expensive...

It is unfortunately a known issue... I have not come up with a good way to fix it either, while keeping it cheap. So if you think of something, do let me know.

Quoted 8 lines
Quoted 4 lines

Hum... How about linking all running block traces (struct blk_trace) in a
linked list and sending BLK_TN_PROCESS to all the traces? Sure we will be spamming with BLK_TN_PROCESS a bit but starting a trace isn't such a common thing so it shouldn't be too bad. What do you think?

That might be good enough. I'm not worried about start/stop type expenses, those things generally don't matter. And the list wont add any fast path overhead when tracing.

OK, I've sent you a patch which does the trick for me.

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR