Skip to contentSkip to conversation

ARM: ux500: disable outer cache debug

PATCH New Linus Walleij 3 participants 3 messages Sep 16, 2013 – Sep 17, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: ux500: disable outer cache debug

This fixes a multiplatform regression on the Ux500.

When compiling the Ux500 platforms in multiplatform configurations both PL310_ERRATA_588369 and PL310_ERRATA_727915 would crash the platform when trying to launch the init process.

The Ux500 cannot access the debug registers of the PL310, it will just crash if you try this. So disable this by setting the debug callback to NULL when initializing the l2x0 on this platform.

---
Hi ARM SoC folks: this (hopefully) fixes the bug that made Snowball (and other Ux500) not boot properly on multi_v7. Please apply this patch directly to your fixes branch if you're happy with it.

---
 arch/arm/mach-ux500/cache-l2x0.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-ux500/cache-l2x0.c +1 -0
index 82ccf1d..264f894 100644
@@ -69,6 +69,7 @@ static int __init ux500_l2x0_init(void)
 	 * some SMI service available.
 	 */
 	outer_cache.disable = NULL;
+	outer_cache.set_debug = NULL;
 
 	return 0;
 }
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 ARM: ux500: disable outer cache debug

Quoted 10 lines · Linus Walleij

This fixes a multiplatform regression on the Ux500.

When compiling the Ux500 platforms in multiplatform configurations both PL310_ERRATA_588369 and PL310_ERRATA_727915 would crash the platform when trying to launch the init process.

The Ux500 cannot access the debug registers of the PL310, it will just crash if you try this. So disable this by setting the debug callback to NULL when initializing the l2x0 on this platform.

Quoted 7 lines

---
Hi ARM SoC folks: this (hopefully) fixes the bug that made Snowball (and other Ux500) not boot properly on multi_v7. Please apply this patch directly to your fixes branch if you're happy with it.

Thanks, applied. As mentioned elsewhere, this plus the DTB_COMPAT config change makes multi_v7_defconfig bootable on snowball.

-Olof

#2 lore raw

PATCH 1/1 ARM: ux500: disable outer cache debug

Quoted 19 lines · Olof Johansson
Quoted 10 lines · Linus Walleij

This fixes a multiplatform regression on the Ux500.

When compiling the Ux500 platforms in multiplatform configurations both PL310_ERRATA_588369 and PL310_ERRATA_727915 would crash the platform when trying to launch the init process.

The Ux500 cannot access the debug registers of the PL310, it will just crash if you try this. So disable this by setting the debug callback to NULL when initializing the l2x0 on this platform.

Quoted 7 lines

---
Hi ARM SoC folks: this (hopefully) fixes the bug that made Snowball (and other Ux500) not boot properly on multi_v7. Please apply this patch directly to your fixes branch if you're happy with it.

Quoted 2 lines

Thanks, applied. As mentioned elsewhere, this plus the DTB_COMPAT config change makes multi_v7_defconfig bootable on snowball.

\o/

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog