mvebu: Armada XP doesn't boot in v3.12-rc1
Hi Jason,
Armada XP boards are not booting in v3.12-rc1.
These two patches, which are already in linux-mvebu/mvebu/dt, are needed to fix the problem:
commit 585b136b73696ac37c9614b4b3d8fa0407adcdf1
Author: Ezequiel Garcia <[email protected]> Date: Tue Aug 20 12:45:51 2013 -0300
ARM: mvebu: Add clock properties to Armada XP timer node
commit d36fd447d5e2d0993a8ec34afc26fc449ac1e2f3
Author: Ezequiel Garcia <[email protected]> Date: Tue Aug 20 12:45:50 2013 -0300
ARM: mvebu: Add the reference 25 MHz fixed-clock to Armada XP
---
FWIW, CONFIG_HAVE_ARM_ARCH_TIMER=y is also needed or the board freezes, but that's another problem which I'm currently investigating.
Can you push the above two to be included in v3.12-rc1 or do you need anything else from me?
Thanks and sorry for the crap,
Signature · 3 lines
Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com
Ezequiel!
Quoted 9 lines · Ezequiel Garcia
Armada XP boards are not booting in v3.12-rc1.
These two patches, which are already in linux-mvebu/mvebu/dt, are needed to fix the problem:
commit
585b136b73696ac37c9614b4b3d8fa0407adcdf1Author: Ezequiel Garcia <[email protected]> Date: Tue Aug 20 12:45:51 2013 -0300
Quoted 7 lines
ARM: mvebu: Add clock properties to Armada XP timer node
commit
d36fd447d5e2d0993a8ec34afc26fc449ac1e2f3Author: Ezequiel Garcia <[email protected]> Date: Tue Aug 20 12:45:50 2013 -0300ARM: mvebu: Add the reference 25 MHz fixed-clock to Armada XP
Yes, I saw that tglx sent a late pull for corresponding driver changes. I'll move these two over to mvebu/fixes shortly.
Quoted 2 lines
FWIW,
CONFIG_HAVE_ARM_ARCH_TIMER=yis also needed or the board freezes, but that's another problem which I'm currently investigating.
Sounds like we just need a select, is there something more to it?
Please send a patch as soon as you have it nailed down. I'd like the two changes above and this patch to spend a few days in -next before I send the pull.
Quoted 2 lines
Can you push the above two to be included in v3.12-rc1 or do you need anything else from me?
Nope, confirmation of boards failing to boot is all I need to move these over for v3.12.
thx,
Jason.
Quoted 1 line · Jason Cooper
On Tue, Sep 17, 2013 at 02:35:03PM -0300, Ezequiel Garcia wrote:
[...]
Quoted 6 lines
Quoted 3 lines
FWIW,
CONFIG_HAVE_ARM_ARCH_TIMER=yis also needed or the board freezes, but that's another problem which I'm currently investigating.Sounds like we just need a select, is there something more to it?
I've no idea!
Let me spend some time bisecting the problem and see if we can come up with something smarter.
I'm not sure, but I can't see why a non architected timer kernel wouldn't work.
Let's add Stephen Boyd in Cc, in case he has some idea.
Stephen: when v3.12-rc1 boots with CONFIG_HAVE_ARM_ARCH_TIMER=n (the default) the kernel freezes at the typical:
l2x0: 32 ways, CACHE_ID 0x00000100, AUX_CTRL 0x1a69ef12, Cache size: 2048 kB
sched_clock: 32 bits at 100 Hz, resolution 10000000ns, wraps every 4294967286ms
Console: colour dummy device 80x30
Calibrating delay loop...
Signature · 3 lines
Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com
Hi Jason,
Quoted 21 lines · Jason Cooper
Quoted 9 lines · Ezequiel Garcia
Armada XP boards are not booting in v3.12-rc1.
These two patches, which are already in linux-mvebu/mvebu/dt, are needed to fix the problem:
commit
585b136b73696ac37c9614b4b3d8fa0407adcdf1Author: Ezequiel Garcia <[email protected]> Date: Tue Aug 20 12:45:51 2013 -0300Quoted 7 lines
ARM: mvebu: Add clock properties to Armada XP timer node
commit
d36fd447d5e2d0993a8ec34afc26fc449ac1e2f3Author: Ezequiel Garcia <[email protected]> Date: Tue Aug 20 12:45:50 2013 -0300ARM: mvebu: Add the reference 25 MHz fixed-clock to Armada XP
Yes, I saw that tglx sent a late pull for corresponding driver changes. I'll move these two over to mvebu/fixes shortly.
Quoted 9 lines
Quoted 2 lines
FWIW,
CONFIG_HAVE_ARM_ARCH_TIMER=yis also needed or the board freezes, but that's another problem which I'm currently investigating.Sounds like we just need a select, is there something more to it?
Please send a patch as soon as you have it nailed down. I'd like the two changes above and this patch to spend a few days in -next before I send the pull.
We've nailed it down (Jean Pihet did, actually). The problem was introduced by the patch adding clocksource_of_init() to initialize the timer, but missing a CONFIG_CLKSRC_OF option selection.
The offending commit is:
commit 573145f08c2b92c45498468afbbba909f6ce6135
Author: Ezequiel Garcia <[email protected]> Date: Tue Aug 13 11:43:12 2013 -0300
clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
Jean already has a patch and will send it later today.
Regards,
Signature · 3 lines
Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com