Skip to contentSkip to conversation

Annoying make debug messages at v2013.10-rc3

U-Boot Masahiro Yamada 3 participants 6 messages Sep 18, 2013 – Sep 19, 2013

lore
Share & tools
lore
#0 lore raw

Hello Albert.

Commit 27af930e modified top Makefile as follows:

    --- a/Makefile
    +++ b/Makefile
    @@ -838,7 +838,7 @@ unconfig:
     
     sinclude $(obj).boards.depend
     $(obj).boards.depend:  boards.cfg
    -       @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@
    +       @awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@
     
     #
     # Functions to generate common board directory names

I thought adding -d option is not what you intended.

So, I posted a patch "[U-Boot] Makefile: Do not show make debug messages" to delete -d option again.
Does my patch seem to be OK?

I am really suffering from lots of debug messages like follows:

$ make CROSS_COMPILE=arm-linux-gnueabi- omap4_panda
Configuring for omap4_panda board...
make -d
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-pc-linux-gnu
Reading makefiles...
Reading makefile `Makefile'...
Reading makefile `include/autoconf.mk.dep' (search path) (don't care) (no ~ expansion)...
Reading makefile `include/autoconf.mk' (search path) (don't care) (no ~ expansion)...
Reading makefile `include/config.mk' (search path) (no ~ expansion)...
Reading makefile `/home/yamada/workspace/u-boot/config.mk' (search path) (no ~ expansion)...
Reading makefile /home/yamada/workspace/u-boot/include/generated/cc_options.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/include/autoconf.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/include/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/arch/arm/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/arch/arm/cpu/armv7/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/arch/arm/cpu/armv7/omap4/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/board/ti/panda/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile .boards.depend' (search path) (don't care) (no ~ expansion)...
Updating makefiles....
Considering target file `.boards.depend'.
Considering target file `boards.cfg'.
Looking for an implicit rule for `boards.cfg'.
Trying pattern rule with stem `boards.cfg'.
Trying implicit prerequisite `boards.cfg.o'.
Trying pattern rule with stem `boards.cfg'.
.....

Best Regards
Masahiro Yamada

#1 lore raw

Hi Masahiro,

Quoted 18 lines · Masahiro Yamada

Hello Albert.

Commit 27af930e modified top Makefile as follows:

    --- a/Makefile
    +++ b/Makefile
    @@ -838,7 +838,7 @@ unconfig:
     
     sinclude $(obj).boards.depend
     $(obj).boards.depend:  boards.cfg
    -       @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@
    +       @awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@
     
     #
     # Functions to generate common board directory names
Quoted 5 lines

I thought adding -d option is not what you intended.

So, I posted a patch "[U-Boot] Makefile: Do not show make debug messages" to delete -d option again.
Does my patch seem to be OK?

Yes. BTW, you do not need to double patches with explanatory mails. Any explanations that you want to add but not be put in the commit, just put them below the commit message delimiter, the "---" line.

Tom: do you want to pick this and Axel Lin's bang and Roger Meier's checkpatch fixes, or do I pick them in u-boot-arm?

Quoted 2 lines

Best Regards
Masahiro Yamada

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

Hi Albert.

Quoted 3 lines

Yes. BTW, you do not need to double patches with explanatory mails. Any explanations that you want to add but not be put in the commit, just put them below the commit message delimiter, the "---" line.

You are right. This thread was redundant.
Going forward I will do that. Thanks!

Best Regards
Masahiro Yamada

#3 lore raw
In reply to Albert ARIBAUD

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 29 lines · Albert ARIBAUD

Hi Masahiro,

Quoted 18 lines · Masahiro Yamada

Hello Albert.

Commit 27af930e modified top Makefile as follows:

    --- a/Makefile
    +++ b/Makefile
    @@ -838,7 +838,7 @@ unconfig:
     
     sinclude $(obj).boards.depend
     $(obj).boards.depend:  boards.cfg
    -       @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@
    +       @awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@
     
     #
     # Functions to generate common board directory names
Quoted 5 lines

I thought adding -d option is not what you intended.

So, I posted a patch "[U-Boot] Makefile: Do not show make debug messages" to delete -d option again.
Does my patch seem to be OK?

Quoted 6 lines

Yes. BTW, you do not need to double patches with explanatory mails. Any explanations that you want to add but not be put in the commit, just put them below the commit message delimiter, the "---" line.

Tom: do you want to pick this and Axel Lin's bang and Roger Meier's checkpatch fixes, or do I pick them in u-boot-arm?

Please grab them for u-boot-arm/master, thanks

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSOx/5AAoJENk4IS6UOR1WP4kQAKbQseppz334GdoLL3DyUnf9 trtAS8HNPOFp0FmMP6I9dbVyyjNNoZR7JXt/i7D/UQrT5D3nJpGwNEaxEj8Prbek 07lkstmasWoVP+qS7S7Cty1lbuyvbopmDQIEvu8RY5qLBowOlxT5ez/P1OIQGWF3 sYNU3bf5oqEdu+Sgk7DFkAsmQb3r5EZIysNkUwCzDtrxz1b0vMOhka7cSVfq8E9n HoUzqpiILMNXyRCvvCdRzOD04JlTK9Mt3tb9x2N9x8RRIXF3VYrFglbjp4Fq4vev jaBdSxYFEhhf1mxmGLg1et7PR6YkhJ4KQ4cekCpA86E26juL0A0J40Y9zR/jo0rG 9A3d7bbKyO4SIqEJGe1Dbo6U6aqZ34Bjc87OLYcRjpF42sqhQtIxaoq9+ecYLIya 5HhmF6/R0THLb2r7cJ22hzS7fB7lJNbqoZGB+YL7Do46vAD0Yz22uLqepbym5T3F 2OKqbN7kMa73gbWZIF1YsMRLNnNhHFoncKV4kq92/sELxdnv8yQmiDu+Rai4YMrS 4uCDGnVmvRodeTaZOZxmyAjXWoSSNRbsIYUivdPIl2iHDavCbri34x1hX0gnSWN+ PtqnUGmLKPHAEik7b8Bz1AjpITsi/wOsQsFx/7DOOkBjW6tPe8mx0Sn4k82YC+1o toOn7+rCNGob/yk5bj0Z
=+6Ql
-----END PGP SIGNATURE-----

#4 lore raw
In reply to Masahiro Yamada

Hi Masahiro,

Quoted 52 lines · Masahiro Yamada

Hello Albert.

Commit 27af930e modified top Makefile as follows:

    --- a/Makefile
    +++ b/Makefile
    @@ -838,7 +838,7 @@ unconfig:
     
     sinclude $(obj).boards.depend
     $(obj).boards.depend:  boards.cfg
    -       @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@
    +       @awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@
     
     #
     # Functions to generate common board directory names

I thought adding -d option is not what you intended.

So, I posted a patch "[U-Boot] Makefile: Do not show make debug messages" to delete -d option again.
Does my patch seem to be OK?

I am really suffering from lots of debug messages like follows:

$ make CROSS_COMPILE=arm-linux-gnueabi- omap4_panda
Configuring for omap4_panda board...
make -d
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-pc-linux-gnu
Reading makefiles...
Reading makefile `Makefile'...
Reading makefile `include/autoconf.mk.dep' (search path) (don't care) (no ~ expansion)...
Reading makefile `include/autoconf.mk' (search path) (don't care) (no ~ expansion)...
Reading makefile `include/config.mk' (search path) (no ~ expansion)...
Reading makefile `/home/yamada/workspace/u-boot/config.mk' (search path) (no ~ expansion)...
Reading makefile /home/yamada/workspace/u-boot/include/generated/cc_options.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/include/autoconf.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/include/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/arch/arm/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/arch/arm/cpu/armv7/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/arch/arm/cpu/armv7/omap4/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile /home/yamada/workspace/u-boot/board/ti/panda/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile .boards.depend' (search path) (don't care) (no ~ expansion)...

Quoted 8 lines

Updating makefiles....
Considering target file `.boards.depend'.
Considering target file `boards.cfg'.
Looking for an implicit rule for boards.cfg'. Trying pattern rule with stem boards.cfg'. Trying implicit prerequisite boards.cfg.o'. Trying pattern rule with stem boards.cfg'.
.....

Can you repost according to the patch posting guidelines at
http://www.denx.de/wiki/U-Boot/Patches so that the patch shows up properly on patchwork and attributed to you?

Basically, generate the patch with git format-patch -s, and send it with git send-email.

Quoted 3 lines

Best Regards
Masahiro Yamada

Amicalement,

Signature · 1 line
Albert.
#5 lore raw

Hi Masahiro,

Quoted 1 line · Albert ARIBAUD

Can you repost according to the patch posting guidelines at

My bad--you had posted correctly. :)

Amicalement,

Signature · 1 line
Albert.