Skip to contentSkip to conversation

Allow svn tags and branches notation in $(PKG)_VERSION variable.

PATCH New Raúl Sánchez Siles 3 participants 7 messages Sep 18, 2013 – Sep 20, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Allow svn tags and branches notation in $(PKG)_VERSION variable.

According to user manual "generic-package Reference" section, LIBFOO_VERSION could refer to a branch or tag. This patch adds supports for this in the svn method case for the repositories following the branches/tags/trunk layout.

Examples:
LIBFOO_VERSION = tags/v3.2.1
LIBFOO_SITE = svn://svn.server.net/myproject

LIBFOO2_VERSION = branches/featureA LIBFOO2_SITE = http://svn.happyserver.net/theproject
LIBFOO2_SITE_METHOD = svn

---
 docs/manual/adding-packages-generic.txt | 2 ++
 package/pkg-download.mk                 | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allow-svn-tags-and-branches-notation-in-PKG-_VERSION.patch
Type: text/x-patch
Size: 1350 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130918/e022a560/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130918/e022a560/attachment.asc>

#1 lore raw

PATCH v2 1/1 Allow svn tags and branches notation in $(PKG)_VERSION variable.

Dear Ra?l S?nchez Siles,

Quoted 8 lines · Ra?l S?nchez Siles

According to user manual "generic-package Reference" section, LIBFOO_VERSION could refer to a branch or tag. This patch adds supports for this in the svn method case for the repositories following the branches/tags/trunk layout.

Examples:
LIBFOO_VERSION = tags/v3.2.1
LIBFOO_SITE = svn://svn.server.net/myproject

Quoted 5 lines

LIBFOO2_VERSION = branches/featureA LIBFOO2_SITE = http://svn.happyserver.net/theproject
LIBFOO2_SITE_METHOD = svn

Hum, I am not sure. In the SVN world, a version is really a revision number that you get with 'svn checkout -r'.

I believe to get a specific branch or tag with SVN, one should instead use:

LIBFOO2_VERSION = <some revision number>
LIBFOO2_SITE = http://svn.happyserver.net/theproject/branches/featureA

I do understand the wish to make things 'like other VCS', but I am not entirely convinced it's a good idea. But I can probably be convinced with good arguments :)

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 Allow svn tags and branches notation in $(PKG)_VERSION variable.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Thomas> Hum, I am not sure. In the SVN world, a version is really a Thomas> revision number that you get with 'svn checkout -r'.

Thomas> I believe to get a specific branch or tag with SVN, one should Thomas> instead use:

Thomas> LIBFOO2_VERSION = <some revision number>
Thomas> LIBFOO2_SITE = http://svn.happyserver.net/theproject/branches/featureA

Thomas> I do understand the wish to make things 'like other VCS', but I am not Thomas> entirely convinced it's a good idea. But I can probably be convinced Thomas> with good arguments :)

Yes, I would also prefer to keep it as it is.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v2 1/1 Allow svn tags and branches notation in $(PKG)_VERSION variable.

According to user manual "generic-package Reference" section, LIBFOO_VERSION could refer to a branch or tag. This patch adds supports for this in the svn method case for the repositories following the branches/tags/trunk layout.

Examples:
LIBFOO_VERSION = tags/v3.2.1
LIBFOO_SITE = svn://svn.server.net/myproject

LIBFOO2_VERSION = branches/featureA LIBFOO2_SITE = http://svn.happyserver.net/theproject
LIBFOO2_SITE_METHOD = svn

---
 docs/manual/adding-packages-generic.txt | 2 ++
 package/pkg-download.mk                 | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-Allow-svn-tags-and-branches-notation-in-PKG-_VERS.patch
Type: text/x-patch
Size: 1350 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130919/2165e8a1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130919/2165e8a1/attachment.asc>

#4 lore raw

v2 cover Allow svn tags and branches notation in $(PKG)_VERSION variable.

In reply to Peter Korsgaard

Hi:

Even that I understand Tom's answer as a NAK, I decided to send a revision
of the previous patch, just for the record. In this version the last modified svn revision for the tag (or branch) is retrieved (and exactly that).

Maybe someone can come with better and acceptable ideas from the buildroot
point of view.

I still consider the key point is being able to encode the revision into the
$(PKG)_SOURCE variable.

Regards,

Ra?l S?nchez Siles (1):
Allow svn tags and branches notation in $(PKG)_VERSION variable.

 docs/manual/adding-packages-generic.txt | 2 ++
 package/pkg-download.mk                 | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)
Signature · 8 lines
1.8.4.rc3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130919/05db55a5/attachment.asc>
#5 lore raw

v2 cover Allow svn tags and branches notation in $(PKG)_VERSION variable.

Sorry, I meant Peter.

El Jueves, 19 de septiembre de 2013 23:58:55 usted escribi?:

Quoted 3 lines

Hi:

Even that I understand Tom's answer as a NAK, I decided to send a revision

Signature · 10 lines
     Ra?l S?nchez Siles
----->Proud Debian user<-----
Linux registered user #416098
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130920/c7bf7bff/attachment.asc>
#6 lore raw

v2 cover Allow svn tags and branches notation in $(PKG)_VERSION variable.

In reply to Raúl Sánchez Siles

Dear Ra?l S?nchez Siles,

Quoted 2 lines · Ra?l S?nchez Siles

I still consider the key point is being able to encode the revision into the
$(PKG)_SOURCE variable.

I guess you meant "the key point is being able to encode the revision into the $(PKG)_VERSION" variable. But I don't see why this is important or useful, so could you explain why you believe it is necessary?

For example, for Buildroot, doing:

LIBFOO2_VERSION = branches/featureA LIBFOO2_SITE = http://svn.happyserver.net/theproject

is not recommended at all, because you don't know which version of "featureA" you will be getting. One user may be fetching one revision, and if another user builds the same Buildroot configuration a few days later, it might be another revision with additional changes.

That's why you should instead use:

LIBFOO2_VERSION = <some revision number>
LIBFOO2_SITE = http://svn.happyserver.net/theproject/branches/featureA

What is the problem with doing this?

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com