Skip to contentSkip to conversation

ARM: shmobile: Allow build of the MTU2 timer driver

PATCH New Magnus Damm 3 participants 4 messages Sep 18, 2013 – Sep 25, 2013

Subsystems (4)
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH 1/1 ARM: shmobile: Allow build of the MTU2 timer driver

From: Magnus Damm <[email protected]>

Include MTU2 in the list of timer drivers that may be used on mach-shmobile. This driver has previously only been used by the SH architecture. With this patch the MTU2 joins TMU and CMT as timer drivers that may be used on ARM or SH.

---

 arch/arm/mach-shmobile/Kconfig |    6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/mach-shmobile/Kconfig +6 -0
@@ -314,6 +314,12 @@ config SH_TIMER_CMT
 	help
 	  This enables build of the CMT timer driver.
 
+config SH_TIMER_MTU2
+	bool "MTU2 timer driver"
+	default y
+	help
+	  This enables build of the MTU2 timer driver.
+
 config SH_TIMER_TMU
 	bool "TMU timer driver"
 	default y
#1 lore raw

PATCH 1/1 ARM: shmobile: Allow build of the MTU2 timer driver

Hi,

Quoted 17 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Include MTU2 in the list of timer drivers that may be used on mach-shmobile. This driver has previously only been used by the SH architecture. With this patch the MTU2 joins TMU and CMT as timer drivers that may be used on ARM or SH.

---

 arch/arm/mach-shmobile/Kconfig |    6 ++++++
 1 file changed, 6 insertions(+)

arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900 config SH_TIMER_CMT · line 321

Quoted 8 lines
arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900 renamed from arch/arm/mach-shmobile/Kconfig +5 -0
@@ -314,6 +314,12 @@ config SH_TIMER_CMT
        help
          This enables build of the CMT timer driver.
 
+config SH_TIMER_MTU2
+       bool "MTU2 timer driver"
+       default y
+       help
+         This enables build of the MTU2 timer driver.

It's odd to have the config entry in arch/arm/ when the driver is in drivers/clocksource. I think this entry should be moved to drivers/clocksource/Kconfig for that reason (with appropriate dependencies).

-Olof

#2 lore raw

PATCH 1/1 ARM: shmobile: Allow build of the MTU2 timer driver

Quoted 24 lines · Olof Johansson

Hi,

Quoted 20 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Include MTU2 in the list of timer drivers that may be used on mach-shmobile. This driver has previously only been used by the SH architecture. With this patch the MTU2 joins TMU and CMT as timer drivers that may be used on ARM or SH.

---

 arch/arm/mach-shmobile/Kconfig |    6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900 renamed from arch/arm/mach-shmobile/Kconfig +0 -0
@@ -314,6 +314,12 @@ config SH_TIMER_CMT
        help
          This enables build of the CMT timer driver.
 
Quoted 10 lines

arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900 config SH_TIMER_CMT · line 321

Quoted 5 lines
arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900 renamed from arch/arm/mach-shmobile/Kconfig +5 -0
+config SH_TIMER_MTU2
+       bool "MTU2 timer driver"
+       default y
+       help
+         This enables build of the MTU2 timer driver.

It's odd to have the config entry in arch/arm/ when the driver is in drivers/clocksource. I think this entry should be moved to drivers/clocksource/Kconfig for that reason (with appropriate dependencies).

This sounds logical to me.
Magnus, how do you feel about this?

author maintainer
#3 lore raw

PATCH 1/1 ARM: shmobile: Allow build of the MTU2 timer driver

Quoted 36 lines · Simon Horman
Quoted 24 lines · Olof Johansson

Hi,

Quoted 20 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Include MTU2 in the list of timer drivers that may be used on mach-shmobile. This driver has previously only been used by the SH architecture. With this patch the MTU2 joins TMU and CMT as timer drivers that may be used on ARM or SH.

---

 arch/arm/mach-shmobile/Kconfig |    6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900 renamed from arch/arm/mach-shmobile/Kconfig +0 -0
@@ -314,6 +314,12 @@ config SH_TIMER_CMT
        help
          This enables build of the CMT timer driver.
 
Quoted 10 lines

arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900 config SH_TIMER_CMT · line 321

Quoted 5 lines
arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900 renamed from arch/arm/mach-shmobile/Kconfig +5 -0
+config SH_TIMER_MTU2
+       bool "MTU2 timer driver"
+       default y
+       help
+         This enables build of the MTU2 timer driver.

It's odd to have the config entry in arch/arm/ when the driver is in drivers/clocksource. I think this entry should be moved to drivers/clocksource/Kconfig for that reason (with appropriate dependencies).

Quoted 2 lines

This sounds logical to me.
Magnus, how do you feel about this?

Keeping it in a single location sounds good to me, but I worry a bit about how to merge it without any conflicts.

A little while ago did I send out a first rough patch for this:

[PATCH/RFC] clocksource: Consolidate SH and ARM mach-shmobile Kconfig bits

Cheers,

/ magnus