Skip to contentSkip to conversation

EDAC, AMD64_EDAC: Remove superfluous condition check.

PATCH Applied Aravind Gopalakrishnan 2 participants 2 messages Sep 11, 2013 – Sep 19, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC, AMD64_EDAC: Remove superfluous condition check.

The condition check 'channel < 0' is needless since channel is unsigned.

Reported by Dave Jones here:
http://marc.info/?l=linux-kernel&m=137839225430844&w=2

---
 drivers/edac/amd64_edac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/amd64_edac.c +1 -1
index 3c9e4e9..bbd1913 100644
@@ -1576,7 +1576,7 @@ static int f15_m30h_match_to_this_node(struct amd64_pvt *pvt, unsigned range,
 					     num_dcts_intlv, dct_sel);
 
 	/* Verify we stay within the MAX number of channels allowed */
-	if (channel > 4 || channel < 0)
+	if (channel > 4)
 		return -EINVAL;
 
 	leg_mmio_hole = (u8) (dct_cont_base_reg >> 1 & BIT(0));
Signature · 1 line
1.7.10.4