Skip to contentSkip to conversation

arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ

PATCH New Nobuhiro Iwamatsu 2 participants 5 messages Aug 22, 2013 – Sep 21, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ

---
 include/configs/kzm9g.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/kzm9g.h +1 -0
index 222725c..6323050 100644
@@ -125,6 +125,7 @@
 #define CONFIG_GLOBAL_TIMER
 #define CONFIG_SYS_CLK_FREQ	(48000000)
 #define CONFIG_SYS_CPU_CLK	(1196000000)
+#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
 #define TMU_CLK_DIVIDER		(4)	/* 4 (default), 16, 64, 256 or 1024 */
 #define CFG_HZ              (1000)
 #define CONFIG_SYS_HZ		CFG_HZ
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 2/2 arm: rmobile: armadillo-800eva: Change clock definition of SCIF and TMU

This changes clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ, and clock definition of TMU from CONFIG_SYS_CLK_FREQ to CONFIG_SH_TMU_CLK_FREQ,

---
 include/configs/armadillo-800eva.h | 2 ++
 1 file changed, 2 insertions(+)
include/configs/armadillo-800eva.h +2 -0
index 9f357ea..7a264b0 100644
@@ -138,6 +138,8 @@
 
 /* Board Clock */
 #define CONFIG_SYS_CLK_FREQ	50000000
+#define CONFIG_SH_TMU_CLK_FREQ CONFIG_SYS_CLK_FREQ
+#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
 #define CONFIG_SYS_TMU_CLK_DIV	4
 #define CONFIG_SYS_HZ		1000
 
Signature · 1 line
1.8.3.2
#2 lore raw

PATCH 1/2 arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ

In reply to Nobuhiro Iwamatsu

Hi Nobuhiro,

Quoted 10 lines · Nobuhiro Iwamatsu
---
 include/configs/kzm9g.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/kzm9g.h +0 -0
index 222725c..6323050 100644

include/configs/kzm9g.h line 131

Quoted 7 lines
include/configs/kzm9g.h +1 -0
@@ -125,6 +125,7 @@
 #define CONFIG_GLOBAL_TIMER
 #define CONFIG_SYS_CLK_FREQ	(48000000)
 #define CONFIG_SYS_CPU_CLK	(1196000000)
+#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
 #define TMU_CLK_DIVIDER		(4)	/* 4 (default), 16, 64, 256 or 1024 */
 #define CFG_HZ              (1000)
 #define CONFIG_SYS_HZ		CFG_HZ

What's the point of this series? It only adds a define, but the current codebase does not use it anywhere, so obviously it's "dead code". If there is a further series which needs this define, then include these patches in that further series.

Amicalement,

Signature · 1 line
Albert.
#3 lore raw

PATCH 1/2 arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ

Hi, Albert.

Quoted 10 lines · Albert ARIBAUD

Hi Nobuhiro,

Quoted 5 lines · Nobuhiro Iwamatsu
---
  include/configs/kzm9g.h | 1 +
  1 file changed, 1 insertion(+)
Quoted 16 lines

include/configs/kzm9g.h line 131

Quoted 12 lines
include/configs/kzm9g.h +1 -0
index 222725c..6323050 100644
@@ -125,6 +125,7 @@
  #define CONFIG_GLOBAL_TIMER
  #define CONFIG_SYS_CLK_FREQ	(48000000)
  #define CONFIG_SYS_CPU_CLK	(1196000000)
+#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
  #define TMU_CLK_DIVIDER		(4)	/* 4 (default), 16, 64, 256 or 1024 */
  #define CFG_HZ              (1000)
  #define CONFIG_SYS_HZ		CFG_HZ

What's the point of this series? It only adds a define, but the current codebase does not use it anywhere, so obviously it's "dead code".

This is used by drivers/serial/serial_sh.c.
http://lists.denx.de/pipermail/u-boot/2013-August/161276.html

I already applied this to my u-boot-sh repository. But I dont pull-request yet. I want to include in the next version of this change.

Quoted 3 lines

If there is a further series which needs this define, then include these patches in that further series.

I see. I will be from next time, Is it OK?

Quoted 2 lines

Amicalement,

Best regards,
Nobuhiro

#4 lore raw

PATCH 1/2 arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ

Hi Nobuhiro,

Quoted 33 lines · Nobuhiro Iwamatsu

Hi, Albert.

Quoted 10 lines · Albert ARIBAUD

Hi Nobuhiro,

Quoted 5 lines · Nobuhiro Iwamatsu
---
  include/configs/kzm9g.h | 1 +
  1 file changed, 1 insertion(+)
Quoted 16 lines

include/configs/kzm9g.h line 131

Quoted 12 lines
include/configs/kzm9g.h +1 -0
index 222725c..6323050 100644
@@ -125,6 +125,7 @@
  #define CONFIG_GLOBAL_TIMER
  #define CONFIG_SYS_CLK_FREQ	(48000000)
  #define CONFIG_SYS_CPU_CLK	(1196000000)
+#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
  #define TMU_CLK_DIVIDER		(4)	/* 4 (default), 16, 64, 256 or 1024 */
  #define CFG_HZ              (1000)
  #define CONFIG_SYS_HZ		CFG_HZ

What's the point of this series? It only adds a define, but the current codebase does not use it anywhere, so obviously it's "dead code".

This is used by drivers/serial/serial_sh.c.
http://lists.denx.de/pipermail/u-boot/2013-August/161276.html

Quoted 7 lines

I already applied this to my u-boot-sh repository. But I dont pull-request yet. I want to include in the next version of this change.

Quoted 3 lines

If there is a further series which needs this define, then include these patches in that further series.

I see. I will be from next time, Is it OK?

OK -- I'll mark these 2 patches as "changes requested".

Quoted 2 lines

Best regards,
Nobuhiro

Amicalement,

Signature · 1 line
Albert.