ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Subsystems (2)
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
---
Changes since (implicit) v1 sent with Message-id:
1376552964-16296-1-git-send-email-u.kleine-koenig at pengutronix.de:
- drop adding device trees as this depends on a patch not yet mainline (clk: new driver for efm32 SoC)
- drop adding code for timekeeping. Sent as a separate patch which adds code to drivers/clocksource. (No compile time dependencies)
arch/arm/Kconfig | 16 +++- arch/arm/Kconfig.debug | 16 ++++ arch/arm/Makefile | 1 + arch/arm/configs/efm32_defconfig | 104 +++++++++++++++++++++++++ arch/arm/mach-efm32/Makefile | 1 + arch/arm/mach-efm32/Makefile.boot | 2 + arch/arm/mach-efm32/cmu.h | 15 ++++ arch/arm/mach-efm32/common.c | 19 +++++ arch/arm/mach-efm32/common.h | 1 + arch/arm/mach-efm32/dtmachine.c | 31 ++++++++ arch/arm/mach-efm32/include/mach/debug-macro.S | 48 ++++++++++++ arch/arm/mach-efm32/include/mach/entry-macro.S | 5 ++ arch/arm/mach-efm32/include/mach/io.h | 6 ++ arch/arm/mach-efm32/include/mach/irqs.h | 6 ++ arch/arm/mach-efm32/include/mach/timex.h | 7 ++ 15 files changed, 277 insertions(+), 1 deletion(-) create mode 100644 arch/arm/configs/efm32_defconfig create mode 100644 arch/arm/mach-efm32/Makefile create mode 100644 arch/arm/mach-efm32/Makefile.boot create mode 100644 arch/arm/mach-efm32/cmu.h create mode 100644 arch/arm/mach-efm32/common.c create mode 100644 arch/arm/mach-efm32/common.h create mode 100644 arch/arm/mach-efm32/dtmachine.c create mode 100644 arch/arm/mach-efm32/include/mach/debug-macro.S create mode 100644 arch/arm/mach-efm32/include/mach/entry-macro.S create mode 100644 arch/arm/mach-efm32/include/mach/io.h create mode 100644 arch/arm/mach-efm32/include/mach/irqs.h create mode 100644 arch/arm/mach-efm32/include/mach/timex.h
arch/arm/Kconfig +15 -1
@@ -406,6 +406,20 @@ config ARCH_EBSA110 Ethernet interface, two PCMCIA sockets, two serial ports and a parallel port. +config ARCH_EFM32 + bool "Energy Micro Cortex M3 Platform" + depends on !MMU + select ARM_NVIC + select CLKSRC_MMIO + select CLKSRC_OF + select COMMON_CLK + select CPU_V7M + select GENERIC_CLOCKEVENTS + select HAVE_CLK + select NO_DMA + select NO_IOPORT + select USE_OF + config ARCH_EP93XX bool "EP93xx-based" select ARCH_HAS_HOLES_MEMORYMODEL
@@ -1803,7 +1817,7 @@ config FORCE_MAX_ZONEORDER int "Maximum zone order" if ARCH_SHMOBILE range 11 64 if ARCH_SHMOBILE default "12" if SOC_AM33XX - default "9" if SA1111 + default "9" if SA1111 || ARCH_EFM32 default "11" help The kernel memory allocator divides physically contiguous memory
arch/arm/Kconfig.debug +16 -0
@@ -173,6 +173,22 @@ choice Say Y here if you want the debug print routines to direct their output to the serial port in the DC21285 (Footbridge). + config DEBUG_EFM32_UART1 + bool "Kernel low-level debugging messages via UART1 (ttyefm4)" + depends on ARCH_EFM32 + help + Say Y here if you want the debug print routines to direct + their output to the second UART port on efm32 based + machines. + + config DEBUG_EFM32_USART1 + bool "Kernel low-level debugging messages via USART1 (ttyefm1)" + depends on ARCH_EFM32 + help + Say Y here if you want the debug print routines to direct + their output to the second USART port on efm32 based + machines. + config DEBUG_FOOTBRIDGE_COM1 bool "Kernel low-level debugging messages via footbridge 8250 at PCI COM1" depends on FOOTBRIDGE
arch/arm/Makefile +1 -0
@@ -152,6 +152,7 @@ machine-$(CONFIG_ARCH_CNS3XXX) += cns3xxx machine-$(CONFIG_ARCH_DAVINCI) += davinci machine-$(CONFIG_ARCH_DOVE) += dove machine-$(CONFIG_ARCH_EBSA110) += ebsa110 +machine-$(CONFIG_ARCH_EFM32) += efm32 machine-$(CONFIG_ARCH_EP93XX) += ep93xx machine-$(CONFIG_ARCH_EXYNOS) += exynos machine-$(CONFIG_ARCH_GEMINI) += gemini
arch/arm/configs/efm32_defconfig new file +104 -0
104 lines not on this page · raw message
arch/arm/mach-efm32/Makefile new file +1 -0
@@ -0,0 +1 @@ +obj-y += common.o dtmachine.o
arch/arm/mach-efm32/Makefile.boot new file +2 -0
@@ -0,0 +1,2 @@ +# This file is still needed because we cannot select ARCH_MULTIPLATFORM (as it +# depends on MMU) and then this file is sourced in arch/arm/boot/Makefile
arch/arm/mach-efm32/cmu.h new file +15 -0
@@ -0,0 +1,15 @@ +/* +* Register definition for efm32's CMU component +*/ + +#define CMU_OSCENCMD 0x20 +#define CMU_OSCENCMD_HFXOEN 0x00000004 + +#define CMU_CMD 0x24 +#define CMU_CMD_HFCLKSEL_HFXO 0x00000002 + +#define CMU_STATUS 0x2c +#define CMU_STATUS_HFRCOSEL 0x00000400 +#define CMU_STATUS_HFXOSEL 0x00000800 + +#define CMU_HFPERCLKEN0 0x44
arch/arm/mach-efm32/common.c new file +19 -0
@@ -0,0 +1,19 @@ +/* +* Copyright (C) 2012-2013 Uwe Kleine-Koenig for Pengutronix +* +* This program is free software; you can redistribute it and/or modify it under +* the terms of the GNU General Public License version 2 as published by the +* Free Software Foundation. +*/ +#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/clk-provider.h> +#include <linux/clocksource.h> + +#include "common.h" + +void __init efm32_init_time (void ) +{ +of_clk_init (NULL ); +clocksource_of_init (); +}
arch/arm/mach-efm32/common.h new file +1 -0
@@ -0,0 +1 @@ +void efm32_init_time (void );
arch/arm/mach-efm32/dtmachine.c new file +31 -0
@@ -0,0 +1,31 @@ +#include <linux/kernel.h> +#include <linux/pinctrl/machine.h> +#include <linux/irqdomain.h> +#include <linux/of_platform.h> +#include <linux/of_irq.h> +#include <linux/irqchip.h> + +#include <asm/v7m.h> + +#include <asm/mach/arch.h> +#include <asm/mach/time.h> + +#include "common.h" + +static void __init efm32_init (void ) +{ +of_platform_populate (NULL , of_default_bus_match_table,NULL ,NULL ); +} + +static const char *const efm32gg_compat[]__initconst = { +"efm32,dk3750" , +NULL +}; + +DT_MACHINE_START (EFM32DT ,"EFM32 (Device Tree Support)" ) + .init_irq = irqchip_init, + .init_time = efm32_init_time, + .init_machine = efm32_init, + .dt_compat = efm32gg_compat, + .restart = armv7m_restart, +MACHINE_END
arch/arm/mach-efm32/include/mach/debug-macro.S new file +48 -0
48 lines not on this page · raw message
arch/arm/mach-efm32/include/mach/entry-macro.S new file +5 -0
@@ -0,0 +1,5 @@ + .macro get_irqnr_preamble, base, tmp + .endm + + .macro arch_ret_to_user, tmp1, tmp2 + .endm
arch/arm/mach-efm32/include/mach/io.h new file +6 -0
@@ -0,0 +1,6 @@ +#ifndef __MACH_IO_H__ +#define __MACH_IO_H__ + +#define __mem_pci (a) (a) + +#endif /* __MACH_IO_H__ */
arch/arm/mach-efm32/include/mach/irqs.h new file +6 -0
@@ -0,0 +1,6 @@ +#ifndef __MACH_IRQS_H__ +#define __MACH_IRQS_H__ + +#define NR_IRQS 82 + +#endif /* __MACH_IRQS_H__ */
arch/arm/mach-efm32/include/mach/timex.h new file +7 -0
@@ -0,0 +1,7 @@ +#ifndef __MACH_TIMEX_H__ +#define __MACH_TIMEX_H__ + +/* just a bogus value */ +#define CLOCK_TICK_RATE 12345678 + +#endif /* __MACH_TIMEX_H__ */
Signature · 1 line
1.8.4.rc3
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Quoted 7 lines · Uwe Kleine-K?nig
arch/arm/Kconfig | 16 +++- arch/arm/Kconfig.debug | 16 ++++ arch/arm/Makefile | 1 + arch/arm/configs/efm32_defconfig | 104 +++++++++++++++++++++++++ arch/arm/mach-efm32/Makefile | 1 + arch/arm/mach-efm32/Makefile.boot | 2 + arch/arm/mach-efm32/cmu.h | 15 ++++
Quoted 8 lines
arch/arm/mach-efm32/common.c | 19 +++++ arch/arm/mach-efm32/common.h | 1 + arch/arm/mach-efm32/dtmachine.c | 31 ++++++++ arch/arm/mach-efm32/include/mach/debug-macro.S | 48 ++++++++++++ arch/arm/mach-efm32/include/mach/entry-macro.S | 5 ++ arch/arm/mach-efm32/include/mach/io.h | 6 ++ arch/arm/mach-efm32/include/mach/irqs.h | 6 ++ arch/arm/mach-efm32/include/mach/timex.h | 7 ++
You should be able to add NOMMU platforms in combination with CONFIG_MULTIPLATFORM now, which gets rid of most of these files.
arch/arm/mach-efm32/Makefile line 1
Quoted 7 lines
arch/arm/mach-efm32/Makefile new file +1
-0@@ -0,0 +1 @@ +obj-y += common.o dtmachine.o
Just merge the two files into one.
arch/arm/mach-efm32/Makefile
Quoted 6 lines
arch/arm/mach-efm32/Makefile new file +6
-0+ +void __init efm32_init_time(void) +{ + of_clk_init(NULL); + clocksource_of_init(); +}
When Sebastian Hesselbarth's patches for of_clk_init() are merged, this function can go away.
arch/arm/mach-efm32/Makefile
Quoted 5 lines
arch/arm/mach-efm32/Makefile new file +5
-0+static void __init efm32_init(void) +{ + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); +} +
And this one is already unnecessary.
arch/arm/mach-efm32/Makefile
Quoted 7 lines
arch/arm/mach-efm32/Makefile new file +7
-0+static const char *const efm32gg_compat[] __initconst = { + "efm32,dk3750", + NULL +}; + +DT_MACHINE_START(EFM32DT, "EFM32 (Device Tree Support)") + .init_irq = irqchip_init,
Same for irqchip_init, which is the default when omitted.
arch/arm/mach-efm32/include/mach/debug-macro.S
Quoted 5 lines
arch/arm/mach-efm32/include/mach/debug-macro.S new file +0
-0
Please move this to arch/arm/include/debug/ like the other such implementations.
arch/arm/mach-efm32/include/mach/entry-macro.S line 5
Quoted 11 lines
arch/arm/mach-efm32/include/mach/entry-macro.S new file +5
-0@@ -0,0 +1,5 @@ + .macro get_irqnr_preamble, base, tmp + .endm + + .macro arch_ret_to_user, tmp1, tmp2 + .endm
And use set_handle_irq() to register a handler from your irqchip driver to get rid of this one.
arch/arm/mach-efm32/include/mach/irqs.h line 6
Quoted 9 lines
arch/arm/mach-efm32/include/mach/irqs.h new file +6
-0@@ -0,0 +1,6 @@ +#ifndef __MACH_IRQS_H__ +#define __MACH_IRQS_H__ + +#define NR_IRQS 82 + +#endif /* __MACH_IRQS_H__ */
This should not be needed if you have the proper IRQ domain support, which I think you do.
Arnd
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Hi Arnd,
Quoted 17 lines · Arnd Bergmann
Quoted 7 lines · Uwe Kleine-K?nig
arch/arm/Kconfig | 16 +++- arch/arm/Kconfig.debug | 16 ++++ arch/arm/Makefile | 1 + arch/arm/configs/efm32_defconfig | 104 +++++++++++++++++++++++++ arch/arm/mach-efm32/Makefile | 1 + arch/arm/mach-efm32/Makefile.boot | 2 + arch/arm/mach-efm32/cmu.h | 15 ++++Quoted 8 lines
arch/arm/mach-efm32/common.c | 19 +++++ arch/arm/mach-efm32/common.h | 1 + arch/arm/mach-efm32/dtmachine.c | 31 ++++++++ arch/arm/mach-efm32/include/mach/debug-macro.S | 48 ++++++++++++ arch/arm/mach-efm32/include/mach/entry-macro.S | 5 ++ arch/arm/mach-efm32/include/mach/io.h | 6 ++ arch/arm/mach-efm32/include/mach/irqs.h | 6 ++ arch/arm/mach-efm32/include/mach/timex.h | 7 ++
Quoted 2 lines
You should be able to add NOMMU platforms in combination with
CONFIG_MULTIPLATFORMnow, which gets rid of most of these files.
in next ARCH_MULTIPLATFORM still depends on MMU. What am I missing?
Quoted 9 lines
arch/arm/mach-efm32/Makefile line 1
Quoted 7 lines
arch/arm/mach-efm32/Makefile new file +1
-0@@ -0,0 +1 @@ +obj-y += common.o dtmachine.oJust merge the two files into one.
ok.
Quoted 9 lines
arch/arm/mach-efm32/Makefile
Quoted 6 lines
arch/arm/mach-efm32/Makefile new file +6
-0+ +void __init efm32_init_time(void) +{ + of_clk_init(NULL); + clocksource_of_init(); +}When Sebastian Hesselbarth's patches for
of_clk_init()are merged, this function can go away.
Do you have a link?
Quoted 7 lines
arch/arm/mach-efm32/Makefile
Quoted 5 lines
arch/arm/mach-efm32/Makefile new file +5
-0+static void __init efm32_init(void) +{ + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); +} +And this one is already unnecessary.
fine.
Quoted 9 lines
arch/arm/mach-efm32/Makefile
Quoted 7 lines
arch/arm/mach-efm32/Makefile new file +7
-0+static const char *const efm32gg_compat[] __initconst = { + "efm32,dk3750", + NULL +}; + +DT_MACHINE_START(EFM32DT, "EFM32 (Device Tree Support)") + .init_irq = irqchip_init,Same for
irqchip_init, which is the default when omitted.
ok.
Quoted 9 lines
arch/arm/mach-efm32/include/mach/debug-macro.S
Quoted 6 lines
arch/arm/mach-efm32/include/mach/debug-macro.S new file +0
-0Please move this to
arch/arm/include/debug/like the other such implementations.
I don't mind, but I thought this is only for devices that are expected to be available on >1 platform.
Quoted 6 lines
Quoted 6 lines
arch/arm/mach-efm32/include/mach/entry-macro.S new file +0
-0@@ -0,0 +1,5 @@
Quoted 8 lines
arch/arm/mach-efm32/include/mach/entry-macro.S line 5
Quoted 5 lines
arch/arm/mach-efm32/include/mach/entry-macro.S new file +5
-0+ .macro get_irqnr_preamble, base, tmp + .endm + + .macro arch_ret_to_user, tmp1, tmp2 + .endmAnd use
set_handle_irq()to register a handler from your irqchip driver to get rid of this one.
ISTR that I tried that, but I don't remember the details. I will retry.
Quoted 4 lines
Quoted 4 lines
arch/arm/mach-efm32/include/mach/irqs.h new file +1
-0@@ -0,0 +1,6 @@ +#ifndef __MACH_IRQS_H__
Quoted 8 lines
arch/arm/mach-efm32/include/mach/irqs.h line 6
Quoted 5 lines
arch/arm/mach-efm32/include/mach/irqs.h new file +5
-0+#define __MACH_IRQS_H__ + +#define NR_IRQS 82 + +#endif /* __MACH_IRQS_H__ */ This should not be needed if you have the proper IRQ domain support, which I think you do.
OK.
Thanks for your comments
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Quoted 6 lines · Uwe Kleine-K?nig
Quoted 4 lines · Arnd Bergmann
On Tuesday 17 September 2013, Uwe Kleine-K?nig wrote:
You should be able to add NOMMU platforms in combination with
CONFIG_MULTIPLATFORMnow, which gets rid of most of these files.in next
ARCH_MULTIPLATFORMstill depends on MMU. What am I missing?
Oh, I saw a patch for that for VEXPRESS/Cortex-R7 some time ago. It was apparently not merged. Please try just removing the depdency in Kconfig, I think it should work fine.
Quoted 10 lines
Quoted 9 lines
arch/arm/mach-efm32/common.c line 19
Quoted 6 lines
arch/arm/mach-efm32/common.c new file +6
-0+ +void __init efm32_init_time (void ) +{ +of_clk_init (NULL ); +clocksource_of_init (); +}When Sebastian Hesselbarth's patches for
of_clk_init()are merged, this function can go away.Do you have a link?
http://lmgtfy.com/?q=hesselbarth+of_clk_init ;-)
I've put Sebastian on Cc, I guess he can comment on the status of his patches, so we can come up with a plan for dealing with the dependency here.
Quoted 10 lines
Quoted 8 lines
arch/arm/mach-efm32/include/mach/debug-macro.S
Quoted 5 lines
arch/arm/mach-efm32/include/mach/debug-macro.S new file +0
-0Please move this to
arch/arm/include/debug/like the other such implementations.I don't mind, but I thought this is only for devices that are expected to be available on >1 platform.
Well, it's required for multiplatform, since the include/mach/ directory is no longer visible to the debug code.
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
arch/arm/mach-efm32/include/mach/entry-macro.S new file +0
-0@@ -0,0 +1,5 @@Quoted 8 lines
arch/arm/mach-efm32/include/mach/entry-macro.S line 5
Quoted 5 lines
arch/arm/mach-efm32/include/mach/entry-macro.S new file +5
-0+ .macro get_irqnr_preamble, base, tmp + .endm + + .macro arch_ret_to_user, tmp1, tmp2 + .endmAnd use
set_handle_irq()to register a handler from your irqchip driver to get rid of this one.
Quoted 1 line
ISTR that I tried that, but I don't remember the details. I will retry.
Maybe you get some spurious interrupt before the irqchip is registered?
Arndj
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Quoted 3 lines · Arnd Bergmann
Quoted 2 lines · Uwe Kleine-K?nig
Quoted 1 line · Arnd Bergmann
On Tuesday 17 September 2013, Uwe Kleine-K?nig wrote:
[...]
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
arch/arm/mach-efm32/common.c line 19
Quoted 6 lines
arch/arm/mach-efm32/common.c new file +6
-0+ +void __init efm32_init_time (void ) +{ +of_clk_init (NULL ); +clocksource_of_init (); +}When Sebastian Hesselbarth's patches for
of_clk_init()are merged, this function can go away.
Quoted 7 lines
Quoted 1 line
Do you have a link?
http://lmgtfy.com/?q=hesselbarth+of_clk_init ;-)
I've put Sebastian on Cc, I guess he can comment on the status of his patches, so we can come up with a plan for dealing with the dependency here.
Patch set has been sent yesterday, still waiting for ACK's.
Olof already mentioned to (a) take it in arm-soc early and (b) have a topic branch to depend on.
I guess I will prepare that topic branch and Olof can take it (or fall back to creating it on his own, if I fail to do it right).
Sebastian
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Hello,
Quoted 14 lines · Sebastian Hesselbarth
Quoted 3 lines · Arnd Bergmann
Quoted 2 lines · Uwe Kleine-K?nig
Quoted 1 line · Arnd Bergmann
On Tuesday 17 September 2013, Uwe Kleine-K?nig wrote:
[...]
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
arch/arm/mach-efm32/common.c line 19
Quoted 6 lines
arch/arm/mach-efm32/common.c new file +6
-0+ +void __init efm32_init_time (void ) +{ +of_clk_init (NULL ); +clocksource_of_init (); +}When Sebastian Hesselbarth's patches for
of_clk_init()are merged, this function can go away.
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
Do you have a link?
Hmm, I checked my linux-arm-kernel mailbox and failed to find the series. Not reproducable though. Thanks.
Quoted 5 lines
Quoted 4 lines
I've put Sebastian on Cc, I guess he can comment on the status of his patches, so we can come up with a plan for dealing with the dependency here.
Quoted 7 lines
Patch set has been sent yesterday, still waiting for ACK's.
Olof already mentioned to (a) take it in arm-soc early and (b) have a topic branch to depend on.
I guess I will prepare that topic branch and Olof can take it (or fall back to creating it on his own, if I fail to do it right).
I assume that means that it's expected to land in 3.13, and my efm32 patch at least not earlier. So please tell me when there is a branch to depend on.
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
In reply to Arnd BergmannQuoted 17 lines · Arnd Bergmann
Quoted 7 lines · Uwe Kleine-K?nig
arch/arm/Kconfig | 16 +++- arch/arm/Kconfig.debug | 16 ++++ arch/arm/Makefile | 1 + arch/arm/configs/efm32_defconfig | 104 +++++++++++++++++++++++++ arch/arm/mach-efm32/Makefile | 1 + arch/arm/mach-efm32/Makefile.boot | 2 + arch/arm/mach-efm32/cmu.h | 15 ++++Quoted 8 lines
arch/arm/mach-efm32/common.c | 19 +++++ arch/arm/mach-efm32/common.h | 1 + arch/arm/mach-efm32/dtmachine.c | 31 ++++++++ arch/arm/mach-efm32/include/mach/debug-macro.S | 48 ++++++++++++ arch/arm/mach-efm32/include/mach/entry-macro.S | 5 ++ arch/arm/mach-efm32/include/mach/io.h | 6 ++ arch/arm/mach-efm32/include/mach/irqs.h | 6 ++ arch/arm/mach-efm32/include/mach/timex.h | 7 ++
Quoted 2 lines
You should be able to add NOMMU platforms in combination with
CONFIG_MULTIPLATFORMnow, which gets rid of most of these files.
I made that work now and can prepare a patch. I had to drop "depends on !ARCH_MULTIPLATFORM" from XIP_KERNEL. That's because my machine only works with XIP_KERNEL as it only has 4 MiB of RAM.
Also note that for !MMU you need to specify the base address and size of your RAM (DRAM_BASE, DRAM_SIZE) and flash (FLASH_MEM_BASE, FLASH_SIZE). So the resulting image is hardly runnable on different machines. (I don't know off-hand why these are needed though, maybe this can be discussed away.)
So ARCH_MULTIPLATFORM is only good as it allows to simplify a few things, but the result isn't really multi-platform.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Quoted 3 lines · Uwe Kleine-K?nig
I made that work now and can prepare a patch. I had to drop "depends on !ARCH_MULTIPLATFORM" from
XIP_KERNEL. That's because my machine only works withXIP_KERNELas it only has 4 MiB of RAM.
Ok, cool. We might run into a few problems with 'make randconfig' and 'make allyesconfig' when it becomes possible to enable XIP_KERNEL then. IIRC, there is no fundamental reason to disallow XIP_KERNEL with ARCH_MULTIPLATFORM, but I added the dependency because it causes build errors in combination with other options.
Quoted 8 lines
Also note that for !MMU you need to specify the base address and size of your RAM (
DRAM_BASE,DRAM_SIZE) and flash (FLASH_MEM_BASE,FLASH_SIZE). So the resulting image is hardly runnable on different machines. (I don't know off-hand why these are needed though, maybe this can be discussed away.)So
ARCH_MULTIPLATFORMis only good as it allows to simplify a few things, but the result isn't really multi-platform.
Yes, that's understood. We can probably remove the need to know the size of flash and dram at compile time, but we definitely need to know the location of the kernel in physical memory.
Of course, in a lot of platforms, you can't even have the same XIP kernel across multiple boards, when they have RAM or NOR flash at a different location, but in theory you could have two boards of different platforms that both have RAM starting at 0 and run the same kernel. I don't think anyone would want to run such a kernel in practice, but it shows that multiplatform is really orthogonal to building MMU or NOMMU kernels.
A few questions from my side, out of curiosity:
* Do you need any other patches (unrelated to EFM32) to run NOMMU on a recent kernel? When I last tried, I could not get any NOMMU build to work at all.
* Do you think 4MB is now a strict lower bound for running a modern kernel? It would be a good data point if we could show that any target with less than that is by definition broken and could get removed from the kernel. What is the size of your kernel and user space?
* What user space are you running? Anything that's easy to build for testing? Should that run with a mach-virt kernel built for ARMv7-A NOMMU?
* An ARMv7-M kernel cannot run on either ARMv4/v5 nor ARMv6/v7-A, right? Do you prevent building such a kernel in Kconfig?
Arnd
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Quoted 3 lines · Arnd Bergmann
* Do you need any other patches (unrelated to EFM32) to run NOMMU on a recent kernel? When I last tried, I could not get any NOMMU build to work at all.
My Oki platform builds fine. The core noMMU stuff seems fine.
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
In reply to Arnd BergmannHi Arnd,
Quoted 10 lines · Arnd Bergmann
Quoted 3 lines · Uwe Kleine-K?nig
I made that work now and can prepare a patch. I had to drop "depends on !ARCH_MULTIPLATFORM" from
XIP_KERNEL. That's because my machine only works withXIP_KERNELas it only has 4 MiB of RAM.Ok, cool. We might run into a few problems with 'make randconfig' and 'make allyesconfig' when it becomes possible to enable
XIP_KERNELthen. IIRC, there is no fundamental reason to disallowXIP_KERNELwithARCH_MULTIPLATFORM, but I added the dependency because it causes build errors in combination with other options.
ah, OK. Do you have an idea to fix both?
Quoted 5 lines
A few questions from my side, out of curiosity:
* Do you need any other patches (unrelated to EFM32) to run NOMMU on a recent kernel? When I last tried, I could not get any NOMMU build to work at all.
no, there isn't much needed on top of current mainline. My current wip is at
git://git.pengutronix.de/git/ukl/linux.git efm32
I don't even rely on all the HACK-patches that are included there. (The multi-arch stuff isn't there yet.)
Quoted 4 lines
* Do you think 4MB is now a strict lower bound for running a modern kernel? It would be a good data point if we could show that any target with less than that is by definition broken and could get removed from the kernel. What is the size of your kernel and user space?
$ objdump -p vmlinux
vmlinux: file format elf32-littlearm
Program Header:
LOAD off 0x00000000 vaddr 0x88020000 paddr 0x88020000 align 2**15
filesz 0x00000094 memsz 0x0000a9f4 flags rw-
LOAD off 0x00008000 vaddr 0x8c000000 paddr 0x8c000000 align 2**15
filesz 0x001679b0 memsz 0x001679b0 flags rwx
LOAD off 0x00170000 vaddr 0x88008000 paddr 0x8c1679b0 align 2**15
filesz 0x00018d2c memsz 0x00018d2c flags rw-private flags = 5000002: [Version5 EABI] [has entry point]
my rootfs (busybox, no init) is 153600 bytes big.
After booting I get:
/ # free
total used free shared buffers
Mem: 3892 1428 2464 0 0
-/+ buffers: 1428 2464
but it doesn't run anything but a busybox shell ATM. Assuming the next smaller configuration is 2 MiB of RAM I'd say that machine can maybe boot, but cannot do anything sensible after that.
Quoted 3 lines
* What user space are you running? Anything that's easy to build for testing? Should that run with a mach-virt kernel built for ARMv7-A NOMMU?
There is a BSP publically available at
http://git-public.pengutronix.de/?p=OSELAS.BSP-EnergyMicro-Gecko.git;a=summary
which also includes a README file. For troubleshooting /join #efm32 on freenode.
Quoted 1 line
* An ARMv7-M kernel cannot run on either ARMv4/v5 nor ARMv6/v7-A, right?
The entry convention is different (ARMv7-M doesn't support the ARM instruction set but you need to jump into the kernel in ARM mode for v4-v7). Other that that I don't know if there is a problem. Maybe Jonathan can say anything here? Or alternatively if you want an efm32 devboard, just tell me.
Quoted 1 line
Do you prevent building such a kernel in
Kconfig?
I'm sure my Kconfig magic isn't waterproof. It took me a few tries to expand the multiarch architecture selection to make v7-m selectable at all.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Quoted 8 lines · Uwe Kleine-K?nig
Hi Arnd,
Quoted 5 lines · Arnd Bergmann
Quoted 3 lines · Uwe Kleine-K?nig
I made that work now and can prepare a patch. I had to drop "depends on !ARCH_MULTIPLATFORM" from
XIP_KERNEL. That's because my machine only works withXIP_KERNELas it only has 4 MiB of RAM.
Quoted 6 lines
Quoted 5 lines
Ok, cool. We might run into a few problems with 'make randconfig' and 'make allyesconfig' when it becomes possible to enable
XIP_KERNELthen. IIRC, there is no fundamental reason to disallowXIP_KERNELwithARCH_MULTIPLATFORM, but I added the dependency because it causes build errors in combination with other options.ah, OK. Do you have an idea to fix both?
No, I don't actually remember what problems I ran into. It may be anywhere from trivial to impossible to fix.
Quoted 21 lines
Quoted 4 lines
* Do you think 4MB is now a strict lower bound for running a modern kernel? It would be a good data point if we could show that any target with less than that is by definition broken and could get removed from the kernel. What is the size of your kernel and user space?
$ objdump -p vmlinuxvmlinux: file format elf32-littlearm
Program Header:
LOAD off 0x00000000 vaddr 0x88020000 paddr 0x88020000 align 2**15 filesz 0x00000094 memsz 0x0000a9f4 flags rw- LOAD off 0x00008000 vaddr 0x8c000000 paddr 0x8c000000 align 2**15 filesz 0x001679b0 memsz 0x001679b0 flags rwx LOAD off 0x00170000 vaddr 0x88008000 paddr 0x8c1679b0 align 2**15 filesz 0x00018d2c memsz 0x00018d2c flags rw-private flags = 5000002: [Version5 EABI] [has entry point]
my rootfs (busybox, no init) is 153600 bytes big.
After booting I get:
Quoted 8 lines
/ # free
total used free shared buffers
Mem: 3892 1428 2464 0 0
-/+ buffers: 1428 2464but it doesn't run anything but a busybox shell ATM. Assuming the next smaller configuration is 2 MiB of RAM I'd say that machine can maybe boot, but cannot do anything sensible after that.
Ok, thanks for that data! I can still imagine embedded applications where you have a custom /sbin/init that does just one thing even with 2MB, but it's good to know that a 4MB system is still basically usable with some free memory left for workloads.
Quoted 9 lines
Quoted 3 lines
* What user space are you running? Anything that's easy to build for testing? Should that run with a mach-virt kernel built for ARMv7-A NOMMU?
There is a BSP publically available at
http://git-public.pengutronix.de/?p=OSELAS.BSP-EnergyMicro-Gecko.git;a=summary
which also includes a README file. For troubleshooting /join #efm32 on freenode.
I've never tried ptxdist, but if that is known to work fine with NOMMU, I might just try building the base distro and running it on mach-virt.
Does this work with ELF FDPIC or do you need binfmt-flat?
Quoted 6 lines
Quoted 1 line
* An ARMv7-M kernel cannot run on either ARMv4/v5 nor ARMv6/v7-A, right?
The entry convention is different (ARMv7-M doesn't support the ARM instruction set but you need to jump into the kernel in ARM mode for v4-v7). Other that that I don't know if there is a problem. Maybe Jonathan can say anything here? Or alternatively if you want an efm32 devboard, just tell me.
I haven't started a test farm like Olof has yet. I'll have to think about whether I want to have my own, but he might also be interested in adding a NOMMU target to his collection.
Quoted 4 lines
Quoted 1 line
Do you prevent building such a kernel in
Kconfig?I'm sure my
Kconfigmagic isn't waterproof. It took me a few tries to expand the multiarch architecture selection to make v7-m selectable at all.
Ok, I can have a look and give you suggestions for how it needs to be phrased if it currently allows broken (non-building) combinations.
Arnd
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
Hello Arnd,
Quoted 12 lines · Arnd Bergmann
Quoted 11 lines · Uwe Kleine-K?nig
Quoted 10 lines · Arnd Bergmann
Quoted 3 lines · Uwe Kleine-K?nig
I made that work now and can prepare a patch. I had to drop "depends on !ARCH_MULTIPLATFORM" from
XIP_KERNEL. That's because my machine only works withXIP_KERNELas it only has 4 MiB of RAM.Ok, cool. We might run into a few problems with 'make randconfig' and 'make allyesconfig' when it becomes possible to enable
XIP_KERNELthen. IIRC, there is no fundamental reason to disallowXIP_KERNELwithARCH_MULTIPLATFORM, but I added the dependency because it causes build errors in combination with other options.
Quoted 4 lines
Quoted 1 line
ah, OK. Do you have an idea to fix both?
No, I don't actually remember what problems I ran into. It may be anywhere from trivial to impossible to fix.
I sent a patch series (without looking much for problems :-).
Quoted 11 lines
Quoted 6 lines
There is a BSP publically available at
http://git-public.pengutronix.de/?p=OSELAS.BSP-EnergyMicro-Gecko.git;a=summary
which also includes a README file. For troubleshooting /join #efm32 on freenode.
I've never tried ptxdist, but if that is known to work fine with NOMMU, I might just try building the base distro and running it on mach-virt.
Does this work with ELF FDPIC or do you need binfmt-flat?
I use binfmt-flat, but that's because Marc (on Cc: now) created the base BSP for me that way. I don't know what ELF FDPIC is.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Do you prevent building such a kernel in
Kconfig?I'm sure my
Kconfigmagic isn't waterproof. It took me a few tries to expand the multiarch architecture selection to make v7-m selectable at all.Ok, I can have a look and give you suggestions for how it needs to be phrased if it currently allows broken (non-building) combinations.
You have the chance now to comment in the respective thread.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH v2 1/1 ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs
In reply to Uwe Kleine-KönigQuoted 4 lines · Uwe Kleine-K?nig
Hi Arnd,
Quoted 1 line · Arnd Bergmann
On Thursday 26 September 2013, Uwe Kleine-K?nig wrote:
[...]
Quoted 6 lines
Quoted 1 line
* An ARMv7-M kernel cannot run on either ARMv4/v5 nor ARMv6/v7-A, right?
The entry convention is different (ARMv7-M doesn't support the ARM instruction set but you need to jump into the kernel in ARM mode for v4-v7). Other that that I don't know if there is a problem. Maybe Jonathan can say anything here?
There's a more fundamental difference between V7M and other things before it - V7M uses a different exception model (We don't have the idea of SVC, USR, IRQ, FIQ etc, instead it is Thread/Process/Handler modes).
So no, V7M is V7M, I'm afraid.
Quoted 2 lines
Or alternatively if you want an efm32
devboard, just tell me.
They're cool, I can recommend one ;)
Quoted 5 lines
Quoted 2 lines
Do you prevent building such a kernel in
Kconfig?I'm sure my
Kconfigmagic isn't waterproof. It took me a few tries to expand the multiarch architecture selection to make v7-m selectable at all.
There's a patch series I posted in the past for !MMU with Vexpress that was a way to have a !MMU without changing the ARCH_MULTIPLATFORM configuration:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-May/168106.html
You could take a look at that as an alternative approach, but the other series you've sent looks reasonable from a !MMU/Multiplatform point of view, I'm just not sure about the XIP stuff.
Jonny
PATCH 1/1 ARM: DEBUG_LL on efm32 SoCs
In reply to Uwe Kleine-KönigThis implements output of debug messages on efm32 SoCs.
--- arch/arm/Kconfig.debug | 17 ++++++++++++++++ arch/arm/include/debug/efm32.S | 45 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 62 insertions(+) create mode 100644 arch/arm/include/debug/efm32.S
arch/arm/Kconfig.debug +17 -0
@@ -834,6 +834,20 @@ choice options; the platform specific options are deprecated and will be soon removed. + config DEBUG_LL_UART_EFM32 + bool "Kernel low-level debugging via efm32 UART" + depends on ARCH_EFM32 + help + Say Y here if you want the debug print routines to direct + their output to an UART or USART port on efm32 based + machines. Use the following addresses for DEBUG_UART_PHYS: + + 0x4000c000 | USART0 + 0x4000c400 | USART1 + 0x4000c800 | USART2 + 0x4000e000 | UART0 + 0x4000e400 | UART1 + config DEBUG_LL_UART_PL01X bool "Kernel low-level debugging via ARM Ltd PL01x Primecell UART" help
@@ -885,6 +899,7 @@ config DEBUG_LL_INCLUDE default "debug/8250.S" if DEBUG_LL_UART_8250 || DEBUG_UART_8250 default "debug/pl01x.S" if DEBUG_LL_UART_PL01X || DEBUG_UART_PL01X default "debug/exynos.S" if DEBUG_EXYNOS_UART + default "debug/efm32.S" if DEBUG_LL_UART_EFM32 default "debug/icedcc.S" if DEBUG_ICEDCC default "debug/imx.S" if DEBUG_IMX1_UART || \ DEBUG_IMX25_UART || \
@@ -951,6 +966,7 @@ config DEBUG_UART_PHYS default 0x20064000 if DEBUG_RK29_UART1 || DEBUG_RK3X_UART2 default 0x20068000 if DEBUG_RK29_UART2 || DEBUG_RK3X_UART3 default 0x20201000 if DEBUG_BCM2835 + default 0x4000e400 if DEBUG_LL_UART_EFM32 default 0x40090000 if ARCH_LPC32XX default 0x40100000 if DEBUG_PXA_UART1 default 0x42000000 if ARCH_GEMINI
@@ -981,6 +997,7 @@ config DEBUG_UART_PHYS default 0xfff36000 if DEBUG_HIGHBANK_UART default 0xfffff700 if ARCH_IOP33X depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \ + DEBUG_LL_UART_EFM32 || \ DEBUG_UART_8250 || DEBUG_UART_PL01X config DEBUG_UART_VIRT
arch/arm/include/debug/efm32.S new file +45 -0
45 lines not on this page · raw message
Signature · 1 line
1.8.4.rc3