Skip to contentSkip to conversation

ARM: dts: am335x-boneblack: move fixed regulator to board level

PATCH Superseded Nishanth Menon 3 participants 3 messages Sep 19, 2013 – Sep 27, 2013 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: am335x-boneblack: move fixed regulator to board level

3.3V fixed regulator does not belong to TPS node - as a result the fixed regulator is never probed and MMC is continually deferred due to lack of regulator.

Move the fixed regulator to be at root of platform.

---

Based on: (benoit's for_3.13/dts branch)
https://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.13/dts
+
https://patchwork.kernel.org/patch/2902711/

Test Log:
before: http://pastebin.com/UuCsBg2d
After: http://pastebin.com/149FWujf
notice how "vmmcsd_fixed: 3300 mV " does not appear in the log before the patch.

 arch/arm/boot/dts/am335x-bone-common.dtsi |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm/boot/dts/am335x-bone-common.dtsi +7 -7
index 56361ce..fe2742e 100644
@@ -215,6 +215,13 @@
 			default-state = "off";
 		};
 	};
+
+	vmmcsd_fixed: fixedregulator at 0 {
+		compatible = "regulator-fixed";
+		regulator-name = "vmmcsd_fixed";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
 };
 
 /include/ "tps65217.dtsi"
@@ -259,13 +266,6 @@
 			regulator-always-on;
 		};
 	};
-
-	vmmcsd_fixed: fixedregulator at 0 {
-		compatible = "regulator-fixed";
-		regulator-name = "vmmcsd_fixed";
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-	};
 };
 
 &cpsw_emac0 {
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: dts: am335x-boneblack: move fixed regulator to board level

Quoted 7 lines · Nishanth Menon

3.3V fixed regulator does not belong to TPS node - as a result the fixed regulator is never probed and MMC is continually deferred due to lack of regulator.

Move the fixed regulator to be at root of platform.

I boot tested this on my BBB.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130920/d67cbab2/attachment-0001.sig>
#2 lore raw

PATCH 1/1 ARM: dts: am335x-boneblack: move fixed regulator to board level

Quoted 11 lines · Felipe Balbi
Quoted 7 lines · Nishanth Menon

3.3V fixed regulator does not belong to TPS node - as a result the fixed regulator is never probed and MMC is continually deferred due to lack of regulator.

Move the fixed regulator to be at root of platform.