tracing: don't stuff stale pointers in filp->private_data
Probably harmless, but still not a nice thing to do.
Signed-off-by Dave Jones <[email protected]>
kernel/trace/trace_events.c +1 -0
@@ -1124,6 +1124,7 @@ static int system_tr_open(struct inode *inode, struct file *filp)if (ret <0 ) {trace_array_put (tr);kfree (dir); + dir =NULL ; } filp->private_data = dir;
Quoted 9 lines · Dave Jones
Probably harmless, but still not a nice thing to do.
Signed-off-by Dave Jones <[email protected]>kernel/trace/trace_events.c +0
-0
kernel/trace/trace_events.c static int system_tr_open(struct inode *inode, struct file *filp) · line 1130
Quoted 7 lines
kernel/trace/trace_events.c +1
-0@@ -1124,6 +1124,7 @@ static int system_tr_open(struct inode *inode, struct file *filp)if (ret <0 ) {trace_array_put (tr);kfree (dir); + dir =NULL ; } filp->private_data = dir;
Er... Why not simply return ret; instead?
Steven Rostedt
maintainerOr make the assignment in an else block.
-- Steve
Quoted 21 lines · Al Viro
Review
Quoted 5 lines · Dave Jones
Probably harmless, but still not a nice thing to do.
Signed-off-by Dave Jones <[email protected]>(quoted diff) +0
-0
b/kernel/trace/trace_events.ckernel/trace/trace_events.c static int system_tr_open(struct inode *inode,
Quoted 4 lines
index 368a4d5..75d3556 100644
kernel/trace/trace_events.c +0
-0@@ -1124,6 +1124,7 @@ static int system_tr_open(struct inode *inode,struct file *filp)
kernel/trace/trace_events.c static int system_tr_open(struct inode *inode, struct file *filp) · line 1130
Quoted 7 lines
kernel/trace/trace_events.c +1
-0if (ret <0 ) {trace_array_put (tr);kfree (dir); + dir =NULL ; } filp->private_data = dir;Er... Why not simply return ret; instead?
Signature · 1 line
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
Probably harmless, but still not a nice thing to do.
Signed-off-by Dave Jones <[email protected]>
kernel/trace/trace_events.c +2 -2
@@ -1124,10 +1124,10 @@ static int system_tr_open(struct inode *inode, struct file *filp)if (ret <0 ) {trace_array_put (tr);kfree (dir); + }else { + filp->private_data = dir; } - filp->private_data = dir; -return ret; }