Skip to contentSkip to conversation

sched: drop un-necessary task_rq calls

PATCH New Michael S. Tsirkin 2 participants 2 messages Sep 22, 2013 – Sep 25, 2013 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched: drop un-necessary task_rq calls

We always know the rq used, let's just pass it around. This seems to cut the size of scheduler core down a tiny bit.

Before:
[linux]$ size kernel/sched/core-old.o
text data bss dec hex filename
62760 16130 3876 82766 1434e kernel/sched/core.o
After:
[linux]$ size kernel/sched/core-rq.o
text data bss dec hex filename
62566 16130 3876 82572 1428c kernel/sched/core-rq.o

---
 kernel/sched/core.c  |  6 +++---
 kernel/sched/stats.h | 46 ++++++++++++++++++++++++----------------------
 2 files changed, 27 insertions(+), 25 deletions(-)
kernel/sched/core.c +3 -3
index 05c39f0..8558187 100644
@@ -767,14 +767,14 @@ static void set_load_weight(struct task_struct *p)
 static void enqueue_task(struct rq *rq, struct task_struct *p, int flags)
 {
 	update_rq_clock(rq);
-	sched_info_queued(p);
+	sched_info_queued(rq, p);
 	p->sched_class->enqueue_task(rq, p, flags);
 }
 
 static void dequeue_task(struct rq *rq, struct task_struct *p, int flags)
 {
 	update_rq_clock(rq);
-	sched_info_dequeued(p);
+	sched_info_dequeued(rq, p);
 	p->sched_class->dequeue_task(rq, p, flags);
 }
 
@@ -1853,7 +1853,7 @@ prepare_task_switch(struct rq *rq, struct task_struct *prev,
 		    struct task_struct *next)
 {
 	trace_sched_switch(prev, next);
-	sched_info_switch(prev, next);
+	sched_info_switch(rq, prev, next);
 	perf_event_task_sched_out(prev, next);
 	fire_sched_out_preempt_notifiers(prev, next);
 	prepare_lock_switch(rq, next);
kernel/sched/stats.h +24 -22

114 lines not on this page · raw message

Signature · 1 line
MST
#1 lore raw

[tip:sched/core] sched: Micro-optimize by dropping unnecessary task_rq() calls

sched: Micro-optimize by dropping unnecessary task_rq() calls
Commit-ID:  4314895165623879937f46d767673654662b570c
Gitweb:     http://git.kernel.org/tip/4314895165623879937f46d767673654662b570c
Author:     Michael S. Tsirkin <[email protected]>
AuthorDate: Sun, 22 Sep 2013 17:20:54 +0300
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 25 Sep 2013 13:51:06 +0200

sched: Micro-optimize by dropping unnecessary task_rq() calls

We always know the rq used, let's just pass it around. This seems to cut the size of scheduler core down a tiny bit:

Before:

[linux]$ size kernel/sched/core.o.orig
text data bss dec hex filename
62760 16130 3876 82766 1434e kernel/sched/core.o.orig

After:

[linux]$ size kernel/sched/core.o.patched
text data bss dec hex filename
62566 16130 3876 82572 1428c kernel/sched/core.o.patched

Probably speeds it up as well.

---
 kernel/sched/core.c  |  6 +++---
 kernel/sched/stats.h | 46 ++++++++++++++++++++++++----------------------
 2 files changed, 27 insertions(+), 25 deletions(-)
kernel/sched/core.c +3 -3
index c2283c5..ac57967 100644
@@ -767,14 +767,14 @@ static void set_load_weight(struct task_struct *p)
 static void enqueue_task(struct rq *rq, struct task_struct *p, int flags)
 {
 	update_rq_clock(rq);
-	sched_info_queued(p);
+	sched_info_queued(rq, p);
 	p->sched_class->enqueue_task(rq, p, flags);
 }
 
 static void dequeue_task(struct rq *rq, struct task_struct *p, int flags)
 {
 	update_rq_clock(rq);
-	sched_info_dequeued(p);
+	sched_info_dequeued(rq, p);
 	p->sched_class->dequeue_task(rq, p, flags);
 }
 
@@ -1839,7 +1839,7 @@ prepare_task_switch(struct rq *rq, struct task_struct *prev,
 		    struct task_struct *next)
 {
 	trace_sched_switch(prev, next);
-	sched_info_switch(prev, next);
+	sched_info_switch(rq, prev, next);
 	perf_event_task_sched_out(prev, next);
 	fire_sched_out_preempt_notifiers(prev, next);
 	prepare_lock_switch(rq, next);
kernel/sched/stats.h +24 -22

114 lines not on this page · raw message