meta: iif/oifname should be host byte order
Florian Westphal
maintainerPATCH 1/1 meta: iif/oifname should be host byte order
src/nft add rule filter output meta oifname eth0
doesn't work on x86. Problem is that nft declares these as BYTEORDER_INVALID, but when converting the string mpz_import_data treats INVALID like BIG_ENDIAN.
[ cmp eq reg 1 0x00000000 0x00000000 0x65000000 0x00306874 ]
as kernel nft_cmp_eval basically boils down to
memcmp(reg, skb->dev->name, sizeof(reg) comparision fails.
with patch:
[ cmp eq reg 1 0x30687465 0x00000000 0x00000000 0x00000000 ]
---
On a related note:
Instead of
memcmp(register, devicename, strlen(register)+1) [i.e., strcmp] The comparision in kernel is always
memcmp(register, dev->name, IFNAMSIZ).
IOW, why does expr_evaluate_value() replace the interface names string length with the template length (IFNAMSIZ)?
It doesn't seem to be needed, and without it supporting iptables-style wildcard name match (oifname "eth+") should be quite simple.
src/datatype.c +2 -2
@@ -258,7 +258,7 @@ static void string_type_print(const struct expr *expr)unsigned int len =div_round_up (expr->len,BITS_PER_BYTE );char data[len]; -mpz_export_data (data, expr->value,BYTEORDER_BIG_ENDIAN , len); +mpz_export_data (data, expr->value,BYTEORDER_HOST_ENDIAN , len);printf ("\"%s\"" , data); }
@@ -266,7 +266,7 @@ static struct error_record *string_type_parse(const struct expr *sym, struct expr **res) { *res =constant_expr_alloc (&sym->location, &string_type, -BYTEORDER_INVALID , +BYTEORDER_HOST_ENDIAN , (strlen (sym->identifier) +1 ) *BITS_PER_BYTE , sym->identifier);return NULL ;
src/meta.c +2 -2
@@ -295,14 +295,14 @@ static const struct meta_template meta_templates[] = { 4 * 8, BYTEORDER_HOST_ENDIAN), [NFT_META_IIFNAME ] =META_TEMPLATE ("iifname" , &string_type,IFNAMSIZ *BITS_PER_BYTE , - BYTEORDER_INVALID), + BYTEORDER_HOST_ENDIAN), [NFT_META_IIFTYPE ] =META_TEMPLATE ("iiftype" , &arphrd_type, 2 * 8, BYTEORDER_HOST_ENDIAN), [NFT_META_OIF ] =META_TEMPLATE ("oif" , &ifindex_type, 4 * 8, BYTEORDER_HOST_ENDIAN), [NFT_META_OIFNAME ] =META_TEMPLATE ("oifname" , &string_type,IFNAMSIZ *BITS_PER_BYTE , - BYTEORDER_INVALID), + BYTEORDER_HOST_ENDIAN), [NFT_META_OIFTYPE ] =META_TEMPLATE ("oiftype" , &arphrd_type, 2 * 8, BYTEORDER_HOST_ENDIAN), [NFT_META_SKUID] = META_TEMPLATE("skuid", &uid_type,
Signature · 1 line
1.7.8.6
Pablo Neira Ayuso
maintainerQuoted 6 lines · Florian Westphal
src/nft add rule filter output meta oifname eth0
doesn't work on x86. Problem is that nft declares these as
BYTEORDER_INVALID, but when converting the stringmpz_import_datatreats INVALID likeBIG_ENDIAN.
Quoted 8 lines
[ cmp eq reg 1
0x000000000x000000000x650000000x00306874]as kernel
nft_cmp_evalbasically boils down tomemcmp(reg,
skb->dev->name, sizeof(reg) comparision fails.with patch:
[ cmp eq reg 10x306874650x000000000x000000000x00000000]
Applied with small change:
Error: Byteorder mismatch: expected invalid, got host endian add rule filter output ct helper "ftp" counter
^^^^^
I was hitting that error here. I have mangled your patch to change endianess of the helper name, I couldn't find any other string type in the current tree that needs to be adjusted.
Quoted 10 lines
Signed-off-by Florian Westphal <[email protected]>---
On a related note:
Instead of
memcmp(register, devicename, strlen(register)+1)[i.e., strcmp] The comparision in kernel is always
memcmp(register, dev->name, IFNAMSIZ).IOW, why does
expr_evaluate_value()replace the interface names string length with the template length (IFNAMSIZ)?
I see, it's adjusting the expression to use the type length. I cannot currently find a reason any reason for not changing that.
Quoted 2 lines
It doesn't seem to be needed, and without it supporting iptables-style wildcard name match (oifname "eth+") should be quite simple.
We support this in iptables-nftables, to interpret the data from the kernel the assumption is that if_nametoindex fails to resolve the interface name, then it handles the interface name as an interface wildcard. But that's a problem, if the interface is removed, all existing rules for it will be interpreted as wildcard.
Regards.