Skip to contentSkip to conversation

ASoC: ab8500: Explicitly set I/O up

PATCH In review Mark Brown 3 participants 8 messages Sep 24, 2013 – Sep 25, 2013

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

PATCH 1/1 ASoC: ab8500: Explicitly set I/O up

From: Mark Brown <[email protected]>

We do some I/O in probe so we need to ensure the I/O operations are fully set up then.

---
 sound/soc/codecs/ab8500-codec.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/ab8500-codec.c +2 -0
index ca500fd..a0394a8 100644
@@ -2473,6 +2473,8 @@ static int ab8500_codec_probe(struct snd_soc_codec *codec)
 
 	dev_dbg(dev, "%s: Enter.\n", __func__);
 
+	snd_soc_codec_set_cache_io(codec, 0, 0, SND_SOC_REGMAP);
+
 	/* Setup AB8500 according to board-settings */
 	pdata = dev_get_platdata(dev->parent);
 
Signature · 1 line
1.8.4.rc3
#1 lore raw
Quoted 10 lines · Mark Brown

From: Mark Brown <[email protected]>

We do some I/O in probe so we need to ensure the I/O operations are fully set up then.

---
 sound/soc/codecs/ab8500-codec.c | 2 ++
 1 file changed, 2 insertions(+)

Olof, would you mind testing this please?

Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
author maintainer
#2 lore raw
Quoted 7 lines · Lee Jones
Quoted 4 lines · Mark Brown

From: Mark Brown <[email protected]>

We do some I/O in probe so we need to ensure the I/O operations are fully set up then.

Olof, would you mind testing this please?

It's in -next so should be caught by the build tomorrow if you don't mind waiting.

#3 lore raw
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines

From: Mark Brown <[email protected]>

We do some I/O in probe so we need to ensure the I/O operations are fully set up then.

Olof, would you mind testing this please?

It's in -next so should be caught by the build tomorrow if you don't mind waiting.

I'm in no rush. OOI, did the build pick up the first issue reported by Olof?

Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
author maintainer
#4 lore raw
Quoted 4 lines · Lee Jones
Quoted 2 lines

It's in -next so should be caught by the build tomorrow if you don't mind waiting.

I'm in no rush. OOI, did the build pick up the first issue reported by Olof?

Olof found this by doing boot tests on -next.

#5 lore raw
In reply to Mark Brown
Quoted 11 lines · Mark Brown
Quoted 7 lines · Lee Jones
Quoted 4 lines · Mark Brown

From: Mark Brown <[email protected]>

We do some I/O in probe so we need to ensure the I/O operations are fully set up then.

Olof, would you mind testing this please?

It's in -next so should be caught by the build tomorrow if you don't mind waiting.

Looks like the overnight -next run passed without problems on snowball, thanks for the quick fix.

-Olof

#6 lore raw
Quoted 8 lines · Olof Johansson
Quoted 7 lines · Mark Brown
Quoted 5 lines · Lee Jones
Quoted 4 lines · Mark Brown

From: Mark Brown <[email protected]>

We do some I/O in probe so we need to ensure the I/O operations are fully set up then.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Olof, would you mind testing this please?

It's in -next so should be caught by the build tomorrow if you don't mind waiting.

Looks like the overnight -next run passed without problems on snowball, thanks for the quick fix.

Nice. Thanks for Reporting/Testing Olof.

Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
author maintainer
#7 lore raw
In reply to Olof Johansson
Quoted 2 lines · Olof Johansson

Looks like the overnight -next run passed without problems on snowball, thanks for the quick fix.

Great, thanks.